[pve-devel] [PATCH storage] api: fix get content call for volumes

2023-03-06 Thread Christian Ebner
`pvesh get /nodes/{node}/storage/{storage}/content/{volume}` failed for several storage types, because the respective storage plugins returned only the volumes `size` on `volume_size_info` calls, while also the format is required. This patch fixes the issue by returning also `format` and `used`, t

[pve-devel] applied: [PATCH access-control] fix #4518: improve ACL computation performance

2023-03-06 Thread Thomas Lamprecht
Am 15/02/2023 um 10:44 schrieb Fabian Grünbichler: > by switching to a tree-based in-memory structure, like we do in PBS. > > instead of parsing ACL entries into a hash using the full ACL path as key for > each entry, parse them into a tree-like nested hash. when evaluating ACLs, > iterating over

Re: [pve-devel] [PATCH storage] api: fix get content call for volumes

2023-03-06 Thread Fiona Ebner
Am 06.03.23 um 10:37 schrieb Christian Ebner: > `pvesh get /nodes/{node}/storage/{storage}/content/{volume}` failed for > several storage types, because the respective storage plugins returned > only the volumes `size` on `volume_size_info` calls, while also the format > is required. > > This patc

Re: [pve-devel] [PATCH storage] api: fix get content call for volumes

2023-03-06 Thread Christian Ebner
> On 06.03.2023 11:17 CET Fiona Ebner wrote: > > > Am 06.03.23 um 10:37 schrieb Christian Ebner: > > `pvesh get /nodes/{node}/storage/{storage}/content/{volume}` failed for > > several storage types, because the respective storage plugins returned > > only the volumes `size` on `volume_size_i

Re: [pve-devel] [PATCH storage] api: fix get content call for volumes

2023-03-06 Thread Fiona Ebner
Am 06.03.23 um 11:36 schrieb Christian Ebner: > >> On 06.03.2023 11:17 CET Fiona Ebner wrote: >> >> >> Am 06.03.23 um 10:37 schrieb Christian Ebner: >>> `pvesh get /nodes/{node}/storage/{storage}/content/{volume}` failed for >>> several storage types, because the respective storage plugins retu

[pve-devel] [PATCH manager] ui: cpuflagselector: reduce size to fit into create wizard

2023-03-06 Thread Aaron Lauterer
With the addition of the CPU Affinity option, the CPU flags grid was too high and would be cut of inside the VM create wizard at the bottom. To not make the create wizard highter than it already is, the other option is to make the cpu flags grid a little bit shorter. The window to edit the CPU se

Re: [pve-devel] [PATCH storage] api: fix get content call for volumes

2023-03-06 Thread Christian Ebner
> On 06.03.2023 11:52 CET Fiona Ebner wrote: > > > Am 06.03.23 um 11:36 schrieb Christian Ebner: > > > >> On 06.03.2023 11:17 CET Fiona Ebner wrote: > >> > >> > >> Am 06.03.23 um 10:37 schrieb Christian Ebner: > >>> `pvesh get /nodes/{node}/storage/{storage}/content/{volume}` failed for >

[pve-devel] [PATCH v2 storage] api: fix get content call for volumes

2023-03-06 Thread Christian Ebner
`pvesh get /nodes/{node}/storage/{storage}/content/{volume}` failed for several storage types, because the respective storage plugins returned only the volumes `size` on `volume_size_info` calls, while also the format is required. This patch fixes the issue by returning also `format` and where pos

[pve-devel] applied-series: [PATCH v2 http-server 0/2] fix #4344: ignore unused multipart headers

2023-03-06 Thread Thomas Lamprecht
Am 18/11/2022 um 02:39 schrieb John Hollowell: > This fixes an issue where an upload request without a Content-Type in > the file's multipart part would prevent the upload and throw > missleading errors. This patch removes the requirement and ignores > all multipart headers once the needed informat

[pve-devel] [PATCH widget-toolkit] fix #4421: ui: guard setProxy against races of slow vs fast requests

2023-03-06 Thread Friedrich Weber
Some UI components use `Ext.data.Store.setProxy` to change their associated API endpoint URL in reaction to user input. One example is `BackupView`, which calls `setProxy` when the user switches from listing backups on storage A to listing backups on storage B. However, if A is slow, the UI may rec

[pve-devel] [PATCH manager 3/7] ui: VMSelector: change from filter to load parameters

2023-03-06 Thread Dominik Csapak
so that we can modify the filters without having to consider filtering for the type. Note that 'vm' for the 'type' parameter also returns containers. Signed-off-by: Dominik Csapak --- www/manager6/form/VMSelector.js | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/www/m

[pve-devel] [PATCH manager 6/7] fix #4239: ui: show selected but non-existing vmids in backup edit

2023-03-06 Thread Dominik Csapak
by adding records manually when using 'setValue' on a vmselector. It'll show up normally but have an 'unknown' nodename, and no type/status/etc. Signed-off-by: Dominik Csapak --- www/manager6/form/VMSelector.js | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a

[pve-devel] [PATCH manager 1/7] ui: VMSelector: columns customizable

2023-03-06 Thread Dominik Csapak
we will reuse this component but don't want to show all columns Signed-off-by: Dominik Csapak --- www/manager6/form/VMSelector.js | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js index 78cd90134..d8

[pve-devel] [PATCH manager 4/7] ui: VMSelector: correctly change invalid class on en/disable

2023-03-06 Thread Dominik Csapak
since we manually handle the invalid class, we have to manually trigger that on setDisabled Signed-off-by: Dominik Csapak --- www/manager6/form/VMSelector.js | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSele

[pve-devel] [PATCH manager 2/7] ui: VMSelector: improve {set, get}Value handling with a loading store

2023-03-06 Thread Dominik Csapak
when we do {set,get}Value during a store load, the store might be empty or incomplete, so defer the selection after the load and cache the value for getValue invocations until the store is loaded Signed-off-by: Dominik Csapak --- www/manager6/form/VMSelector.js | 30 ++---

[pve-devel] [PATCH manager 0/7] backup edit window improvements

2023-03-06 Thread Dominik Csapak
two bugfixes (the VMSelector changes are necessary for those) and a refactor of the edit window (i put that patch at the end, because even with simplifications, it's still ~30 lines more, and i was not sure if that's worth it) Dominik Csapak (7): ui: VMSelector: columns customizable ui: VMSele

[pve-devel] [PATCH manager 5/7] fix #4490: ui: add column filters in Backup Job edit window

2023-03-06 Thread Dominik Csapak
by replacing the manual vm grid implementation and reusing the VMSelector we already have. Since this is a full-fledged form field, we can drop the complicated selection tracking / reselecting that we did by saving into a hidden field. Signed-off-by: Dominik Csapak --- www/manager6/dc/Backup.js

[pve-devel] [PATCH manager 7/7] ui: BackupEdit: refactor edit window into declarative style

2023-03-06 Thread Dominik Csapak
simplifies some things, e.g. en/disabling the grid and pool selector while refactoring, cleanup up some smaller things like nested if/else paths, unnecessary splitting of the deprecated 'dow' parameter, etc. Signed-off-by: Dominik Csapak --- www/manager6/dc/Backup.js | 690 --

[pve-devel] [PATCH storage 1/1] api2: download-url: add allow-overwrite option

2023-03-06 Thread Sebastian Fleer via pve-devel
--- Begin Message --- PVE::Tools::download_file_from_url already supports allow_overwrite, expose this option via the API. Signed-off-by: Sebastian Fleer --- PVE/API2/Storage/Status.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status

[pve-devel] [PATCH storage 0/1] api2: download-url: add allow-overwrite option

2023-03-06 Thread Sebastian Fleer via pve-devel
--- Begin Message --- I want to build VM-Images for Debian testing regularly in an automated fashion. Since the name of the ISO image [0] doesn't change, I'd like to overwrite the existing image with download-url. It turns out that PVE::Tools::download_file_from_url already has this functionality