[pve-devel] [PATCH docs] qdevice: remove outdated reference to qnetd package

2023-03-02 Thread Fabian Grünbichler
we provided the package back in the Stretch/Buster based releases, but don't anymore since the package in Debian is recent enough nowadays. Signed-off-by: Fabian Grünbichler --- Notes: reported on the forum: https://forum.proxmox.com/threads/question-regarding-corosync-qnetd-package.123540/

Re: [pve-devel] [PATCH qemu-server v3 2/6] added clipboard variable to return at status/current

2023-03-02 Thread Dominik Csapak
comment inline On 10/28/22 14:33, Markus Frank wrote: By that noVNC is able to check if clipboard is active. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 99b426e..25f3a1d 100644 --- a/PVE

Re: [pve-devel] [PATCH manager v3 5/6] added clipboard checkbox & combobox to DisplayEdit

2023-03-02 Thread Dominik Csapak
high level comments: i'd only show the hint when the checkbox is checked or 'novnc' is selected in the combobox also here it shows that the options does not really fit to the display at all, at least i would not search the setting for the console clipboard under the virtual display hardware... (

Re: [pve-devel] [PATCH qemu-server v3 1/6] enable clipboard parameter in vga_fmt

2023-03-02 Thread Dominik Csapak
first: sorry for the late review ;) high level comments: i know why you're adding it to the vga format, but maybe that's not the way to go? we couple the console method with the display quite a lot, but maybe we don't want to further increase that coupling? (imho it would be much nicer to be ab

Re: [pve-devel] [PATCH docs v3 6/6] added noVNC clipboard documentation

2023-03-02 Thread Dominik Csapak
comments inline: On 10/28/22 14:33, Markus Frank wrote: Signed-off-by: Markus Frank --- qm.adoc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qm.adoc b/qm.adoc index 4d0c7c4..3a575bc 100644 --- a/qm.adoc +++ b/qm.adoc @@ -693,6 +693,17 @@ Selecting `serialX` as display 'ty

Re: [pve-devel] [PATCH manager 2/2] ui: cert upload: fix private key field sending empty string

2023-03-02 Thread Max Carrara
On 3/1/23 10:35, Matthias Heiserer wrote: > On 28.02.2023 17:36, Max Carrara wrote: >> The private key's field is now excluded from the upload form's >> JSON data if it's considered empty by Ext.js. >> >> Prior to this change, the form still sent an empty string if no >> private key was provided by

Re: [pve-devel] [PATCH common 1/2] certificate: add subroutine that checks if cert and key match

2023-03-02 Thread Max Carrara
On 3/1/23 11:17, Fabian Grünbichler wrote: > On February 28, 2023 5:36 pm, Max Carrara wrote: >> This is done here in order to allow other packages to make use of >> this subroutine. >> >> Signed-off-by: Max Carrara >> --- >> src/PVE/Certificate.pm | 26 ++ >> 1 file chang

Re: [pve-devel] [PATCH manager follow-up 2/2] ui: ceph status: add tooltip with details to warnings

2023-03-02 Thread Dominik Csapak
one bug did occur when trying it out: if i had my mouse over a warning, and then the warnings vanished all, the tooltip was still there and i could trigger it with hovering over the grid so we want to clean the tooltips up on every load anyway, or at least when the number of items is smaller tha

Re: [pve-devel] [PATCH manager 1/2] ui: ceph: make the warning detail button stand out more

2023-03-02 Thread Dominik Csapak
one nit inline: On 2/22/23 10:36, Aaron Lauterer wrote: The button for more details is barely noticable as something one can click on. By making it more obvious that it is a button, users will hopefully notice it easier. Signed-off-by: Aaron Lauterer --- While moving code around I also change

Re: [pve-devel] [PATCH manager follow-up 2/2] ui: ceph status: add tooltip with details to warnings

2023-03-02 Thread Aaron Lauterer
On 3/2/23 14:15, Dominik Csapak wrote: one bug did occur when trying it out: if i had my mouse over a warning, and then the warnings vanished all, the tooltip was still there and i could trigger it with hovering over the grid so we want to clean the tooltips up on every load anyway, Wouldn'

Re: [pve-devel] [PATCH common 2/2] certificate: fix formatting and whitespace

2023-03-02 Thread Max Carrara
On 3/1/23 11:27, Fabian Grünbichler wrote: > On February 28, 2023 5:36 pm, Max Carrara wrote: >> Signed-off-by: Max Carrara >> --- >> src/PVE/Certificate.pm | 23 --- >> 1 file changed, 12 insertions(+), 11 deletions(-) >> >> diff --git a/src/PVE/Certificate.pm b/src/PVE/Certi

[pve-devel] [PATCH qemu-server] status: fix description of qmpstatus property

2023-03-02 Thread Fiona Ebner
Using the word 'agent' is highly confusing here as there is no QMP agent and thus wrongly suggests that the value is related to the guest agent[0]. [0]: https://forum.proxmox.com/threads/123590/post-537716 Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+),