Re: [pve-devel] [PATCH manager] ui: ldap: fix `Parameter verification error`

2023-02-15 Thread Friedrich Weber
Can confirm this patch fixes the issue, so Tested-by: Friedrich Weber Steps to reproduce: 1) Create LDAP realm with default sync settings 2) Edit LDAP realm, go to sync settings tab, enter values in all text boxes except one (e.g. all except "Group filter") 3) Click OK On current master, th

Re: [pve-devel] [PATCH qemu-server] feature #3937: config: store user in meta property

2023-02-15 Thread Leo Nunner
On 2023-02-14 10:41, Thomas Lamprecht wrote: > On 13/02/2023 11:24, Leo Nunner wrote: >> Adds a field to the "meta" config property which stores the user who >> created the VM. > Should also get this finally added to CTs, I know it's a bit unfair to > add the burden to this patch series, but otherw

[pve-devel] applied: [PATCH manager] ui: ldap: fix `Parameter verification error`

2023-02-15 Thread Thomas Lamprecht
Am 15/02/2023 um 09:29 schrieb Friedrich Weber: > Tested-by: Friedrich Weber with above: applied, thanks to both of you! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] ceph osd: ui: show PGs per OSD

2023-02-15 Thread Aaron Lauterer
On 2/15/23 07:18, Thomas Lamprecht wrote: Am 14/02/2023 um 17:14 schrieb Aaron Lauterer: Seems like the `osd df tree` call is about 25% slower, plus minus. Tested on our AMD test cluster that is currently set up with 3 nodes with 4 OSDs each. 50k iterations. root@jura1:~# ./bench.pl   

[pve-devel] [PATCH access-control] fix #4518: improve ACL computation performance

2023-02-15 Thread Fabian Grünbichler
by switching to a tree-based in-memory structure, like we do in PBS. instead of parsing ACL entries into a hash using the full ACL path as key for each entry, parse them into a tree-like nested hash. when evaluating ACLs, iterating over all path prefixes starting at '/' is needed anyway, so this i

[pve-devel] applied: [PATCH manager] ceph osd: ui: show PGs per OSD

2023-02-15 Thread Thomas Lamprecht
Am 14/02/2023 um 09:13 schrieb Aaron Lauterer: > By switching from 'ceph osd tree' to the 'ceph osd df tree' mon API > equivalent , we get the same data structure with more information per > OSD. One of them is the number of PGs stored on that OSD. > > The number of PGs per OSD is an important num

Re: [pve-devel] applied: Re: [PATCH qemu 1/2] d/rules: add missing export for CFLAGS

2023-02-15 Thread Fiona Ebner
Am 14.02.23 um 10:07 schrieb Thomas Lamprecht: > On 10/02/2023 10:39, Fiona Ebner wrote: >> Otherwise, they don't affect the build of QEMU at all. >> >> Signed-off-by: Fiona Ebner >> --- >> debian/rules | 2 ++ >> 1 file changed, 2 insertions(+) >> >> > > applied, thanks! > > not sure how many

[pve-devel] partially-applied: [PATCH v4 qemu-server 00/16] rework memory hotplug + virtiomem

2023-02-15 Thread Fiona Ebner
Am 13.02.23 um 13:00 schrieb Alexandre Derumier: > This patch series rework the current memory hotplug + virtiomem. > > memory option now have extra options: > > memory: [[current=]] [,max=] [,virtio=<1|0>] > ex: memory: current=1024,max=131072,virtio=1 > > > for classic memory hotplug, when ma

[pve-devel] [PATCH v2 container 1/4] lxc: Fix some trailing whitespace

2023-02-15 Thread Christoph Heiss
No functional changes. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * New patch, split out from patch 2 src/PVE/LXC.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index ce6d5a5..345e343 100644 --- a/src/PVE/LXC.pm +++ b

[pve-devel] [PATCH v2 manager 4/4] lxc: Add `Disconnect` option for network interfaces

2023-02-15 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * Rename option to kebap-case www/manager6/Parser.js | 3 +++ www/manager6/lxc/Network.js | 13 + 2 files changed, 16 insertions(+) diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js index 9f7b2c84..120a4168 10064

[pve-devel] [PATCH v2 container 3/4] lxc: Add `link-down` config to allow setting interfaces as disconnected

2023-02-15 Thread Christoph Heiss
If this network option is set, the host-side link will be forced down and the interface won't be connected to the bridge. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * Split trailing whitespace fix into separate patch * Rename option to kebap-case * Proper option comparison using `saf

[pve-devel] [PATCH v2 container 2/4] lxc: Avoid open-coding normal vs SDN-specific tap_plug()

2023-02-15 Thread Christoph Heiss
This pattern is used in multiple places, thus extract it into a subroutine on its own. No functional changes. Signed-off-by: Christoph Heiss --- Might not be the best place for net_tap_plug(), putting this logic inside PVE::Network would probably make more sense. But that would entail a (bigger)

[pve-devel] [PATCH v2 container/manager 0/4] fix #3413: Add `Disconnect` option for LXC networks

2023-02-15 Thread Christoph Heiss
Add a `Disconnect` option for network interfaces on LXC containers, much like it already exists for VMs. This has been requested in #3413 [0] and seems useful, especially considering we already support the same thing for VMs. One thing to note is that LXC does not seem to support the notion of set

[pve-devel] applied: [PATCH manager] ui: ceph: osd: set default icon for other crush types

2023-02-15 Thread Dominik Csapak
applied, with a short follow up that moves the icon inside the interpolated string (it's shorter and still readable) should we maybe look into adding specific icons for pre-generated types? or is that a niche feature for our users anyway? ___ pve-dev

Re: [pve-devel] applied: [PATCH manager] ui: ceph: osd: set default icon for other crush types

2023-02-15 Thread Aaron Lauterer
> On 02/15/2023 3:08 PM CET Dominik Csapak wrote: > > > applied, with a short follow up that moves the icon inside the interpolated > string > (it's shorter and still readable) > > should we maybe look into adding specific icons for pre-generated types? > or is that a niche feature for our

[pve-devel] [PATCH widget-toolkit] ui: remove extra parenthesis from check to avoid eslint error

2023-02-15 Thread Stefan Sterz
with the additional parenthesis eslint throws an error due to the "no-extra-parens" rule that avoids unnecessary parenthesis. remove them to get rid of the error. Signed-off-by: Stefan Sterz --- i am personally not too happy with this eslint requirement here, but the widget toolkit won't build ot

Re: [pve-devel] [PATCH widget-toolkit] ui: remove extra parenthesis from check to avoid eslint error

2023-02-15 Thread Dominik Csapak
On 2/15/23 15:46, Stefan Sterz wrote: with the additional parenthesis eslint throws an error due to the "no-extra-parens" rule that avoids unnecessary parenthesis. remove them to get rid of the error. Signed-off-by: Stefan Sterz --- i am personally not too happy with this eslint requirement her

Re: [pve-devel] [PATCH widget-toolkit] ui: remove extra parenthesis from check to avoid eslint error

2023-02-15 Thread Matthias Heiserer
On 15.02.2023 16:03, Dominik Csapak wrote: On 2/15/23 15:46, Stefan Sterz wrote: with the additional parenthesis eslint throws an error due to the "no-extra-parens" rule that avoids unnecessary parenthesis. remove them to get rid of the error. Signed-off-by: Stefan Sterz --- i am personally no

Re: [pve-devel] [PATCH widget-toolkit] ui: remove extra parenthesis from check to avoid eslint error

2023-02-15 Thread Dominik Csapak
On 2/15/23 16:22, Matthias Heiserer wrote: On 15.02.2023 16:03, Dominik Csapak wrote: On 2/15/23 15:46, Stefan Sterz wrote: with the additional parenthesis eslint throws an error due to the "no-extra-parens" rule that avoids unnecessary parenthesis. remove them to get rid of the error. Signed-