[pve-devel] [PATCH cluster] fix #4234: vzdump: add cluster-wide configuration

2023-02-09 Thread Leo Nunner
Introduce a cluster-wide vzdump.conf file which gets filled with the default vzdump configuration. Signed-off-by: Leo Nunner --- data/PVE/Cluster.pm | 1 + data/PVE/Cluster/Setup.pm | 32 +--- data/src/status.c | 1 + 3 files changed, 31 insertions(+)

[pve-devel] [PATCH manager cluster docs] Introduce cluster-wide vzdump configuration

2023-02-09 Thread Leo Nunner
This patch introduces a cluster-wide vzdump configuration file. This isn't an override per se, but rather a fallback if there is no local configuration (or the specific parameter is not configured in the local configuration). The settings get merged like this: /etc/vzdump.conf <- /etc/pve/vzdump.

[pve-devel] [PATCH manager] fix #4235: vzdump: add cluster-wide configuration

2023-02-09 Thread Leo Nunner
The different config files get merged in the following order: /etc/vzdump.conf <- /etc/pve/vzdump.conf <- default values So the local configuration takes the highest precedence, then the cluster-wide config, and finally the default values. Signed-off-by: Leo Nunner --- RFC: I'm not really sure

[pve-devel] [PATCH docs] vzdump: document the new cluster-wide config file

2023-02-09 Thread Leo Nunner
+ change the wording from "Global configuration" to "Node-wide configuration" Signed-off-by: Leo Nunner --- The wording was previously already changed by Fiona but hasn't been merged yet: https://lists.proxmox.com/pipermail/pve-devel/2022-December/055123.html vzdump.adoc | 12 1 f

Re: [pve-devel] [PATCH qemu 1/2] fix #4476: savevm-async: avoid looping without progress

2023-02-09 Thread Fiona Ebner
Should we include this before rolling out QEMU 7.2 to public repositories? Will always trigger with large disk(s), when doing a PBS backup and at any later time a snapshot/hibernation. It's not a new problem, but there were a few reports recently, and 7.2-rollout seems like a good time. Am 26.01.2

[pve-devel] [PATCH docs] pveum: remove `auth` part from Keycloak issuer URL

2023-02-09 Thread Lukas Wagner
Keycloak seems to have dropped the `auth` part at some point in the past. Signed-off-by: Lukas Wagner --- pveum.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pveum.adoc b/pveum.adoc index 65d874a..6981d02 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -461,7 +461,7 @@ exa

Re: [pve-devel] [PATCH manager v2 5/6] ui: add window for changing tree related options

2023-02-09 Thread Aaron Lauterer
two small nits inline On 2/2/23 15:41, Dominik Csapak wrote: such as the sorting/grouping of guests. saves them in the browser local storage under 'pve-tree-sorting' adds a button for it next to the the view selector Signed-off-by: Dominik Csapak --- www/manager6/Makefile

Re: [pve-devel] [PATCH manager v2 0/6] fix #1408: ui: make tree sorting configurable

2023-02-09 Thread Aaron Lauterer
Had two small nits in patch 5/6. Otherwise it seems to work nicely. Tested all options and also had tags with tag overrides configured in my tests. Consider this Tested-By: Aaron Lauterer On 2/2/23 15:41, Dominik Csapak wrote: this series allows configuring the sorting of the resource tree

[pve-devel] [PATCH manager] fix #4521: api/tasks: replace upid as filename for task log downloads

2023-02-09 Thread Stefan Sterz
previously the upid would just be used without a file extension when downloading a task log. this lead to rather strange filenames that appeared unfamiliar to users as the upid is not very prevalent in the gui. set a proper file name based on the node name, worker type and a time stamp instead. als

[pve-devel] [PATCH v3 storage] deprecate mkdir option for create-path and create-sub-dirs

2023-02-09 Thread Aaron Lauterer
The `mkdir` option has two meanings[0][1] which are split up in `create-path` and `create-sub-dirs`. The `create-path` option decides if the path to the storage is automatically created or not. The `create-sub-dirs` options decides if the default directory structure (dump, images, ...) at the stor

[pve-devel] [RFC-NOT-TO-BE-APPLIED qemu] log on writes to sector zero

2023-02-09 Thread Fiona Ebner
The idea is to make a qemu build with this available to users affected by bug #2874 in the hope to catch an actual buggy write should it happen again and if it actually comes from QEMU. The logging in block-backend covers writes coming from the virtual disk protocol (e.g. SATA), while the loggin i

[pve-devel] applied: Re: [PATCH manager] fix #4521: api/tasks: replace upid as filename for task log downloads

2023-02-09 Thread Thomas Lamprecht
On 09/02/2023 12:43, Stefan Sterz wrote: > previously the upid would just be used without a file extension when > downloading a task log. this lead to rather strange filenames that > appeared unfamiliar to users as the upid is not very prevalent in the > gui. set a proper file name based on the nod

Re: [pve-devel] [PATCH manager v2 1/6] ui: remove 'Storage View'

2023-02-09 Thread Thomas Lamprecht
On 02/02/2023 15:41, Dominik Csapak wrote: > it is basically the 'Server View' but with less content, and has often > times lead to confusion when uses accidentally selected it. > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/ViewSelector.js | 7 --- > 1 file changed, 7 deletions

[pve-devel] applied: Re: [PATCH docs] pveum: remove misleading 'additionally' in perm-modify description

2023-02-09 Thread Thomas Lamprecht
On 08/02/2023 17:02, Lukas Wagner wrote: > 'additionally' in this context is a bit misleading, as it suggests > that e.g. 'VM.Allocate' AND 'Permissions.Modify' are needed, conflicting > with the previous paragraph. > > Signed-off-by: Lukas Wagner > --- > The ambiguity popped up in a recent suppo