Re: [pve-devel] [PATCH storage] fix #4289: pbs: wait for backup verification to finish before updating volume attribute

2023-01-04 Thread Fiona Ebner
Am 02.01.23 um 13:36 schrieb Christoph Heiss: > diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm > index 4320974..1cdbc11 100644 > --- a/PVE/Storage/PBSPlugin.pm > +++ b/PVE/Storage/PBSPlugin.pm > @@ -906,8 +906,30 @@ sub get_volume_attribute { > return; > } > > +sub wait_for

Re: [pve-devel] [PATCH manager v5 1/3] make task log downloadable in the PVE manager backend

2023-01-04 Thread Stefan Sterz
small nit in-line On 12/1/22 13:50, Daniel Tschlatscher wrote: > The read_tasklog API call now stream the whole log file if the query > parameter 'download' is set to true. > This is done in preparation for the task log download button to be > added in the TaskViewer. > > Signed-off-by: Daniel Ts

[pve-devel] [PATCH manager v6 1/3] make task log downloadable in the PVE manager backend

2023-01-04 Thread Daniel Tschlatscher
The read_tasklog API call now stream the whole log file if the query parameter 'download' is set to true. This is done in preparation for the task log download button to be added in the TaskViewer. Signed-off-by: Daniel Tschlatscher --- Changes from v5: * Made the if check for whether the downloa

[pve-devel] [PATCH manager/widget-toolkit v6] fix: #3971 Tasklog download button

2023-01-04 Thread Daniel Tschlatscher
This patch series' aim is to add a download button in the tasklog- viewer GUI so that users may access the tasklog more easily. (The tasklog-viewer only displays 50 lines at a time) Instead of suddenly returning a file stream when the 'limit' parameter is set to 0, now, a new parameter 'download' n

[pve-devel] [PATCH widget-toolkit v6 3/3] add task log download button in TaskViewer

2023-01-04 Thread Daniel Tschlatscher
Adds a download button in the TaskViewer. Uses the newly created downloadAsFile() method in the Utils class. Signed-off-by: Daniel Tschlatscher --- Changes from v5 * Last version erroneously used "limit=0" instead of the download parameter in the download URL src/window/TaskViewer.js | 17 +++

[pve-devel] [PATCH widget-toolkit v6 2/3] Source file download in new Utils function

2023-01-04 Thread Daniel Tschlatscher
Adds a function for downloading a file from a remote URL in the Utils class and uses it to revise one similar usage in FileBrowser.js Signed-off-by: Daniel Tschlatscher --- No changes from v5 (was last included in v2) src/Utils.js | 13 + src/window/FileBrowser.js | 11

Re: [pve-devel] [PATCH manager/widget-toolkit v6] fix: #3971 Tasklog download button

2023-01-04 Thread Stefan Sterz
series lgtm now and seems to work as intended across pmg/pve/pbs so consider this: Tested-by: Stefan Sterz Reviewed-by: Stefan Sterz On 1/4/23 13:56, Daniel Tschlatscher wrote: > This patch series' aim is to add a download button in the tasklog- > viewer GUI so that users may access the tasklo

[pve-devel] applied: [PATCH manager/widget-toolkit v6] fix: #3971 Tasklog download button

2023-01-04 Thread Thomas Lamprecht
Am 04/01/2023 um 13:56 schrieb Daniel Tschlatscher: > pve-manager: > > Daniel Tschlatscher (1): > make task log downloadable in the PVE manager backend > proxmox-widget-toolkit: > > Daniel Tschlatscher (2): > Source file download call in central function > add task log download button in T

[pve-devel] Empty list as response of an API-endpoint

2023-01-04 Thread Sven Scholle
Hi, I have a problem regarding the API rights management. The following request returns an empty array when issued using a token with the role PVEAuditor: 'pve.foo.bar:8006/api2/json/nodes/{}/storage/{}/content?content=backup&vmid={}'.format(node, storage, vmid) When I disable privilege se