[pve-devel] applied-series: [PATCH v2 storage 1/3] zfs: list: only

2022-12-21 Thread Fabian Grünbichler
thanks! some possible room for further improvements: - zfs_list_zvol could add `-d1` to only list $scfg->{pool} and direct children (then we don't need to filter out any indirect descendants, just the "pool" itself..) - $list in zfs_list_zvol could be initialized as `{}`, then we don't need an

Re: [pve-devel] [PATCH pve-guest-common 1/1] partially fix #2530: snapshots: add pre/post/failed-snapshot hooks

2022-12-21 Thread Fabian Grünbichler
this is v2, right? ;) On December 12, 2022 2:43 pm, Stefan Hanreich wrote: > This commit adds hooks to the snapshotting process, which can be used > to run additional setup scripts to prepare the VM for snapshotting. > > Examples for use cases include: > * forcing processes to flush their writes

Re: [pve-devel] [PATCH qemu-server v3 3/5] await and kill lingering KVM thread when VM start reaches timeout

2022-12-21 Thread Fabian Grünbichler
On December 16, 2022 2:36 pm, Daniel Tschlatscher wrote: > In some cases the VM API start method would return before the detached > KVM process would have exited. This is especially problematic with HA, > because the HA manager would think the VM started successfully, later > see that it exited and

Re: [pve-devel] [PATCH pve-guest-common 1/1] partially fix #2530: snapshots: add pre/post/failed-snapshot hooks

2022-12-21 Thread Stefan Hanreich
On 12/21/22 11:44, Fabian Grünbichler wrote: this is v2, right? ;) Oh no - for some reason it's only in the cover letter.. On December 12, 2022 2:43 pm, Stefan Hanreich wrote: This commit adds hooks to the snapshotting process, which can be used to run additional setup scripts to prepare

Re: [pve-devel] [PATCH pve-guest-common 1/1] partially fix #2530: snapshots: add pre/post/failed-snapshot hooks

2022-12-21 Thread Fabian Grünbichler
On December 21, 2022 12:26 pm, Stefan Hanreich wrote: > > > On 12/21/22 11:44, Fabian Grünbichler wrote: >> this is v2, right? ;) > > Oh no - for some reason it's only in the cover letter.. > >> >> On December 12, 2022 2:43 pm, Stefan Hanreich wrote: >>> This commit adds hooks to the snapshott

Re: [pve-devel] [PATCH pve-guest-common 1/1] partially fix #2530: snapshots: add pre/post/failed-snapshot hooks

2022-12-21 Thread Stefan Hanreich
On 12/21/22 13:41, Fabian Grünbichler wrote: On December 21, 2022 12:26 pm, Stefan Hanreich wrote: On 12/21/22 11:44, Fabian Grünbichler wrote: this is v2, right? ;) Oh no - for some reason it's only in the cover letter.. On December 12, 2022 2:43 pm, Stefan Hanreich wrote: This commi

[pve-devel] applied-series: Re: [PATCH qemu 1/3] d/rules: enable slirp again

2022-12-21 Thread Thomas Lamprecht
On 20/12/2022 09:19, Fiona Ebner wrote: > Commit d03e1b3 ("update submodule and patches to 7.2.0") argued that > slirp is not explicitly supported in PVE, but that is not true. In > qemu-server, user networking is supported (via CLI/API) when no bridge > is set on a virtual NIC. So slirp needs to s

[pve-devel] [PATCH manager 0/3] Ceph API fixes/updates

2022-12-21 Thread Aaron Lauterer
A few updates on the Ceph related API. Mainly: - fixing outdated indexes - adding/updating descritions and return value definitions This series could collide with a few other Ceph patches that are still outstanding. So I do expect needed rebases here and there. Aaron Lauterer (3): ceph api: fix

[pve-devel] [PATCH manager 1/3] ceph api: fix descriptions

2022-12-21 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index f3442408..0490f4a2 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -114,7 +114,7 @@ __PACKAGE__->register_method ({ per

[pve-devel] [PATCH manager 2/3] api: ceph: update index list

2022-12-21 Thread Aaron Lauterer
some items were missing and placing them in alphabetical order will make it easier in the future Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph.pm | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 0490f4a2..5522032

[pve-devel] [PATCH manager 3/3] api: ceph: update return value definitions

2022-12-21 Thread Aaron Lauterer
to have at either a more accurate description or some description at all. For objects returning a lot of data, for example individual Ceph services, a full description has been omitted as I think that this would be a bit much. Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph.pm | 7 +

[pve-devel] applied-series: [PATCH v2 docs 1/2] qm: IO thread: be more precise about how QEMU handles IO

2022-12-21 Thread Thomas Lamprecht
On 20/12/2022 12:24, Fiona Ebner wrote: > Reported in the community forum[0]. > > The setting can already help with a single disk. Without the option, > there is not one IO thread as the old wording suggested, but IO is > handled in the main event loop or vCPU threads (see the kvm man page). > >

[pve-devel] applied: [PATCH manager 1/3] ceph api: fix descriptions

2022-12-21 Thread Thomas Lamprecht
On 21/12/2022 14:30, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > PVE/API2/Ceph.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists

[pve-devel] applied: [PATCH manager 2/3] api: ceph: update index list

2022-12-21 Thread Thomas Lamprecht
On 21/12/2022 14:30, Aaron Lauterer wrote: > some items were missing and placing them in alphabetical order will make > it easier in the future > > Signed-off-by: Aaron Lauterer > --- > PVE/API2/Ceph.pm | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > applied, a

Re: [pve-devel] [PATCH manager 3/3] api: ceph: update return value definitions

2022-12-21 Thread Thomas Lamprecht
On 21/12/2022 14:30, Aaron Lauterer wrote: > to have at either a more accurate description or some description at > all. For objects returning a lot of data, for example individual Ceph > services, a full description has been omitted as I think that this would > be a bit much. > > Signed-off-by: A

Re: [pve-devel] [PATCH storage] fix #4390: rbd: snapshot delete: avoid early return to fix handling TPM drive

2022-12-21 Thread Fabian Grünbichler
On December 9, 2022 11:30 am, Fiona Ebner wrote: > The only caller where $running can even be truthy is QemuServer.pm's > qemu_volume_snapshot_delete(). But there, a check if snapshots should > be done with QEMU is already made and the storage function is only > called if snapshots should not be do

Re: [pve-devel] [PATCH v2 qemu-server 1/1] Do not start VM twice when rollbacking with --start

2022-12-21 Thread Fabian Grünbichler
On November 21, 2022 2:13 pm, Stefan Hanreich wrote: > When rollbacking to the snapshot of a VM that includes RAM, the VM > gets started by the rollback task anyway, so no additional start task is > needed. Previously, when running rollback with the --start parameter > and the VM snapshot includes

Re: [pve-devel] [PATCH v2 qemu-server 1/1] Do not start VM twice when rollbacking with --start

2022-12-21 Thread Stefan Hanreich
On 12/21/22 16:02, Fabian Grünbichler wrote: On November 21, 2022 2:13 pm, Stefan Hanreich wrote: When rollbacking to the snapshot of a VM that includes RAM, the VM gets started by the rollback task anyway, so no additional start task is needed. Previously, when running rollback with the --sta

[pve-devel] applied: [PATCH V7 manager 0/2] fix #2822: add iscsi, lvm, lvmthin & zfs

2022-12-21 Thread Dominik Csapak
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server v3] rollback: Only create start task with --start if VM is not running

2022-12-21 Thread Stefan Hanreich
When rolling back to the snapshot of a VM that includes RAM, the VM gets started by the rollback task anyway, so no additional start task is needed. Previously, when rolling back with the start parameter and the VM snapshot included RAM, a start task was created. That task failed because the VM had