[pve-devel] [PATCH docs] storage: iscsi direct: update information about packages

2022-12-12 Thread Fiona Ebner
As reported in the community forum [0], libiscsi-bin is required. Also, the library package on Bullseye would be libiscsi7. Just change the mentioned version to a generic number to never be out of date. [0]: https://forum.proxmox.com/threads/119369 Signed-off-by: Fiona Ebner --- pve-storage-isc

Re: [pve-devel] [PATCH docs] storage: iscsi direct: update information about packages

2022-12-12 Thread Thomas Lamprecht
Am 12/12/2022 um 10:12 schrieb Fiona Ebner: > As reported in the community forum [0], libiscsi-bin is required. > Also, the library package on Bullseye would be libiscsi7. Just change > the mentioned version to a generic number to never be out of date. > we already depend on the current .so bump

[pve-devel] [PATCH v2 docs] storage: iscsi direct: update information about packages

2022-12-12 Thread Fiona Ebner
As reported in the community forum [0], libiscsi-bin is required. The library package on Bullseye would be libiscsi7, but there is no real need to mention the package explicitly, because it is a dependency of both, libiscsi-bin and pve-qemu-kvm. [0]: https://forum.proxmox.com/threads/119369 Signe

Re: [pve-devel] [PATCH manager 1/2] api: ceph: deprecate pools in favor or pool

2022-12-12 Thread Aaron Lauterer
I noticed that the commit title needs a s/or/of/ ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server] cfg2cmd: factor out ovmf drives printing

2022-12-12 Thread Thomas Lamprecht
Am 02/12/2022 um 13:59 schrieb Fiona Ebner: > No functional change is intended. > > Signed-off-by: Fiona Ebner > --- > > Popped out while trying the other approach mentioned in: > https://lists.proxmox.com/pipermail/pve-devel/2022-December/055091.html > > Better viewed with > --color-moved=zebr

Re: [pve-devel] [PATCH manager v4 1/3] api ceph osd: add OSD index, metadata and lv-info

2022-12-12 Thread Aaron Lauterer
On 12/9/22 16:28, Alwin Antreich wrote: It would be nice to have this information at `pveceph osd list`. Good point. I'll look into it. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve

[pve-devel] [PATCH manager v5 1/3] api ceph osd: add OSD index, metadata and lv-info

2022-12-12 Thread Aaron Lauterer
To get more details for a single OSD, we add two new endpoints: * nodes/{node}/ceph/osd/{osdid}/metadata * nodes/{node}/ceph/osd/{osdid}/lv-info The {osdid} endpoint itself gets a new GET handler to return the index. The metadata one provides various metadata regarding the OSD. Such as * process

[pve-devel] [PATCH manager v5 0/3] Ceph OSD: add detail infos

2022-12-12 Thread Aaron Lauterer
This patch series adds 2 new API endpoints for OSDs to fetch more detailed information about a single OSD. One for overall information and one for a single volume (block, db, wal). More in the actual patches. Series got [0]: Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak Changes since v

[pve-devel] [PATCH manager v5 2/3] ui utils: add renderer for ceph osd addresses

2022-12-12 Thread Aaron Lauterer
Render the OSD listening addresses a bit nicer and one per line. Signed-off-by: Aaron Lauterer --- changes since v3: - rebased v2: - improve and simplify the first preparation steps - if regex matching fails, show the raw value www/manager6/Utils.js | 15 +++ 1 file changed, 15 ins

[pve-devel] [PATCH manager v5 3/3] ui: osd: add details window

2022-12-12 Thread Aaron Lauterer
This new windows provides more detailes about an OSD such as: * PID * Memory usage * various metadata that could be of interest * list of phyiscal disks used for the main disk, db and wal with additional infos about the volumes for each A new 'Details' button is added to the OSD overview and a d

[pve-devel] [PATCH storage] disk manage: pass full NVMe device path to smartctl

2022-12-12 Thread Fiona Ebner
This essentially reverts commit c9bd3d2 ("fix #1123: modify NVME device path for SMART support"). The man page for smartctl states > Use the forms "/dev/nvme[0-9]" (broadcast namespace) or > "/dev/nvme[0-9]n[1-9]" (specific namespace 1-9) for NVMe devices. so it should be fine to pass the path wi

[pve-devel] [PATCH v2 http-server 2/2] multipart upload: don't require trailing newline

2022-12-12 Thread Matthias Heiserer
RFC 152 mandates that data after the final boundary must be ignored. Some software (e.g. postman) sends their request without a trailing newline, which resulted in failed uploads. Signed-off-by: Matthias Heiserer --- src/PVE/APIServer/AnyEvent.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[pve-devel] [PATCH v2 http-server 1/2] fix multipart upload: ignore additional headers

2022-12-12 Thread Matthias Heiserer
Reported in the forum: https://forum.proxmox.com/threads/image-upload-fails-after-upgrading-from-7-1-to-7-3.119051/#post-516517 When additional headers existed in the request body, the upload failed. With this patch, all additional headers get ignored. Example: The following upload would fail be

[pve-devel] [PATCH pve-docs 1/1] examples: add pre/post/failed-snapshot hooks to example hookscript

2022-12-12 Thread Stefan Hanreich
Added a section for each new snapshot hook to the example hookscript, as well as a short comment explaining when the respective section gets executed. Signed-off-by: Stefan Hanreich --- examples/guest-example-hookscript.pl | 21 + 1 file changed, 21 insertions(+) diff --git

[pve-devel] [PATCH v2 pve-guest-common/pve-docs] Add pre/post/failed-snapshot hooks

2022-12-12 Thread Stefan Hanreich
This patch series introduces the pre/post/failed-snapshot hooks that run before/ after a snapshot is taken, or after failing to take a snapshot. I used the new example script from pve-docs as template for my test hookscripts. What I tested: - Normal snapshotting, without VM state, without hookscr

[pve-devel] [PATCH pve-guest-common 1/1] partially fix #2530: snapshots: add pre/post/failed-snapshot hooks

2022-12-12 Thread Stefan Hanreich
This commit adds hooks to the snapshotting process, which can be used to run additional setup scripts to prepare the VM for snapshotting. Examples for use cases include: * forcing processes to flush their writes * blocking processes from writing * altering the configuration of the VM to make snaps

[pve-devel] [PATCH v3 http-server 1/3] multipart upload: fix upload of files starting with newlines

2022-12-12 Thread Matthias Heiserer
Currently, if a file starts with a newline, it gets removed and the uploda succeeds (provided no hash is given). Signed-off-by: Matthias Heiserer --- src/PVE/APIServer/AnyEvent.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServe

[pve-devel] [PATCH v3 http-server 3/3] multipart upload: don't require trailing newline

2022-12-12 Thread Matthias Heiserer
Allow upload without trailing newline. This is not compliant with RFC 1521. RFC 1521 mandates that the close-delimiter ends in a newline: 'close-delimiter := "--" boundary "--" CRLF' However, some software (e.g. postman) sends their request without a trailing newline, which resulted in failing upl

[pve-devel] [PATCH v3 http-server 2/3] fix multipart upload: ignore additional headers

2022-12-12 Thread Matthias Heiserer
Reported in the forum: https://forum.proxmox.com/threads/image-upload-fails-after-upgrading-from-7-1-to-7-3.119051/#post-516517 When additional headers existed in the request body, the upload failed. With this patch, all additional headers get ignored. Example: The following upload would fail be

Re: [pve-devel] [PATCH v3 http-server 1/3] multipart upload: fix upload of files starting with newlines

2022-12-12 Thread Daniel Tschlatscher
Testing this series in the Browser, with curl and postman, I couldn't find any issues anymore, more details below. Code looks good to me as well. Tested-by: Daniel Tschlatscher Reviewed-by: Daniel Tschlatscher Browser/GUI: ✅ Uploading files with 0B, 1B, 1kB, 17kB, 1MB, 1GB, 10GB ✅ Uploading

Re: [pve-devel] [PATCH manager v4 1/3] api ceph osd: add OSD index, metadata and lv-info

2022-12-12 Thread Aaron Lauterer
On 12/7/22 18:23, Alwin Antreich wrote: December 7, 2022 2:22 PM, "Aaron Lauterer" wrote: On 12/7/22 12:15, Alwin Antreich wrote: Hi, December 6, 2022 4:47 PM, "Aaron Lauterer" wrote: To get more details for a single OSD, we add two new endpoints: * nodes/{node}/ceph/osd/{osdid}/met