[pve-devel] [PATCH storage] fix #4390: rbd: snapshot delete: avoid early return to fix handling TPM drive

2022-12-09 Thread Fiona Ebner
The only caller where $running can even be truthy is QemuServer.pm's qemu_volume_snapshot_delete(). But there, a check if snapshots should be done with QEMU is already made and the storage function is only called if snapshots should not be done with QEMU (like for TPM drives which are not attached

[pve-devel] [PATCH manager 2/2] ui: ceph: adapt urls to new ceph/pool endpoint

2022-12-09 Thread Aaron Lauterer
ceph/pools (plural) is deprecated, use the new one. Since the details / status of a pool has been moved from previously ceph/pools/{name} to now ceph/pool/{name}/status, we need to pass the 'loadUrl' to the edit window. Signed-off-by: Aaron Lauterer --- www/manager6/ceph/Pool.js | 9

[pve-devel] [PATCH manager 1/2] api: ceph: deprecate pools in favor or pool

2022-12-09 Thread Aaron Lauterer
/nodes/{node}/ceph/pools/{pool} returns the pool details right away on a GET. This makes it bad practice to add additional sub API endpoints. By deprecating it and replacing it with /nodes/{node}/ceph/pool/{pool} (singular instead of plural) we can turn that into an index GET response, making it

Re: [pve-devel] [PATCH manager v4 1/3] api ceph osd: add OSD index, metadata and lv-info

2022-12-09 Thread Aaron Lauterer
On 12/7/22 18:23, Alwin Antreich wrote: December 7, 2022 2:22 PM, "Aaron Lauterer" wrote: On 12/7/22 12:15, Alwin Antreich wrote: [...] 'ceph-volume' is used to gather the infos, except for the creation time of the LV which is retrieved via 'lvs'. You could use lvs/vgs directly, the ce

[pve-devel] [PATCH qemu-server v3] QEMU AMD SEV enable

2022-12-09 Thread Markus Frank
This Patch is for enabling AMD SEV (Secure Encrypted Virtualization) support in QEMU VM-Config-Examples: amd_sev: type=std,nodbg=1,noks=1 amd_sev: es,nodbg=1,kernel-hashes=1 Node-Config-Example (gets generated automatically): amd_sev: cbitpos=47,reduced-phys-bios=1 kernel-hashes, reduced-phys-bi

[pve-devel] [PATCH docs v3] added Memory Encryption documentation

2022-12-09 Thread Markus Frank
added AMD SEV documentation for "[PATCH qemu-server] QEMU AMD SEV enable" Signed-off-by: Markus Frank --- v3: * added more information * removed some grammar errors v2: * added more details for host & guests * moved things from Limitations to Requirements * changed order of text qm.adoc | 118

Re: [pve-devel] [PATCH manager v4 1/3] api ceph osd: add OSD index, metadata and lv-info

2022-12-09 Thread Alwin Antreich via pve-devel
--- Begin Message --- December 9, 2022 3:05 PM, "Aaron Lauterer" wrote: > On 12/7/22 18:23, Alwin Antreich wrote: > >> December 7, 2022 2:22 PM, "Aaron Lauterer" wrote: >> On 12/7/22 12:15, Alwin Antreich wrote: >>> > > [...] > >>> 'ceph-volume' is used to gather the infos, except for the cr

[pve-devel] [PATCH qemu-server 03/10] config: memory: add 'max' option

2022-12-09 Thread Alexandre Derumier
max can be multiple of 64GB only. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index ad69b76..0d5b550 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -267,6 +2

[pve-devel] [PATCH qemu-server 02/10] add memory parser

2022-12-09 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 12 - PVE/QemuConfig.pm | 4 +-- PVE/QemuMigrate.pm| 6 +++-- PVE/QemuServer.pm | 56 ++- PVE/QemuServer/Helpers.pm | 3 +-- PVE/QemuServer/Memory.pm | 35

[pve-devel] [PATCH qemu-server 06/10] memory: use 64 slots && static dimm size with max is defined

2022-12-09 Thread Alexandre Derumier
default kernel vhost config only support 64 slots by default, for performance since 2015. Original memory hotplug code was done before, using qemu max supported 255 slots. To reach max mem (4TB), we used incremental dimm size. Instead of dynamic memory size, use 1 static dimm size, compute from

[pve-devel] [PATCH qemu-server 09/10] tests: add virtio-mem tests

2022-12-09 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/cfg2cmd/memory-virtio-hugepages-1G.conf | 11 ++ .../memory-virtio-hugepages-1G.conf.cmd | 35 +++ test/cfg2cmd/memory-virtio-max.conf | 10 ++ test/cfg2cmd/memory-virtio-max.conf.cmd | 35 ++

[pve-devel] [PATCH qemu-server 07/10] test: add memory-max tests

2022-12-09 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/cfg2cmd/memory-max-128G.conf | 10 test/cfg2cmd/memory-max-128G.conf.cmd | 86 +++ test/cfg2cmd/memory-max-512G.conf | 10 test/cfg2cmd/memory-max-512G.conf.cmd | 58 ++ 4 files changed, 164 inser

[pve-devel] [PATCH qemu-server 00/10] rework memory hotplug + virtiomem

2022-12-09 Thread Alexandre Derumier
This patch series rework the current memory hotplug + virtiomem. memory option now have extra options: memory: [[current=]] [,max=] [,virtio=<1|0>] ex: memory: current=1024,max=131072,virtio=1 patches 1-2: add a memory parser patches 3-7: add the max option with 64 static dimm hotplug for cla

[pve-devel] [PATCH qemu-server 04/10] memory: add get_static_mem

2022-12-09 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer/Memory.pm | 50 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm index 668508b..90e355b 100644 --- a/PVE/QemuServer/Memory.pm +++ b/PVE/

[pve-devel] [PATCH qemu-server 01/10] test: add memory tests

2022-12-09 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/cfg2cmd/memory-hotplug-hugepages.conf| 12 ++ .../cfg2cmd/memory-hotplug-hugepages.conf.cmd | 62 +++ test/cfg2cmd/memory-hotplug.conf | 11 ++ test/cfg2cmd/memory-hotplug.conf.cmd | 174 ++ test/cfg2cmd/m

[pve-devel] [PATCH qemu-server 10/10] memory: fix hotplug with virtiomem && maxmem

2022-12-09 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm| 9 - PVE/QemuServer/Memory.pm | 23 --- 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 43fab29..549e448 100644 --- a/PVE/QemuServer.pm +++ b/

[pve-devel] [PATCH qemu-server 05/10] memory: get_max_mem: use config memory max

2022-12-09 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer/Memory.pm | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm index 90e355b..b847742 100644 --- a/PVE/QemuServer/Memory.pm +++ b/PVE/QemuServer/Memory.pm @@ -91,7 +91

[pve-devel] [PATCH qemu-server 08/10] memory: add virtio-mem support

2022-12-09 Thread Alexandre Derumier
a 4GB static memory is needed for DMA+boot memory, as this memory is almost always un-unpluggeable. 1 virtio-mem pci device is setup for each numa node on pci.4 bridge virtio-mem use a fixed blocksize with 32000 blocks Blocksize is computed from the maxmemory-4096/32000 with a minimum of 2MB to m