Re: [pve-devel] [PATCH storage 1/2] zfs: only use cache when listing images locally

2022-11-29 Thread Fabian Grünbichler
On November 28, 2022 1:19 pm, Fiona Ebner wrote: > Am 16.11.22 um 14:30 schrieb Fiona Ebner: >> Am 16.11.22 um 12:18 schrieb Fabian Grünbichler: >>> On November 7, 2022 12:00 pm, Fiona Ebner wrote: The plugin for remote ZFS storages currently also uses the same list_images() as the plugin

[pve-devel] [PATCH qemu-server] fix #4372: fix vm_resume migration callback

2022-11-29 Thread Fabian Grünbichler
the fix for the recently introduced requirement of loading the VM config while migrating was incomplete, since the vmlist node value could already be out of date by the time load_config is called. extend the fallback behaviour even further, by doing the following sequence: - try regular load_confi

[pve-devel] [PATCH i18n 2/2] minor improves to the spanish translation

2022-11-29 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- just fixed some low-hanging fruits. this could use a lot more love, but i doubt i'll manage everything with my limited spanish skills. es.po | 68 +++ 1 file changed, 31 insertions(+), 37 deletions(-) diff

[pve-devel] [PATCH i18n 1/2] update german translation

2022-11-29 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- de.po | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/de.po b/de.po index dc08a87..2b39b4b 100644 --- a/de.po +++ b/de.po @@ -7,8 +7,8 @@ msgid "" msgstr "" "Project-Id-Version: proxmox translations\n" "Repor

[pve-devel] [PATCH container v2 2/2] restore: also remove firewall config after failed restore

2022-11-29 Thread Daniel Tschlatscher
Before, a failed restore would only remove the container config, but the firewall config would remain. Now, the firewall config is also removed, except for the case when the user only has the VM.Backup permission. In this case the firewall would not have been restored/changed by us and is left as i

[pve-devel] [PATCH container v2 1/2] restore: clean up config when invalid source archive is given

2022-11-29 Thread Daniel Tschlatscher
Before, if a non-existent source archive parameter was passed when restoring a container, the task would fail but leave an empty config file behind. The same with invalid mount point configurations. In both cases, the empty config will now be removed. Signed-off-by: Daniel Tschlatscher --- Change

[pve-devel] [PATCH V2 firewall 0/2] allow non zero ip address host bits to be entered

2022-11-29 Thread Stefan Hrdlicka
V1 -> V2 * zero out host bits instead of ignoring error * regex "cleanup" Stefan Hrdlicka (2): allow non zero ip address host bits to be entered cleanup: don't capture "/xx" of CIDR src/PVE/API2/Firewall/IPSet.pm | 2 +- src/PVE/Firewall.pm| 31 +-- 2

[pve-devel] [PATCH V2 firewall 1/2] allow non zero ip address host bits to be entered

2022-11-29 Thread Stefan Hrdlicka
They can already be set directly via the cluster.fw file. Net::IP is just a bit more picky with what it allows: For example: error: 192.168.1.155/24 correct: 192.168.1.0/24 This cleans the entered IP and removes the non zero host bits. Signed-off-by: Stefan Hrdlicka --- src/PVE/API2/Firew

[pve-devel] [PATCH V2 firewall 2/2] cleanup: don't capture "/xx" of CIDR

2022-11-29 Thread Stefan Hrdlicka
Signed-off-by: Stefan Hrdlicka --- src/PVE/Firewall.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 3c35b44..73e940b 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -68,7 +68,7 @@ PVE::JSONSchema::register_format

Re: [pve-devel] [PATCH qemu-server] fix #4372: fix vm_resume migration callback

2022-11-29 Thread Fabian Grünbichler
> Fabian Grünbichler hat am 29.11.2022 13:09 CET > geschrieben: > > > the fix for the recently introduced requirement of loading the VM config while > migrating was incomplete, since the vmlist node value could already be out of > date by the time load_config is called. > > extend the fallbac