[pve-devel] [PATCH i18n] Arabic translation update

2022-11-21 Thread Moayad Almalat
Signed-off-by: Moayad Almalat --- ar.po | 865 +++--- 1 file changed, 337 insertions(+), 528 deletions(-) diff --git a/ar.po b/ar.po index f29e58f..acf4fa3 100644 --- a/ar.po +++ b/ar.po @@ -11,7 +11,7 @@ msgstr "" "Project-Id-Version: pve-man

[pve-devel] applied: [PATCH i18n] Arabic translation update

2022-11-21 Thread Thomas Lamprecht
Am 18/11/2022 um 11:30 schrieb Moayad Almalat: > Signed-off-by: Moayad Almalat > --- > ar.po | 865 +++--- > 1 file changed, 337 insertions(+), 528 deletions(-) > > applied, thanks! ___ pve-devel m

Re: [pve-devel] pve-manager/www: API for external plugins?

2022-11-21 Thread Roland Kammerer
Hi Thomas, sorry for the long delay, and thanks for the pointers. In general we would be willing to work on that if it does not take us too much effort. We currently try to figure that out. A colleague of mine told me that the js part should not be the problem, what I am not sure about is this par

[pve-devel] [PATCH docs 2/2] ha: crs: clarify that non-HA-managed services are currently not counted

2022-11-21 Thread Fiona Ebner
Without explicitly stating this, it's rather easily missed. Reported-by: Dominik Csapak Signed-off-by: Fiona Ebner --- As Thomas said off-list, it's better to start tracking this information in HA manager too. For now, clarify the status-quo. ha-manager.adoc | 3 ++- 1 file changed, 2 inserti

[pve-devel] [PATCH docs 1/2] ha: crs: fix typo

2022-11-21 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- ha-manager.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ha-manager.adoc b/ha-manager.adoc index e69db1a..2da6a99 100644 --- a/ha-manager.adoc +++ b/ha-manager.adoc @@ -958,14 +958,14 @@ the future. Basic ~ -The number of activ

[pve-devel] [PATCH i18n] update german translation

2022-11-21 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- de.po | 185 +++--- 1 file changed, 72 insertions(+), 113 deletions(-) diff --git a/de.po b/de.po index ea6f50b..efd14c3 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: proxmox tran

[pve-devel] [PATCH pve-network] network: add|del_fdb: fix learning check

2022-11-21 Thread Alexandre Derumier
ovs port don't have sysfs path "/sys/class/net/$iface/brport/learning" We need to check if the value is undef too Signed-off-by: Alexandre Derumier --- src/PVE/Network.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm index 26d8cb

Re: [pve-devel] [PATCH i18n] update german translation

2022-11-21 Thread Daniel Tschlatscher
Looks good, 1 suggestions, 2 NITs inline: On 11/21/22 10:49, Stefan Sterz wrote: > Signed-off-by: Stefan Sterz > --- > de.po | 185 +++--- > 1 file changed, 72 insertions(+), 113 deletions(-) > > diff --git a/de.po b/de.po > index ea6f50b..efd

[pve-devel] [PATCH manager] ui: fix minor typo in tag style gui

2022-11-21 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- www/manager6/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index df2f9631..4dd3cb93 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1923,7 +1923,7 @@ Ext.define('PVE.Uti

[pve-devel] applied: [PATCH i18n] update german translation

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 10:49 schrieb Stefan Sterz: > Signed-off-by: Stefan Sterz > --- > de.po | 185 +++--- > 1 file changed, 72 insertions(+), 113 deletions(-) > > applied, thanks! (sending a follow up for Daniel's comments may be simpler here th

Re: [pve-devel] [PATCH manager] ui: fix minor typo in tag style gui

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 11:10 schrieb Stefan Sterz: > Signed-off-by: Stefan Sterz > --- > www/manager6/Utils.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js > index df2f9631..4dd3cb93 100644 > --- a/www/manager6/Utils.js > +++ b/

[pve-devel] applied: [PATCH pve-network] network: add|del_fdb: fix learning check

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 10:54 schrieb Alexandre Derumier: > ovs port don't have sysfs path > "/sys/class/net/$iface/brport/learning" > > We need to check if the value is undef too > > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(

[pve-devel] [PATCH i18n] update german translation

2022-11-21 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- thanks @ Daniel Tschlatscher and Dominik Csapak for the corrections! de.po | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/de.po b/de.po index c7b21a3..c5ab411 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr

[pve-devel] applied: [PATCH i18n] update german translation

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 11:57 schrieb Stefan Sterz: > Signed-off-by: Stefan Sterz > --- > thanks @ Daniel Tschlatscher and Dominik Csapak for the corrections! > > de.po | 28 > 1 file changed, 12 insertions(+), 16 deletions(-) > > applied, thanks! __

[pve-devel] applied: [PATCH docs 1/2] ha: crs: fix typo

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 09:31 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > ha-manager.adoc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied both patches, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com htt

[pve-devel] applied: [PATCH widget-toolkit 1/2] css: don't make full tags inline-block in the tree

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 08:53 schrieb Dominik Csapak: > when showing full tags in the tree as inline-block, the height is increased, > leading to unwanted 'wobble' when tags are added/removed > > Signed-off-by: Dominik Csapak > --- > src/css/ext6-pmx.css | 5 + > 1 file changed, 5 insertions(+) >

[pve-devel] [PATCH qemu-server 1/2] vm_resume: fix nocheck/migrate handling

2022-11-21 Thread Fabian Grünbichler
it's not deterministic whether the rename/move of the VM config triggered on the source side of a migration is already visible on the target side when vm_resume is executed. check the vmlist for the node where the config is currently located if $nocheck is set - it is now needed to add the forwardi

[pve-devel] [PATCH qemu-server 2/2] explain 'nocheck' in more places

2022-11-21 Thread Fabian Grünbichler
was only explained in git history and vm_stop, add comments in other relevant places to avoid future breakage. Signed-off-by: Fabian Grünbichler --- PVE/API2/Qemu.pm | 2 ++ PVE/CLI/qm.pm | 2 ++ PVE/QemuMigrate.pm | 3 ++- PVE/QemuServer.pm | 9 + 4 files changed, 15 insertions(

[pve-devel] [PATCH qemu-server 1/1] Do not start VM twice when rollbacking with --start

2022-11-21 Thread Stefan Hanreich
When rollbacking to the snapshot of a VM that includes RAM, the VM gets started by the rollback task anyway, so no additional start task is needed. Previously, when running rollback with the --start parameter and the VM snapshot includes RAM, a start task was created. That task failed because the V

Re: [pve-devel] [PATCH qemu-server 1/1] Do not start VM twice when rollbacking with --start

2022-11-21 Thread Fabian Grünbichler
On November 21, 2022 1:29 pm, Stefan Hanreich wrote: > When rollbacking to the snapshot of a VM that includes RAM, the VM > gets started by the rollback task anyway, so no additional start task is > needed. Previously, when running rollback with the --start parameter > and the VM snapshot includes

Re: [pve-devel] [PATCH qemu-server 1/1] Do not start VM twice when rollbacking with --start

2022-11-21 Thread Stefan Hanreich
On 11/21/22 13:44, Fabian Grünbichler wrote: On November 21, 2022 1:29 pm, Stefan Hanreich wrote: When rollbacking to the snapshot of a VM that includes RAM, the VM gets started by the rollback task anyway, so no additional start task is needed. Previously, when running rollback with the --star

[pve-devel] applied: [PATCH qemu-server 1/2] vm_resume: fix nocheck/migrate handling

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 13:16 schrieb Fabian Grünbichler: > it's not deterministic whether the rename/move of the VM config > triggered on the source side of a migration is already visible on the > target side when vm_resume is executed. check the vmlist for the node > where the config is currently locate

[pve-devel] [PATCH v2 qemu-server 1/1] Do not start VM twice when rollbacking with --start

2022-11-21 Thread Stefan Hanreich
When rollbacking to the snapshot of a VM that includes RAM, the VM gets started by the rollback task anyway, so no additional start task is needed. Previously, when running rollback with the --start parameter and the VM snapshot includes RAM, a start task was created. That task failed because the V

[pve-devel] [PATCH manager] ui: qemu disk: honor iothread setting from config

2022-11-21 Thread Dominik Csapak
to have a iothread on by default in the wizard and on disk add, we added a 'bind' for the value here. This also changes the value for existing vm disks, and if one does not notice, modifies it away again (since we don't have the controller here and isSCSISingle is false) simply don't bind value wh

[pve-devel] applied: [PATCH manager] ui: qemu disk: honor iothread setting from config

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 15:39 schrieb Dominik Csapak: > to have a iothread on by default in the wizard and on disk add, we > added a 'bind' for the value here. This also changes the value > for existing vm disks, and if one does not notice, modifies it > away again (since we don't have the controller here

[pve-devel] applied: [PATCH manager 1/6] api: vzdump: soften parameter permission checks

2022-11-21 Thread Thomas Lamprecht
Am 16/11/2022 um 15:04 schrieb Fiona Ebner: > Allows sufficiently privileged users to pass-in retention and > performance parameters for manual backup, but keeps tmpdir, dumpdir > and script root-only. Such users could already edit the job > accordingly, so essentially not granting anything new. >