[pve-devel] [PATCH manager] ui: fix datacenter tags options inputs

* dont allow blank for tree shape * allow completely removing registered tags and user-tag-access properties * correctly check validity for the listfield * use correct gettexts * don't inject empty field in the listfield when setting an empty string Signed-off-by: Dominik Csapak --- www/manager6

Re: [pve-devel] [PATCH pve-guest-common 1/1] add pre/post-snapshot hooks

Am 17.11.22 um 12:27 schrieb Stefan Hanreich:> On 11/14/22 09:51, Fiona Ebner wrote: >> Am 22.09.22 um 13:54 schrieb Stefan Hanreich: >>> Signed-off-by: Stefan Hanreich >>> --- >>> >> >> Should there be a third hook that's called when the snapshot fails? That >> would allow doing cleanup in all ca

[pve-devel] [PATCH container] enable systemd-networkd per preset in fedora 37+

While the template has systemd-networkd enabled, the lack of /etc/machine-id causes systemd to revert to its "preset", where now in /usr/lib/systemd/system-preset/90-default.preset fedora disables systemd-networkd in favor of NetworkManager. Without this patch, the first boot of a fresh fedora 3

Re: [pve-devel] [PATCH v2 http-server 0/2] fix #4344: ignore unused multipart headers

Reviewed-by: Matthias Heiserer On 18.11.2022 02:39, John Hollowell wrote: This fixes an issue where an upload request without a Content-Type in the file's multipart part would prevent the upload and throw missleading errors. This patch removes the requirement and ignores all multipart headers o

[pve-devel] applied: [PATCH docs 1/2] pcie-passthrough: note that iommu activation is not always necessary

Am 20/05/2022 um 10:43 schrieb Dominik Csapak: > especially on newer kernels > > Signed-off-by: Dominik Csapak > --- > qm-pci-passthrough.adoc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied both patches with dropping the `iommu.passthrough=1` part in a follow up as its

[pve-devel] [PATCH manager] NetworkEdit: Use default model

Patch eb1a09647d25d6d588260a971187a8803453a9ed broke the preselected Model by setting it to ''. The GUI displays/selects an empty field as default. Signed-off-by: Matthias Heiserer --- www/manager6/qemu/NetworkEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manage

[pve-devel] [PATCH docs 3/9] network: fix typo

Signed-off-by: Matthias Heiserer --- pve-network.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-network.adoc b/pve-network.adoc index 85779b6..ed96d8e 100644 --- a/pve-network.adoc +++ b/pve-network.adoc @@ -25,7 +25,7 @@ xref:sysadmin_network_masquerading['NAT'] set

[pve-devel] [PATCH docs 1/9] bibliography: update 404 link

Signed-off-by: Matthias Heiserer --- pve-bibliography.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-bibliography.adoc b/pve-bibliography.adoc index 168c94e..f8064fc 100644 --- a/pve-bibliography.adoc +++ b/pve-bibliography.adoc @@ -37,7 +37,7 @@ endif::manvolnum[]

[pve-devel] [PATCH docs 2/9] package-repos: fix typos

Signed-off-by: Matthias Heiserer --- pve-package-repos.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc index 3237ddf..52169a0 100644 --- a/pve-package-repos.adoc +++ b/pve-package-repos.adoc @@ -108,7 +108,7 @@ deb http:

[pve-devel] [PATCH docs 8/9] local-zfs: typo fix/better phrasing

Signed-off-by: Matthias Heiserer --- local-zfs.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index 0fa06b0..34eb06b 100644 --- a/local-zfs.adoc +++ b/local-zfs.adoc @@ -235,7 +235,7 @@ There are a few options to counter the increase

[pve-devel] [PATCH docs 4/9] network: fix dead link

Signed-off-by: Matthias Heiserer --- pve-network.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-network.adoc b/pve-network.adoc index ed96d8e..0e94f28 100644 --- a/pve-network.adoc +++ b/pve-network.adoc @@ -267,7 +267,7 @@ https://commons.wikimedia.org/wiki/File:Ne

[pve-devel] [PATCH docs 5/9] local-lvm: typo fix/better phrasing

Signed-off-by: Matthias Heiserer --- local-lvm.adoc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/local-lvm.adoc b/local-lvm.adoc index 6abdee8..8092bb8 100644 --- a/local-lvm.adoc +++ b/local-lvm.adoc @@ -7,7 +7,7 @@ endif::wiki[] Most people install {pve} directly

[pve-devel] [PATCH docs 9/9] Update ExtJS version

Signed-off-by: Matthias Heiserer --- pve-gui.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-gui.adoc b/pve-gui.adoc index 3fee2e0..eec6feb 100644 --- a/pve-gui.adoc +++ b/pve-gui.adoc @@ -47,7 +47,7 @@ Features * Two-Factor Authentication (OATH, Yubikey) -* Base

[pve-devel] [PATCH docs 7/9] local-zfs: rephrase ZFS RAID description

I tried to make the performance impact clearer, as what "behave like a number of disks" actually means wasn't quite clear to me. Use "in regard to" rather than "in regard of", as I couldn't find any source that this phrase is (commonly) used in modern english. Signed-off-by: Matthias Heiserer -

[pve-devel] [PATCH docs 6/9] local-zfs Remove SSD suggestion as it's outdated

Signed-off-by: Matthias Heiserer --- local-zfs.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index d3db1c5..6afc110 100644 --- a/local-zfs.adoc +++ b/local-zfs.adoc @@ -60,7 +60,7 @@ practice, use as much as you can get for your hardware

[pve-devel] [PATCH docs] gui: document tags with screenshots

and list some examples Signed-off-by: Dominik Csapak --- was a bit restricted by the space for screenshots, so i only really could add three here. when i added more i couldn't get the spacing right. also needs the screenshots applied to the repo to be buildable @thomas will do that pve-gui.ado

[pve-devel] [RFC ha-manager 2/3] env: add get_static_guest_stats method

which uses the efficient PVE::Cluster::get_guest_config_properties() to retrieve the information and supports caching, so the information can be passed around avoiding overhead from load_config(). Signed-off-by: Fiona Ebner --- src/PVE/HA/Env.pm | 6 ++ src/PVE/HA/Env/PVE2.pm | 15

[pve-devel] [RFC ha-manager] make static usage calculation faster

by avoiding overhead from load_config(). Benchmarked recompute_online_node_usage() again with ~300 HA services (minimal containers) running on my virtual test cluster. Timings with 'basic' were between 0.0004 - 0.002 seconds (a bit worse today than last time) Timings before these patches were bet

[pve-devel] [RFC ha-manager 1/3] resources: get static stats: add cache parameter

so callers can avoid the overhead from load_config() if they already have the required information. Signed-off-by: Fiona Ebner --- src/PVE/HA/Resources.pm | 2 +- src/PVE/HA/Resources/PVECT.pm | 4 ++-- src/PVE/HA/Resources/PVEVM.pm | 5 +++-- src/PVE/HA/Sim/Resources.pm | 2 +- 4 files

[pve-devel] [RFC ha-manager 3/3] manager/usage: cache static service stats to avoid overhead

Benchmarked recompute_online_node_usage() again with ~300 HA services (minimal containers) running on my virtual test cluster. Timings before this patch were between 0.007 - 0.016 seconds Timings after this patch were between 0.0035 - 0.006 seconds So only about twice as fast unfortunately. Reduc

[pve-devel] [PATCH docs] qm: add documentation for vm network MTU setting

Signed-off-by: Daniel Tschlatscher --- qm.adoc | 5 + 1 file changed, 5 insertions(+) diff --git a/qm.adoc b/qm.adoc index e7d0c07..428d388 100644 --- a/qm.adoc +++ b/qm.adoc @@ -636,6 +636,11 @@ but not via the WebUI. You can also skip adding a network device when creating a VM by selectin

[pve-devel] applied: [PATCH manager] NetworkEdit: Use default model

Am 18/11/2022 um 11:29 schrieb Matthias Heiserer: > Patch eb1a09647d25d6d588260a971187a8803453a9ed broke the preselected > Model by setting it to ''. The GUI displays/selects an empty field > as default. > > Signed-off-by: Matthias Heiserer > --- > www/manager6/qemu/NetworkEdit.js | 2 +- > 1 fi

[pve-devel] applied: [PATCH container] enable systemd-networkd per preset in fedora 37+

Am 18/11/2022 um 10:36 schrieb Wolfgang Bumiller: > While the template has systemd-networkd enabled, the lack of > /etc/machine-id causes systemd to revert to its "preset", > where now in > /usr/lib/systemd/system-preset/90-default.preset > fedora disables systemd-networkd in favor of NetworkMana

[pve-devel] [PATCH manager 1/4] ui: hide 'no tags' field and edit icon without VM.Config.Options

they cannot edit them anyway, so no point in showing them that there is no tag Signed-off-by: Dominik Csapak --- www/manager6/form/TagEdit.js | 12 ++-- www/manager6/lxc/Config.js | 1 + www/manager6/qemu/Config.js | 1 + 3 files changed, 12 insertions(+), 2 deletions(-) diff --git

[pve-devel] [PATCH manager 4/4] ui: tags: highlight finish inline editing button

by making it a 'regular' blue button instead of a toolbar button Signed-off-by: Dominik Csapak --- www/manager6/form/TagEdit.js | 1 - 1 file changed, 1 deletion(-) diff --git a/www/manager6/form/TagEdit.js b/www/manager6/form/TagEdit.js index fc2eba99b..e1cd4af67 100644 --- a/www/manager6/form

[pve-devel] [PATCH manager 2/4] ui: tags: shortcut accept&cancel with keypresses

pressing 'Enter' accepts the current tags and 'Escape' cancels editing Signed-off-by: Dominik Csapak --- www/manager6/form/Tag.js | 3 ++- www/manager6/form/TagEdit.js | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/www/manager6/form/Tag.js b/www/manager6/form/Tag.

[pve-devel] [PATCH manager 3/4] ui: tags: implement dirty tracking for inline editing

similar to how regular forms are tracked Signed-off-by: Dominik Csapak --- www/manager6/form/TagEdit.js | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/www/manager6/form/TagEdit.js b/www/manager6/form/TagEdit.js index 18d8927d7..fc2eba99b 100644 --- a/www/mana

Re: [pve-devel] [PATCH docs 1/9] bibliography: update 404 link

Am 18/11/2022 um 12:09 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > pve-bibliography.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pve-bibliography.adoc b/pve-bibliography.adoc > index 168c94e..f8064fc 100644 > --- a/pve-bibliography.adoc

[pve-devel] applied-series: [PATCH docs 1/9] bibliography: update 404 link

Am 18/11/2022 um 12:09 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > pve-bibliography.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied series, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox

[pve-devel] applied: [PATCH manager] ui: fix datacenter tags options inputs

Am 18/11/2022 um 09:09 schrieb Dominik Csapak: > * dont allow blank for tree shape > * allow completely removing registered tags and user-tag-access properties > * correctly check validity for the listfield > * use correct gettexts > * don't inject empty field in the listfield when setting an empty

[pve-devel] applied: [PATCH docs] qm: add documentation for vm network MTU setting

Am 18/11/2022 um 12:46 schrieb Daniel Tschlatscher: > Signed-off-by: Daniel Tschlatscher > --- > qm.adoc | 5 + > 1 file changed, 5 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.c

[pve-devel] [PATCH v3 qemu-server 2/2] tests: add virtio-mem tests

Signed-off-by: Alexandre Derumier --- test/cfg2cmd/simple-virtio-mem-big.conf | 12 + test/cfg2cmd/simple-virtio-mem-big.conf.cmd | 59 + test/cfg2cmd/simple-virtio-mem.conf | 13 + test/cfg2cmd/simple-virtio-mem.conf.cmd | 31 +++ 4 files chang

[pve-devel] [PATCH v3 qemu-server 0/2] add virtio-mem support

This patch add virtio-mem support, through a new maxmemory option. a 4GB static memory is needed for DMA+boot memory, as this memory is almost always un-unpluggeable. 1 virtio-mem pci device is setup for each numa node on pci.4 bridge virtio-mem use a fixed blocksize with 32k max blocksize, so b

[pve-devel] [PATCH v3 qemu-server 1/2] add virtio-mem support

This patch add virtio-mem support, through a new maxmemory option. a 4GB static memory is needed for DMA+boot memory, as this memory is almost always un-unpluggeable. 1 virtio-mem pci device is setup for each numa node on pci.4 bridge virtio-mem use a fixed blocksize with 32k max blocksize, so b

Re: [pve-devel] [PATCH v2 ha-manager 15/15] resources: add missing PVE::Cluster use statements

Am 18/11/2022 um 08:48 schrieb Fiona Ebner: >> +use PVE::Cluster; >> + >> use PVE::HA::Tools; >> >> BEGIN { > Might be better added to the BEGIN block here, and not pull it in for > doc generation in the spirit of a1c8862 ("buildsys: don't pull qemu/lxc > during doc-generation") > Not relevan

[pve-devel] applied-series: [PATCH-SERIES v2 ha-manager/docs] add static usage scheduler for HA manager

Am 17/11/2022 um 15:00 schrieb Fiona Ebner: > ha-manager: > > Fiona Ebner (15): > env: add get_static_node_stats() method > resources: add get_static_stats() method > add Usage base plugin and Usage::Basic plugin > manager: select service node: add $sid to parameters > manager: online no

[pve-devel] [PATCH pve-cluster] datacenter config: remove typo in "user-tag-access" description

Signed-off-by: Stefan Sterz --- data/PVE/DataCenterConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/DataCenterConfig.pm index 5a70722..4186195 100644 --- a/data/PVE/DataCenterConfig.pm +++ b/data/PVE/DataCenterConfig.pm @@ -185,

[pve-devel] applied: [PATCH docs] gui: document tags with screenshots

Am 18/11/2022 um 12:29 schrieb Dominik Csapak: > and list some examples > > Signed-off-by: Dominik Csapak > --- > was a bit restricted by the space for screenshots, so i only really > could add three here. when i added more i couldn't get the spacing > right. > > also needs the screenshots appli

Re: [pve-devel] [PATCH pve-cluster] datacenter config: remove typo in "user-tag-access" description

Am 18/11/2022 um 15:54 schrieb Stefan Sterz: > - ."'list' tasg from 'user-allow'list' are usable. " > + ."'list' tags from 'user-allow'list' are usable. " there's also ' instead of - in user-allow-list ___ pve-devel mailing list pve-dev

[pve-devel] [PATCH pve-cluster v2] datacenter config: remove typos in "user-tag-access" description

Signed-off-by: Stefan Sterz --- data/PVE/DataCenterConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/DataCenterConfig.pm index 5a70722..925670d 100644 --- a/data/PVE/DataCenterConfig.pm +++ b/data/PVE/DataCenterConfig.pm @@ -185,

[pve-devel] applied: [PATCH pve-cluster v2] datacenter config: remove typos in "user-tag-access" description

Am 18/11/2022 um 16:28 schrieb Stefan Sterz: > Signed-off-by: Stefan Sterz > --- > data/PVE/DataCenterConfig.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https

[pve-devel] applied-series: [PATCH manager 1/4] ui: hide 'no tags' field and edit icon without VM.Config.Options

Am 18/11/2022 um 12:59 schrieb Dominik Csapak: > they cannot edit them anyway, so no point in showing them that > there is no tag > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/TagEdit.js | 12 ++-- > www/manager6/lxc/Config.js | 1 + > www/manager6/qemu/Config.js | 1 +