Re: [pve-devel] [PATCH v2 qemu] init: daemonize: defuse PID file resolve error to warning

2022-10-28 Thread Thomas Lamprecht
On 27/10/2022 10:13, Fiona Ebner wrote: > When proxmox-file-restore invokes QEMU, the PID file is a (temporary) > file that's already unlinked, so resolving the absolute path here > failed. > > It should not be a critical error when the PID file unlink handler > can't be registered, because the pa

[pve-devel] [PATCH v3 qemu] init: daemonize: defuse PID file resolve error

2022-10-28 Thread Fiona Ebner
When proxmox-file-restore invokes QEMU, the PID file is a (temporary) file that's already unlinked, so resolving the absolute path here failed. It should not be a critical error when the PID file unlink handler can't be registered, because the path can't be resolved for whatever reason. If the fil

[pve-devel] applied: [PATCH v2 qemu-server] fix #4099: disable io_uring for virtual disks on CIFS storages

2022-10-28 Thread Thomas Lamprecht
On 27/10/2022 09:13, Fiona Ebner wrote: > Since kernel 5.15, there is an issue with io_uring when used in > combination with CIFS [0]. Unfortunately, the kernel developers did > not suggest any way to resolve the issue and didn't comment on my > proposed one. So for now, just disable io_uring when

Re: [pve-devel] [PATCH v3 manager 1/3 follow-up] api ceph osd: add OSD index, metadata and lv-info

2022-10-28 Thread Dominik Csapak
with this follow up, consider this series Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH v3 qemu] init: daemonize: defuse PID file resolve error

2022-10-28 Thread Thomas Lamprecht
On 28/10/2022 10:09, Fiona Ebner wrote: > When proxmox-file-restore invokes QEMU, the PID file is a (temporary) > file that's already unlinked, so resolving the absolute path here > failed. > > It should not be a critical error when the PID file unlink handler > can't be registered, because the pa

Re: [pve-devel] [PATCH pve-firewall] allow non zero ip address host bits

2022-10-28 Thread Thomas Lamprecht
Some issue due to weird and unmentioned dependence on $noerr and while at it some small comment and commit message style nits that I might have either ignored or "fixed" up myself other way. On 25/10/2022 16:31, Stefan Hrdlicka wrote: > They can already be set directly via the cluster.fw file. N

[pve-devel] [PATCH qemu-server/novnc/manager/docs v3 0/6] Feature noVNC-Clipboard

2022-10-28 Thread Markus Frank
This patch-series adds a parameter to vga_fmt, that enables the noVNC-Clipboard and replaces the default SPICE-Clipboard if SPICE is used. changes v3: * added hint to make clearer that the spice guest tools are required for the noVNC-clipboard * Checkbox changes to ComboBox when a spice device is

[pve-devel] [PATCH qemu-server v3 1/6] enable clipboard parameter in vga_fmt

2022-10-28 Thread Markus Frank
added option to use the qemu vdagent implementation to enable the noVNC clipboard. When enabled with SPICE the spice-vdagent gets replaced with the qemu implementation. This patch does not solve #1406, but does allow copy and paste with a running X-session, when spice-vdagent is installed on the

[pve-devel] [PATCH qemu-server v3 2/6] added clipboard variable to return at status/current

2022-10-28 Thread Markus Frank
By that noVNC is able to check if clipboard is active. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 99b426e..25f3a1d 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2428,6 +2428,11 @@

[pve-devel] [PATCH novnc v3 4/6] added show clipboard button patch to series

2022-10-28 Thread Markus Frank
Signed-off-by: Markus Frank --- .../patches/0019-show-clipboard-button.patch | 31 +++ debian/patches/series | 1 + 2 files changed, 32 insertions(+) create mode 100644 debian/patches/0019-show-clipboard-button.patch diff --git a/debian/patches/0019-sho

[pve-devel] [PATCH manager v3 5/6] added clipboard checkbox & combobox to DisplayEdit

2022-10-28 Thread Markus Frank
If display is set to spice the checkbox gets replaced by a combobox to show the available clipboard options. Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 62 +++- 1 file changed, 61 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/Dis

[pve-devel] [PATCH qemu-server v3 3/6] test cases for clipboard spice & std

2022-10-28 Thread Markus Frank
added one test case for a spice display and one for std Signed-off-by: Markus Frank --- test/cfg2cmd/noVNC-clipboard-spice.conf | 1 + test/cfg2cmd/noVNC-clipboard-spice.conf.cmd | 27 + test/cfg2cmd/noVNC-clipboard-std.conf | 1 + test/cfg2cmd/noVNC-clipboard-std

[pve-devel] [PATCH docs v3 6/6] added noVNC clipboard documentation

2022-10-28 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qm.adoc b/qm.adoc index 4d0c7c4..3a575bc 100644 --- a/qm.adoc +++ b/qm.adoc @@ -693,6 +693,17 @@ Selecting `serialX` as display 'type' disables the VGA output, and redirects the Web Console