Re: [pve-devel] [PATCH widget-toolkit/manager v2 0/4] Ceph OSD: add detail infos

2022-10-18 Thread Aaron Lauterer
On 10/17/22 16:29, Dominik Csapak wrote: high level looks mostly good, a small question: is there a special reason why we ignore pre-lvm osds here? AFAICS, we simply error out for osds that don't live on lvm (though we can add additional types later i guess) Mainly because with a recent Cep

[pve-devel] [PATCH proxmox-offline-mirror 2/4] mirror: implement source packages mirroring

2022-10-18 Thread Fabian Grünbichler
similar to the binary package one, but with one additional layer since each source package consists of 2-3 files, not a single .deb file. Signed-off-by: Fabian Grünbichler --- Notes: requires proxmox-apt with source index support src/mirror.rs | 158

[pve-devel] [PATCH proxmox-offline-mirror 3/4] fix #4264: only require either Release or InRelease

2022-10-18 Thread Fabian Grünbichler
strictly speaking InRelease is required, and Release optional, but that might not be true for older repositories. treat failure to fetch either as non-fatal, provided the other is available. Signed-off-by: Fabian Grünbichler --- src/mirror.rs | 70 +---

[pve-devel] [PATCH-SERIES 0/6] proxmox-offline-mirror filtering & deb-src support

2022-10-18 Thread Fabian Grünbichler
this series implements filtering based on package section (exact match) or package name (glob), and extends mirroring support to source packages/deb-src repositories. technically the first patch in proxmox-apt is a breaking change, but the only user of the changed struct is proxmox-offline-mirror,

[pve-devel] [PATCH proxmox-apt 1/2] packages file: add section field

2022-10-18 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Notes: technically a breaking change, but the only user (pom) doesn't care. not bumping to an incompatible version would avoid the need to bump the dep in proxmox-perl-rs src/deb822/packages_file.rs | 2 ++ 1 file changed, 2 insertions(+) diff --g

[pve-devel] [PATCH proxmox-offline-mirror 1/4] mirror: add exclusion of packages/sections

2022-10-18 Thread Fabian Grünbichler
to keep the size of mirror snapshots down by excluding unnecessary files (e.g., games data, browsers, debug packages, ..). Signed-off-by: Fabian Grünbichler --- Notes: requires proxmox-apt with 'section' field we could suggest excluding sections like 'games' in the wizard/docs.. C

[pve-devel] [PATCH proxmox-apt 2/2] deb822: source index support

2022-10-18 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- the test file needs to be downloaded from the referenced URL and uncompressed (it's too big to send as patch). its SHA256sum is ec1d305f5e0a31bcf2fe26e955436986edb5c211c03a362c7d557c899349 src/deb822/mod.rs | 3 + src/

[pve-devel] [PATCH proxmox-offline-mirror 4/4] mirror: refactor fetch_binary/source_packages

2022-10-18 Thread Fabian Grünbichler
and pull out some of the progress variables into a struct. Signed-off-by: Fabian Grünbichler --- src/mirror.rs | 520 -- 1 file changed, 287 insertions(+), 233 deletions(-) diff --git a/src/mirror.rs b/src/mirror.rs index 39b7f47..f19 100644 -

[pve-devel] [PATCH manager] report: add arcstat

2022-10-18 Thread Aaron Lauterer
One of the infos, that can sometimes be usable. Signed-off-by: Aaron Lauterer --- PVE/Report.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Report.pm b/PVE/Report.pm index b8bceb24..90b7cb1c 100644 --- a/PVE/Report.pm +++ b/PVE/Report.pm @@ -124,6 +124,7 @@ my $init_report_cmds = sub

[pve-devel] applied: [PATCH qemu] savevm async IO channel: channel writev: fix return value in error case

2022-10-18 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH widget-toolkit v8 2/2] Toolkit: add override for Ext.dd.DragDropManager

2022-10-18 Thread Dominik Csapak
to fix selection behavior for Ext.dd.DragZone. Signed-off-by: Dominik Csapak --- src/Toolkit.js | 16 1 file changed, 16 insertions(+) diff --git a/src/Toolkit.js b/src/Toolkit.js index c730374..20b6eba 100644 --- a/src/Toolkit.js +++ b/src/Toolkit.js @@ -681,6 +681,22 @@ Ext.d

[pve-devel] [PATCH cluster v8 2/4] Cluster: add get_guest_config_properties

2022-10-18 Thread Dominik Csapak
akin to get_guest_config_property, but with a list of properties. uses the new CFS_IPC_GET_GUEST_CONFIG_PROPERTIES also adds the same NOTEs regarding parsing/permissions to the comment of get_guest_config_property Signed-off-by: Dominik Csapak --- data/PVE/Cluster.pm | 27 ++

[pve-devel] [PATCH manager v8 03/12] ui: call '/ui-options' and save the result in PVE.UIOptions

2022-10-18 Thread Dominik Csapak
and move the use of the console from VersionInfo to here, since this will be the future place for ui related backend options. Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 2 +- www/manager6/Workspace.js | 13 + www/manager6/dc/OptionView.js | 4 ++-- 3 file

[pve-devel] [PATCH cluster v8 3/4] datacenter.cfg: add option for tag-style

2022-10-18 Thread Dominik Csapak
its a property string containing 'tree-shape' and 'colors' the colors are formatted like this: :[:] Signed-off-by: Dominik Csapak --- data/PVE/DataCenterConfig.pm | 37 1 file changed, 37 insertions(+) diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/Dat

[pve-devel] [PATCH manager v8 05/12] ui: tree/ResourceTree: collect tags on update

2022-10-18 Thread Dominik Csapak
into a global list, so that we have it avaiable anywhere also add the tags from the tagOverrides on update into the list Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 7 +++ www/manager6/data/ResourceStore.js | 6 ++ www/manager6/tree/ResourceTree.js | 16

[pve-devel] [PATCH manager v8 11/12] ui: tree/ResourceTree: show Tags in tree

2022-10-18 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/lxc/Config.js| 4 +++- www/manager6/qemu/Config.js | 4 +++- www/manager6/tree/ResourceTree.js | 4 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index 9b301

[pve-devel] [PATCH widget-toolkit v8 1/2] add tag related helpers

2022-10-18 Thread Dominik Csapak
helpers to * generate a color from a string consistently * generate a html tag for a tag * related css classes contrast is calculated according to SAPC draft: https://github.com/Myndex/SAPC-APCA which is likely to become a w3c guideline in the future and seems to be a better algorithm for this S

[pve-devel] [PATCH manager v8 08/12] ui: add form/Tag

2022-10-18 Thread Dominik Csapak
displays a single tag, with the ability to edit inline on click (when the mode is set to editable). This brings up a list of globally available tags for simple selection. Signed-off-by: Dominik Csapak --- www/manager6/Makefile| 1 + www/manager6/form/Tag.js | 233 ++

[pve-devel] [PATCH container v8] check_ct_modify_config_perm: improve tag privilege check

2022-10-18 Thread Dominik Csapak
'normal' tags require 'VM.Config.Options' on '/vm/', but not allowed tags (either limited with 'user-tag-privileges' or 'admin-tags' in the datacenter config) require 'Sys.Modify' on '/' this patch implements the proper checks on adding/editing/deleting these permissions Signed-off-by: Dominik Cs

[pve-devel] [PATCH manager v8 09/12] ui: add form/TagEdit.js

2022-10-18 Thread Dominik Csapak
this is a wrapper container for holding a list of (editable) tags intended to be used in the lxc/qemu status toolbar to add a new tag, we reuse the 'pmxTag' class, but overwrite some of its behaviour so that it properly adds tags Signed-off-by: Dominik Csapak --- www/manager6/Makefile|

[pve-devel] [PATCH qemu-server v8] api: update: improve tag privilege check

2022-10-18 Thread Dominik Csapak
'normal' tags require 'VM.Config.Options' on '/vm/', but not allowed tags (either limited with 'user-tag-privileges' or 'admin-tags' in the datacenter config) require 'Sys.Modify' on '/' this patch implements the proper checks on adding/editing/deleting these permissions Signed-off-by: Dominik Cs

[pve-devel] [PATCH cluster v8 4/4] DataCenterConfig: add tag rights control to the datacenter config

2022-10-18 Thread Dominik Csapak
by adding a 'user-tag-privileges' and 'admin-tags' option. The first sets the policy by which "normal" users (with 'VM.Config.Options' on the respective guest) can create/delete tags and the second is a list of tags only settable by 'admins' ('Sys.Modify' on '/') also add a helper 'get_user_admin_

[pve-devel] [PATCH manager v8 02/12] api: add /ui-options api call

2022-10-18 Thread Dominik Csapak
which contains ui relevant options, like the console preference and tag-style Signed-off-by: Dominik Csapak --- PVE/API2.pm | 43 +++ 1 file changed, 43 insertions(+) diff --git a/PVE/API2.pm b/PVE/API2.pm index a4256160..2acdecdb 100644 --- a/PVE/API2.pm

[pve-devel] [PATCH manager v8 01/12] api: /cluster/resources: add tags to returned properties

2022-10-18 Thread Dominik Csapak
by querying 'lock' and 'tags' with 'get_guest_config_properties' Signed-off-by: Dominik Csapak --- PVE/API2/Cluster.pm | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm index d6b405e2..bc327e76 100644 --- a/PVE/API2/Cluster.pm

[pve-devel] [PATCH cluster/qemu-server/container/wt/manager v8] add tags to ui

2022-10-18 Thread Dominik Csapak
this series brings the already existing 'tags' for ct/vms to the gui: * tags can be edited in the status toolbar of the guest * existing tags will be shown in the tree/global search/resource grids * when editing a tag, a list of existing tags will be shown * by default, the color is (consistently)

[pve-devel] [PATCH manager v8 04/12] ui: parse and save tag color overrides from /ui-options

2022-10-18 Thread Dominik Csapak
into a global list of overrides. on update, also parse the values from the browser localstore. Also emits a GlobalEvent 'loadedUiOptions' so that e.g. the tags can listen to that and refresh their colors Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 40 +++

[pve-devel] [PATCH manager v8 07/12] ui: dc/OptionView: add editors for tag settings

2022-10-18 Thread Dominik Csapak
namely for 'tag-tree-style' and 'tag-colors'. display the tag overrides directly as they will appear as tags Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 20 + www/manager6/dc/OptionView.js | 84 +++ 2 files changed, 104 insertions(+)

[pve-devel] [PATCH cluster v8 1/4] add CFS_IPC_GET_GUEST_CONFIG_PROPERTIES method

2022-10-18 Thread Dominik Csapak
for getting multiple properties from the in memory config of the guests in one go. Keep the existing IPC call as is for backward compatibility and add this as separate, new one. It basically behaves the same as CFS_IPC_GET_GUEST_CONFIG_PROPERTY, but takes a list of properties instead and returns m

[pve-devel] [PATCH manager v8 06/12] ui: add form/TagColorGrid

2022-10-18 Thread Dominik Csapak
this provides a basic grid to edit a list of tag color overrides. We'll use this for editing the datacenter.cfg overrides and the browser storage overrides. Signed-off-by: Dominik Csapak --- www/css/ext6-pve.css | 5 + www/manager6/Makefile | 1 + www/manager6/Utils.

[pve-devel] [PATCH manager v8 10/12] ui: {lxc, qemu}/Config: show Tags and make them editable

2022-10-18 Thread Dominik Csapak
add the tags in the status line, and add a button for adding new ones Signed-off-by: Dominik Csapak --- www/manager6/lxc/Config.js | 32 ++-- www/manager6/qemu/Config.js | 31 +-- 2 files changed, 59 insertions(+), 4 deletions(-) diff --g

[pve-devel] [PATCH manager v8 12/12] ui: add tags to ResourceGrid and GlobalSearchField

2022-10-18 Thread Dominik Csapak
also allows to search for tags in the GlobalSearchField where each tag is treated like a seperate field, so it weighs more if the user searches for the exact string of a single tag Signed-off-by: Dominik Csapak ui: ResourceGrid: render tags with the 'full' styling Signed-off-by: Dominik Csapak

Re: [pve-devel] [PATCH manager 1/2] fix #3719: gui: expose MTU option for containers in web UI

2022-10-18 Thread Thomas Lamprecht
the implementation looks mostly OK and works, but some comments on limits and also a workflow nit that require a v2 high level: The CT implementation currently doesn't checks limits like qemu-server does, like setting (most of the time) bogus values <576 (see below) and guaranteed not working valu

[pve-devel] applied: [PATCH manager] report: add arcstat

2022-10-18 Thread Thomas Lamprecht
Am 18/10/2022 um 14:11 schrieb Aaron Lauterer: > One of the infos, that can sometimes be usable. > > Signed-off-by: Aaron Lauterer > --- > PVE/Report.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list pve-dev

Re: [pve-devel] [PATCH widget-toolkit/manager v2 0/4] Ceph OSD: add detail infos

2022-10-18 Thread Dominik Csapak
On 10/18/22 11:14, Aaron Lauterer wrote: On 10/17/22 16:29, Dominik Csapak wrote: high level looks mostly good, a small question: is there a special reason why we ignore pre-lvm osds here? AFAICS, we simply error out for osds that don't live on lvm (though we can add additional types later i