On 9/26/22 17:38, Thomas Lamprecht wrote:
I don't like that there's no commit message (the cover letter is more for
general/meta
info, it doesn't gets into git after all, would require doing pull requests
which we
(currently) don't do in most cases).
Besides that I'd rather avoid extending
On 9/26/22 17:51, Thomas Lamprecht wrote:
Am 22/09/2022 um 16:13 schrieb Stefan Hanreich:
I have decided to create distinct event types for source/target nodes, since
otherwise the same script would run essentially twice on the source/target node.
With distinct event types, the hooks should b
On 9/26/22 17:27, Thomas Lamprecht wrote:
Am 22/09/2022 um 16:13 schrieb Stefan Hanreich:
Signed-off-by: Stefan Hanreich
---
src/PVE/AbstractMigrate.pm | 14 ++
1 file changed, 14 insertions(+)
for the record, if we do it like this (not much rationale given in the commit
m
Am 27/09/2022 um 09:40 schrieb Stefan Hanreich:
> On 9/26/22 17:51, Thomas Lamprecht wrote:
>> Am 22/09/2022 um 16:13 schrieb Stefan Hanreich:
>>> I have decided to create distinct event types for source/target nodes, since
>>> otherwise the same script would run essentially twice on the source/tar
Am 27/09/2022 um 09:40 schrieb Stefan Hanreich:
> On 9/26/22 17:27, Thomas Lamprecht wrote:
>> Am 22/09/2022 um 16:13 schrieb Stefan Hanreich:
>>> Signed-off-by: Stefan Hanreich
>>> ---
>>> src/PVE/AbstractMigrate.pm | 14 ++
>>> 1 file changed, 14 insertions(+)
>>>
>>
>> for the re
On Mon, Sep 26, 2022 at 11:45:07AM +0200, Leo Nunner wrote:
> When renaming a group, the usages didn't get updated automatically. To
> get around problems with atomicity, the old rule is first cloned with the
> new name, the usages are updated and only when updating has finished, the
> old rule is
On 9/27/22 10:46, Wolfgang Bumiller wrote:
On Mon, Sep 26, 2022 at 11:45:07AM +0200, Leo Nunner wrote:
When renaming a group, the usages didn't get updated automatically. To
get around problems with atomicity, the old rule is first cloned with the
new name, the usages are updated and only when
On Tue, Sep 27, 2022 at 11:28:26AM +0200, Leo Nunner wrote:
>
> On 9/27/22 10:46, Wolfgang Bumiller wrote:
> > On Mon, Sep 26, 2022 at 11:45:07AM +0200, Leo Nunner wrote:
> > > + $cluster_conf->{groups}->{$param->{group}} =
> > > $cluster_conf->{groups}->{$param->{rename}};
> > > +
On 9/27/22 11:59, Wolfgang Bumiller wrote:
On Tue, Sep 27, 2022 at 11:28:26AM +0200, Leo Nunner wrote:
On 9/27/22 10:46, Wolfgang Bumiller wrote:
On Mon, Sep 26, 2022 at 11:45:07AM +0200, Leo Nunner wrote:
+ $cluster_conf->{groups}->{$param->{group}} =
$cluster_conf->{groups}->
On Tue, Sep 27, 2022 at 12:13:30PM +0200, Leo Nunner wrote:
> On 9/27/22 11:59, Wolfgang Bumiller wrote:
>
> > On Tue, Sep 27, 2022 at 11:28:26AM +0200, Leo Nunner wrote:
> > > On 9/27/22 10:46, Wolfgang Bumiller wrote:
> > > > On Mon, Sep 26, 2022 at 11:45:07AM +0200, Leo Nunner wrote:
> > > > >
Otherwise, there is nothing enforcing that the drive mirror is ready
when the migration inactivates the block devices, which can lead to a
failing assertion:
> ../block/io.c:2026: bdrv_co_write_req_prepare: Assertion
> `!(bs->open_flags & BDRV_O_INACTIVE)' failed.
QAPI documentation of 'write-bloc
11 matches
Mail list logo
