[pve-devel] [PATCH widget-toolkit] form/RoleSelector: fix for pve

2022-07-22 Thread Dominik Csapak
in pbs we get an array here, so the renderer is fine, but in pve it's just a long string, so add a space after commas to achieve the same effect. without this, the second column is not visible in pve because of an error in the renderer (no 'join' function on a string) Signed-off-by: Dominik Csapa

Re: [pve-devel] [RFC/PATCH pve-common 5/5] pbs client: backup fs tree: drop namespace parameter

2022-07-22 Thread Wolfgang Bumiller
On Wed, Jul 20, 2022 at 12:59:45PM +0200, Fabian Ebner wrote: > Instead, use the one from the initial configuration. The only current > caller is in PMG and the namespace parameter set there agrees with > the one from the initial configuration, so this is not actually a > breaking change. Still te

[pve-devel] [PATCH widget-toolkit] TaskProgress: show text instead of percentage

2022-07-22 Thread Aaron Lauterer
The text needs to be defined in the wait() call as otherwise the Ext.Progressbar will show a percentage that is not correct anyway but just reflects where the animated progress bar itself is. Signed-off-by: Aaron Lauterer --- This wasn't much of a problem in most cases where the task finished ver

Re: [pve-devel] [PATCH pve-container 1/3] fix #3711: enable delete of LXC container via force option

2022-07-22 Thread Wolfgang Bumiller
On Wed, Jul 20, 2022 at 04:49:47PM +0200, Stefan Hrdlicka wrote: > Make it possible to delete a container whoes underlying storage is no > longer available. This will just write an warning instead of dying. "no longer available" != "throws errors" (see below (*)) > > Without setting the option f

Re: [pve-devel] [PATCH pve-container 2/3] fix #3711 cleanup: remove spaces from empty lines

2022-07-22 Thread Wolfgang Bumiller
nit: the subject shouldn't have the `fix #3711` included as this patch is not directly affecting it ;-) On Wed, Jul 20, 2022 at 04:49:48PM +0200, Stefan Hrdlicka wrote: > remove spaces where they are not needed > > Signed-off-by: Stefan Hrdlicka > --- > src/PVE/LXC.pm | 10 +- > 1 file

[pve-devel] applied: [PATCH container] fix #4164: use DHCP=yes instead of DHCP=both in systemd-networkd config

2022-07-22 Thread Wolfgang Bumiller
On Tue, Jul 19, 2022 at 01:54:50PM +0200, Oguz Bektas wrote: > On Tue, Jul 19, 2022 at 01:52:37PM +0200, Fabian Grünbichler wrote: > > On July 19, 2022 1:24 pm, Oguz Bektas wrote: > > > "both" option is deprecated, this gets rid of the warning in the journal > > > > > > Signed-off-by: Oguz Bektas

[pve-devel] [PATCH manager v2 4/4] VM start Timeout "Options" parameter in the GUI

2022-07-22 Thread Daniel Tschlatscher
This makes it possible to set the newly introduced config parameter for timeout via the 'startoptions' property string. For now this only implements setting the timeout value when starting a VM, though this should be rather easily exentensible to include other future start options parameters. Sign

[pve-devel] [PATCH qemu-server v2 1/1] make the timeout value editable when the VM is locked

2022-07-22 Thread Daniel Tschlatscher
In some cases the VM could no longer start when the timeout value was set and afterwards, for example, hibernated. In this case the VM is arguably soft locked, because the API would not allow changing the timeout value anymore. (The only way out here would be to change the value manually in the con

[pve-devel] [PATCH qemu-server v2 2/4] fix #3502: VM start timeout config parameter

2022-07-22 Thread Daniel Tschlatscher
This patch makes it possible to now set the starting timeout value for a VM via the config parameter 'startoptions'. Now, if the timeout parameter is set, it will override the heuristic calculation of the VM start timeout. The maximum value for the timeout parameter is 86400 seconds, which is one

[pve-devel] [PATCH common v2 1/4] fix #3502: VM start timeout config parameter

2022-07-22 Thread Daniel Tschlatscher
This allows setting the 'startoptions' property string in the config. For now this only implements the 'timeout' parameter but should be rather easily extensible and allow related VM start config options to be also configurable here. Signed-off-by: Daniel Tschlatscher --- Changes from v1: * This

[pve-devel] [PATCH qemu-server v2 3/4] kill/await lingering KVM thread when VM start reaches timeout

2022-07-22 Thread Daniel Tschlatscher
In some cases the VM API start method would return before the detached KVM process would have exited. This is especially problematic with HA, because the HA manager would think the VM started successfully, later see that it exited and start it again in an endless loop. Moreover, another case exist