[pve-devel] [PATCH manager] Jobs: fix scheduling when updating on unrelated nodes

2022-07-14 Thread Dominik Csapak
since the jobs are configured clusterwide in pmxcfs, a user can use any node to update the config of them. for some configs (schedule/enabled) we need to update the last runtime in the state file, but this is sadly only node-local. to also update the state file on the other nodes, we introduce a n

Re: [pve-devel] [PATCH storage 2/3] disks: die if storage name is already in use

2022-07-14 Thread Dominik Csapak
comments inline On 7/13/22 12:47, Aaron Lauterer wrote: If a storage of that type and name already exists (LVM, zpool, ...) but we do not have a Proxmox VE Storage config for it, it is likely that the creation will fail mid way due to checks done by the underlying storage layer itself. This in t

Re: [pve-devel] [PATCH storage 1/3] diskmanage: add mounted_paths

2022-07-14 Thread Dominik Csapak
comment inline On 7/13/22 12:47, Aaron Lauterer wrote: returns similar values as mounted_blockdevs, but uses the mounted path as key and the blockdev path as value Signed-off-by: Aaron Lauterer --- used for the Directory check in patch 2 PVE/Diskmanage.pm | 13 + 1 file changed

Re: [pve-devel] [PATCH storage 3/3] disks: allow add_storage for already configured local storage

2022-07-14 Thread Dominik Csapak
comments inline On 7/13/22 12:47, Aaron Lauterer wrote: One of the smaller annoyances, especially for less experienced users, is the fact, that when creating a local storage (ZFS, LVM (thin), dir) in a cluster, one can only leave the "Add Storage" option enabled the first time. On any following

[pve-devel] [PATCH storage] pbs: use vmid parameter in list_snapshots

2022-07-14 Thread Wolfgang Bumiller
Particularly for operations such as pruning backups after a scheduled backups we do not want to list the entire store. (pbs_api_connect is moved up unmodified) Note that the 'snapshots' CLI command only takes a full group, but the API does allow specifying a backup-id without a backup-type! Sign

Re: [pve-devel] [PATCH storage 1/3] diskmanage: add mounted_paths

2022-07-14 Thread Aaron Lauterer
On 7/14/22 13:13, Dominik Csapak wrote: comment inline On 7/13/22 12:47, Aaron Lauterer wrote: returns similar values as mounted_blockdevs, but uses the mounted path as key and the blockdev path as value Signed-off-by: Aaron Lauterer --- used for the Directory check in patch 2   PVE/Diskma

[pve-devel] applied: [PATCH storage] pbs: use vmid parameter in list_snapshots

2022-07-14 Thread Thomas Lamprecht
Am 14/07/2022 um 13:24 schrieb Wolfgang Bumiller: > Particularly for operations such as pruning backups after a > scheduled backups we do not want to list the entire > store. > > (pbs_api_connect is moved up unmodified) > > Note that the 'snapshots' CLI command only takes a full > group, but the

Re: [pve-devel] [PATCH storage 2/3] disks: die if storage name is already in use

2022-07-14 Thread Fabian Ebner
Am 14.07.22 um 13:13 schrieb Dominik Csapak:> On 7/13/22 12:47, Aaron Lauterer wrote: >> +    my $poollist = { map { $_->{name} => 1 } @{$pools} }; > > does that really make sense here? would it not be easier to just > iterate? e.g. > > > for my $pool (@$pools) { >     die "..." if $pool->{n

Re: [pve-devel] [PATCH storage 2/3] disks: die if storage name is already in use

2022-07-14 Thread Dominik Csapak
On 7/14/22 14:12, Fabian Ebner wrote: Am 14.07.22 um 13:13 schrieb Dominik Csapak:> On 7/13/22 12:47, Aaron Lauterer wrote: +    my $poollist = { map { $_->{name} => 1 } @{$pools} }; does that really make sense here? would it not be easier to just iterate? e.g. for my $pool (@$pools) {

[pve-devel] testing pvesm storage plugin api

2022-07-14 Thread Andrei Perapiolkin via pve-devel
--- Begin Message --- Hi, Is there a guide on how to test code against specific api version? Im talking about API for storage plugin in pvesm. I need this info to test my custom plugin for new data-storage that I want to be compatible with proxmox. Thanks for your time, Andrei --- End M