Re: [pve-devel] [PATCH access-control] fix #4074: increase API OpenID code size limit to 2048

2022-06-20 Thread Mira Limbeck
On 6/17/22 10:42, Wolfgang Bumiller wrote: On Wed, Jun 15, 2022 at 04:09:50PM +0200, Mira Limbeck wrote: Azure AD seems to have a variable authorization code size, depending on the browser state according to one report in bug #4074 [0]. Sometimes the size is greater than our current limit of 10

[pve-devel] [PATCH v6 qemu-server 1/9] qemuconfig: load_current_config : delete cloudinit value

2022-06-20 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuConfig.pm | 8 1 file changed, 8 insertions(+) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index cfef8d3..d912456 100644 --- a/PVE/QemuConfig.pm +++ b/PVE/QemuConfig.pm @@ -516,6 +516,14 @@ sub __snapshot_rollback_get_unused { re

[pve-devel] [PATCH v6 qemu-server 5/9] generate cloudinit drive on offline plug

2022-06-20 Thread Alexandre Derumier
Currently when only generate it at vm start Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 9f550d9..d3c9448 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5103,6 +510

[pve-devel] [PATCH v6 qemu-server 0/9] cloudinit pending behaviour change

2022-06-20 Thread Alexandre Derumier
Hi, This is an attempt to cleanup current behaviour of cloudinit online changes. Currently, we setup cloudinit options as pending, until we generate the config drive. This is not 100% true, because some option like vm name, nic mac address can be changed, without going to pending, so user can'

[pve-devel] [PATCH v6 qemu-server 8/9] api2: add cloudinit_update

2022-06-20 Thread Alexandre Derumier
This allow to regenerate the config drive with 1 api call. This also avoid to delete drive first, and recreate it again. As it's a readonly drive, we can simply live update it, and eject/replace it with qemu monitor Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 43 +

[pve-devel] [PATCH v6 qemu-server 4/9] cloudinit: add cloudinit section for current generated config.

2022-06-20 Thread Alexandre Derumier
Instead using vm pending options for pending cloudinit generated config, write current generated cloudinit config in a new [special:cloudinit] SECTION. Currently, some options like vm name, nic mac address can be hotplugged, so they are not way to know if the cloud-init disk is already updated.

[pve-devel] [PATCH v6 qemu-server 2/9] vzdump : skip special:cloudinit section

2022-06-20 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/VZDump/QemuServer.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index 7429508..1d38e63 100644 --- a/PVE/VZDump/QemuServer.pm +++ b/PVE/VZDump/QemuServer.pm @@ -214,17 +214,20

[pve-devel] [PATCH v6 qemu-server 3/9] migration: test targetnode min version for cloudinit section

2022-06-20 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuMigrate.pm| 10 +- PVE/QemuServer/Helpers.pm | 26 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index d52dc8d..e594564 100644 --- a/PVE/QemuMigrate.pm

[pve-devel] [PATCH v6 qemu-server 6/9] cloudinit: make cloudnit options fastplug

2022-06-20 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 31 +-- 1 file changed, 5 insertions(+), 26 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index d3c9448..f4f4b7b 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -4832,6 +4832,10 @@ m

[pve-devel] [PATCH v6 qemu-server 9/9] add cloudinit hotplug

2022-06-20 Thread Alexandre Derumier
This allow to regenerate config drive if pending values exist when we change vm options. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 426e638..6d7705a 100644

[pve-devel] [PATCH v6 qemu-server 7/9] api2: add cloudinit config api

2022-06-20 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm| 68 PVE/CLI/qm.pm | 1 + PVE/QemuServer/Cloudinit.pm | 78 + 3 files changed, 147 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm