[pve-devel] [PATCH manager] ui: manual backup: list possible template variables directly

2022-05-06 Thread Fabian Ebner
rather than as a tooltip. Suggested-by: Thomas Lamprecht Signed-off-by: Fabian Ebner --- www/manager6/Utils.js | 2 ++ www/manager6/dc/Backup.js | 2 +- www/manager6/window/Backup.js | 16 ++-- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/www/manager

[pve-devel] [PATCH pve-docs] fixed port range mentions for corosync v3.0+

2022-05-06 Thread Marco Gabriel via pve-devel
--- Begin Message --- corosync v2 used ports 5405 and 5404, but corosync v3 uses ports 5405-5412. fixed in docs. Signed-off-by: Marco Gabriel --- pve-firewall.adoc | 6 +++--- pvecm.adoc| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pve-firewall.adoc b/pve-firew

Re: [pve-devel] [PATCH manager] GUI: Ceph wizard: autoselect current node

2022-05-06 Thread Thomas Lamprecht
Am 5/5/22 um 16:27 schrieb Matthias Heiserer: > One step of installing ceph is creating a monitor. When installing via > the datacenter and from a node other than the first node, clicking "next" > without changing the monitor node could result in the error > 'binary not installed: /usr/bin/ceph-mo

Re: [pve-devel] [PATCH manager] GUI: Ceph wizard: autoselect current node

2022-05-06 Thread Matthias Heiserer
On 06.05.2022 10:00, Thomas Lamprecht wrote: Am 5/5/22 um 16:27 schrieb Matthias Heiserer: www/manager6/ceph/CephInstallWizard.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js index 59458b0d..ebdc7f1d 100

[pve-devel] [RFC qemu-server] api: create disks: avoid adding secondary cloud-init drives

2022-05-06 Thread Fabian Ebner
This will break possibly existing workflows like 1. add second cloud-init 2. remove first cloud-init to change the cloud-init storage. On the other hand, it avoids unintended misconfiguration of having mutliple cloud-init drives with potentially different settings. Also in preparation for adding

Re: [pve-devel] [PATCH v4 qemu-server 1/6] cloudinit: add cloudinit section for current generated config.

2022-05-06 Thread Fabian Ebner
Am 27.04.22 um 16:05 schrieb Alexandre Derumier: > Instead using vm pending options for pending cloudinit generated config, > > write current generated cloudinit config in a new [special:cloudinit] SECTION. > > Currently, some options like vm name, nic mac address can be hotplugged, > so they are

Re: [pve-devel] [PATCH v4 qemu-server 3/6] cloudinit: make cloudnit options fastplug

2022-05-06 Thread Fabian Ebner
Am 27.04.22 um 16:05 schrieb Alexandre Derumier: > --- > PVE/QemuServer.pm | 31 +-- > 1 file changed, 5 insertions(+), 26 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 53be830..998f7c8 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServ

[pve-devel] [PATCH manager] vzdump: generate notes: initialize potentially undef values

2022-05-06 Thread Fabian Ebner
For VMs, $task->{hostname} might be undef and when running on a stand-alone node, there is no cluster name. Reported-by: Marco Gabriel Signed-off-by: Fabian Ebner --- PVE/VZDump.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index edcab6

Re: [pve-devel] [PATCH v1 http-server 2/2] AnyEvent: disable upload timeout

2022-05-06 Thread Matthias Heiserer
On 22.04.2022 18:54, Thomas Lamprecht wrote: On 22.04.22 16:43, Matthias Heiserer wrote: During some testing, I had various requests time out. Bug reports describing that behaviour include #795 from 2015 and #66 from 2011. While disabling the timeout is certainly not ideal, it should fix this is

[pve-devel] [PATCH v2 qemu 1/2] block/gluster: correctly set max_pdiscard which is int64_t

2022-05-06 Thread Fabian Ebner
Previously, max_pdiscard would be zero in the following assertion: qemu-system-x86_64: ../block/io.c:3166: bdrv_co_pdiscard: Assertion `max_pdiscard >= bs->bl.request_alignment' failed. Fixes: 0c8022876f ("block: use int64_t instead of int in driver discard handlers") Signed-off-by: Fabian Ebner

[pve-devel] [PATCH v2 qemu 2/2] ui/vnc.c: Fixed a deadlock bug.

2022-05-06 Thread Fabian Ebner
From: Rao Lei The GDB statck is as follows: (gdb) bt 0 __lll_lock_wait (futex=futex@entry=0x56211df20360, private=0) at lowlevellock.c:52 1 0x7f263caf20a3 in __GI___pthread_mutex_lock (mutex=0x56211df20360) at ../nptl/pthread_mutex_lock.c:80 2 0x56211a757364 in qemu_mutex_lock_impl (

[pve-devel] [PATCH manager v2] fix #3994: Options menu entry in the System menu

2022-05-06 Thread Daniel Tschlatscher
Add the subentry "Options" in the "System" menu to expose some options in the GUI which were not exposed before. Added a new file for displaying and editing the node config options which were not exposed through the GUI yet. Namely those are the settings for wakeonlan and startall-on-boot-delay. E