[pve-devel] applied: [PATCH qemu-server] migrate: keep VM paused after migration if it was before

2022-04-21 Thread Thomas Lamprecht
On 18.03.22 08:51, Fabian Ebner wrote: > Also cannot issue a guest agent command in that case. > > Reported in the community forum: > https://forum.proxmox.com/threads/106618 > > Signed-off-by: Fabian Ebner > --- > > Best viewed with -w. > > PVE/QemuMigrate.pm | 54 ++-

Re: [pve-devel] [PATCH qemu-server] migrate: keep VM paused after migration if it was before

2022-04-21 Thread Fabian Ebner
Am 20.04.22 um 14:43 schrieb Fabian Grünbichler: > On March 18, 2022 8:51 am, Fabian Ebner wrote: >> Also cannot issue a guest agent command in that case. >> >> Reported in the community forum: >> https://forum.proxmox.com/threads/106618 >> >> Signed-off-by: Fabian Ebner >> --- >> >> Best viewed w

Re: [pve-devel] [PATCH qemu-server] migrate: keep VM paused after migration if it was before

2022-04-21 Thread Fabian Grünbichler
On April 21, 2022 9:20 am, Fabian Ebner wrote: > Am 20.04.22 um 14:43 schrieb Fabian Grünbichler: >> one other thing I noticed (pre-existing, but the changes here made me >> look and my search came up short), inside phase2: >> >> - start block job(s) without autocompletion and wait for them to >

Re: [pve-devel] [PATCH qemu-server] migrate: keep VM paused after migration if it was before

2022-04-21 Thread Fabian Ebner
Am 20.04.22 um 14:43 schrieb Fabian Grünbichler: > On March 18, 2022 8:51 am, Fabian Ebner wrote: >> Also cannot issue a guest agent command in that case. >> >> Reported in the community forum: >> https://forum.proxmox.com/threads/106618 >> >> Signed-off-by: Fabian Ebner >> --- >> >> Best viewed w

Re: [pve-devel] [PATCH qemu-server] migrate: keep VM paused after migration if it was before

2022-04-21 Thread Fabian Grünbichler
On April 21, 2022 9:44 am, Fabian Ebner wrote: > Am 20.04.22 um 14:43 schrieb Fabian Grünbichler: >> On March 18, 2022 8:51 am, Fabian Ebner wrote: >>> Also cannot issue a guest agent command in that case. >>> >>> Reported in the community forum: >>> https://forum.proxmox.com/threads/106618 >>> >>>

[pve-devel] [PATCH v2 qemu-server 2/7] restore destroy volumes: remove check for absolute path

2022-04-21 Thread Fabian Ebner
Only a result from vdisk_alloc is assigned as a volid and that's never an absolute path. Signed-off-by: Fabian Ebner --- No changes from v1. PVE/QemuServer.pm | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index f221d93c..be0694f9

[pve-devel] [PATCH v2 qemu-server 1/7] restore: cleanup oldconf: also clean up snapshots from kept volumes

2022-04-21 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- No changes from v1. PVE/QemuServer.pm | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 0be6be90..f221d93c 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6228,6 +6228,8 @@ su

[pve-devel] [PATCH v2 qemu-server 5/7] api: create: refactor parameter check logic

2022-04-21 Thread Fabian Ebner
In preparation to allow passing along certain parameters together with 'archive'. Moving the parameter checks to after the conflicts-with-'archive' to ensure that the more telling error will trigger first. All check helpers should handle empty params fine, but check first just to make sure and to

[pve-devel] [PATCH v2 qemu 1/2] vma: restore: call blk_unref for all opened block devices

2022-04-21 Thread Fabian Ebner
rather than just the last one. This is the only caller registering block devices with the reader, so other callers are already fine. Signed-off-by: Fabian Ebner --- New in v2. Best squashed into 0026-PVE-Backup-add-vma-backup-format-code.patch vma-reader.c | 3 +++ vma.c| 6 ++ 2

[pve-devel] [PATCH v2 manager 2/3] ui: restore: allow override of some settings

2022-04-21 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- New in v2. Dependency bump for qemu-server needed www/manager6/window/Restore.js | 77 +- 1 file changed, 75 insertions(+), 2 deletions(-) diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js index 25babf8

[pve-devel] [PATCH v2 qemu-server 6/7] api: create: allow overriding non-disk options during restore

2022-04-21 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Changes from v1: * Split this part into its own patch. PVE/API2/Qemu.pm | 8 ++-- PVE/QemuServer.pm | 26 -- 2 files changed, 26 insertions(+), 8 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 976d1bd6..8df2

[pve-devel] [PATCH v2 manager 3/3] ui: restore: allow preserving disks

2022-04-21 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- New in v2. Dependency bump for proxmox-widget-toolkit needed www/manager6/Makefile| 1 + www/manager6/grid/RestoreDiskGrid.js | 125 +++ www/manager6/window/Restore.js | 35 +++- 3 files changed, 160 insertion

[pve-devel] [PATCH v2 qemu-server 7/7] restore: allow preserving drives during restore

2022-04-21 Thread Fabian Ebner
Preserving a drive means: * The disk it references will not be touched by the restore operation. * The drive will be left as is in the VM configuration. * If the drive is present in the backup, that disk will not be restored. A drive that is not present in the backup was/is re-added

[pve-devel] [PATCH v2 qemu-server 3/7] restore deactivate volumes: never die

2022-04-21 Thread Fabian Ebner
Such an error shouldn't abort the whole operation. Signed-off-by: Fabian Ebner --- No changes from v1. PVE/QemuServer.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index be0694f9..9a16b617 100644 --- a/PVE/QemuServer.pm +++ b/PVE

[pve-devel] [PATCH-SERIES v2 qemu/qemu-server/widget-toolkit/manager] more flexible restore

2022-04-21 Thread Fabian Ebner
Allows preserving disks and overriding VM settings upon restore. For containers, overriding settings was already possible, but managing partial restore is more involved because of nested mount structure, etc. Exposes the functionality in the UI, allowing to set (host)name, cores(+sockets), memory,

[pve-devel] [PATCH v2 widget-toolkit 1/1] css: add proxmox-good-row class

2022-04-21 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- New in v2. src/css/ext6-pmx.css | 4 1 file changed, 4 insertions(+) diff --git a/src/css/ext6-pmx.css b/src/css/ext6-pmx.css index c26b533..886e24a 100644 --- a/src/css/ext6-pmx.css +++ b/src/css/ext6-pmx.css @@ -23,6 +23,10 @@ background-color: #f5e5

[pve-devel] [PATCH v2 manager 1/3] ui: restore: disallow empty storage selection if it wouldn't work

2022-04-21 Thread Fabian Ebner
Namely, if there is a storage in the backup configuration that's not available on the current node. Signed-off-by: Fabian Ebner --- New in v2. www/manager6/window/Restore.js | 34 ++ 1 file changed, 34 insertions(+) diff --git a/www/manager6/window/Restore.js b

[pve-devel] [PATCH v2 qemu-server 4/7] restore: also deactivate/destroy cloud-init disk upon error

2022-04-21 Thread Fabian Ebner
by re-using the same hash that's used when allocating/activating the disks in the helpers doing the opposite. Also in preparation to allow skipping certain disks upon restore. Signed-off-by: Fabian Ebner --- No changes from v1. PVE/QemuServer.pm | 32 1 file c

[pve-devel] [PATCH v2 qemu 2/2] vma: allow partial restore

2022-04-21 Thread Fabian Ebner
Introduce a new map line for skipping a certain drive, of the form skip=drive-scsi0 Since in PVE, most archives are compressed and piped to vma for restore, it's not easily possible to skip reads. For the reader, a new skip flag for VmaRestoreState is added and the target is allowed to be NULL if

Re: [pve-devel] [PATCH pve-docs] fix #3884: Add section for kernel samepage merging

2022-04-21 Thread Dylan Whyte
Hi, I just wanted to bump this documentation patch, as I think it may have been missed. Dylan On 2/25/22 17:29, Dylan Whyte wrote: Adds a section to the "Host System Administration" section of the Administration Guide, discussing KSM and its security risks Signed-off-by: Dylan Whyte ---