These lines were only used by grid/BackupView, which gets deleted in
this series.
Signed-off-by: Matthias Heiserer
---
No changes from v2/v3/v4
www/manager6/storage/ContentView.js | 43 ++---
1 file changed, 8 insertions(+), 35 deletions(-)
diff --git a/www/manager6/sto
Signed-off-by: Matthias Heiserer
---
No changes from v2/v3/v4
www/manager6/Makefile | 1 -
www/manager6/grid/BackupView.js | 388
www/manager6/lxc/Config.js | 2 +-
www/manager6/qemu/Config.js | 2 +-
4 files changed, 2 insertions(+), 391
Depends on https://lists.proxmox.com/pipermail/pve-devel/2022-March/052322.html
I hope I didn't miss anything this time :)
Reviewed-by: Fabian Ebner
Matthias Heiserer (4):
ui: Utils: Helpers for backup type and icon
ui: storage: Rewrite backup content view as TreePanel.
ui: delete BackupV
Signed-off-by: Matthias Heiserer
---
no changes from v3/v4
changes from v2:
return in else branch
changes from v1:
add "backup" to name
www/manager6/Utils.js | 20
1 file changed, 20 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 735806aa..
Should be easier to read/use than the current flat list.
Backups are grouped by ID and type, so in case there are backups
with ID 100 for both CT and VM, this would create two separate
groups in the UI.
Date and size of group are taken from the latest backup.
Notes, Protection, Encrypted, and Verif
Text enclosed in unescaped curly braces will be interpreted as an
attribute reference breaking and e.g. lead to the description not
showing up at all a generated man page further down the line.
Signed-off-by: Fabian Ebner
---
New in v3.
Tried out various uses of curly braces and seems to work f
In command_line(), notes are printed, quoted, but otherwise as is,
which is a bit ugly for multi-line notes. But it is part of the
commandline, so print it.
Signed-off-by: Fabian Ebner
---
Changes from v2:
* Switch to {{var}} syntax.
src/PVE/VZDump/Common.pm | 17 -
1 file
Signed-off-by: Fabian Ebner
---
Changes from v2:
* Switch to {{var}} syntax.
Arguably, a warning from failing to set notes is not very visible, but
I didn't want to make it a full-blown error.
PVE/VZDump.pm | 23 +++
1 file changed, 23 insertions(+)
diff --git a/PVE/VZ
Introduce 'protected' to automatically mark a backup as protected
upon completion, and 'notes-template' to generate notes from a
template string with certain variables.
Add both to the UI for manual backups and add 'notes-template' to the
UI for backup jobs.
Changes from v2:
* Dropped alread
Check the number of protected backups early if the protected flag
is set.
Suggested-by: Thomas Lamprecht
Signed-off-by: Fabian Ebner
---
No changes from v2.
PVE/VZDump.pm | 43 ++-
1 file changed, 34 insertions(+), 9 deletions(-)
diff --git a/PVE/VZDum
Add a tooltip to the comment field, to better distinguish it from the
notes-template.
Signed-off-by: Fabian Ebner
---
Changes from v2:
* Squash in patch setting default value.
* Switch to {{var}} syntax.
* Use singular "backup" in gettext to be able to reuse same
message as for
Setting a width, so the text area can fill the horizontal space.
Suggested-by: Thomas Lamprecht
Signed-off-by: Fabian Ebner
---
Changes from v2:
* Add default value and tooltip for notes-tempalte.
www/manager6/window/Backup.js | 33 -
1 file changed, 32 ins
Hi Guys!
I'm using Terraform to manage VMs running on Proxmox. I need to be able to
upload snippets with custom cloud-init configuration. Right now I have to
use scp/sftp to upload snippets so I have to use a system account. It looks
that I'm not the only one having this issue:
https://bugzilla.pr
Am 07.04.22 um 10:34 schrieb Matthias Heiserer:
> Depends on
> https://lists.proxmox.com/pipermail/pve-devel/2022-March/052322.html
>
> I hope I didn't miss anything this time :)
>
> Reviewed-by: Fabian Ebner
Next time, please add the tag to the unchanged patches directly. I did
look at the ch
patches LGTM, 2/3 could be squashed into 1/3 so that we have
the new code in the same commit as the Makefile change,
or what do you think @thomas? do you prefer those things
to be split into 2 patches?
on an additional note, we could even add more functionality to the
button, namely a simple 'set
ah i forgot:
consider the series:
Reviewed-by: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Commit fa7980c2 ("ui: lxc resources: switch to vector based font
awesome icons") seems like an innocent change, but it broke the
(very brittle) logic here by removing the tdCls for rootfs.
Signed-off-by: Fabian Ebner
---
www/manager6/lxc/Resources.js | 2 +-
1 file changed, 1 insertion(+), 1 del
Am 05.04.22 um 14:30 schrieb Aaron Lauterer:
> @@ -264,6 +303,7 @@ Ext.define('PVE.lxc.RessourceView', {
>
> var pending = rec.data.delete || me.hasPendingChanges(key);
> var isDisk = rowdef.tdCls === 'pve-itype-icon-storage';
Pre-existing: this is very brittle and actually b
Am 05.04.22 um 14:30 schrieb Aaron Lauterer:
> This series adds the UI to reassign a disk / volume from one guest to another.
>
> To avoid button clutter, the Move, Reassing and Resize buttons are moved
> into a new submenu called "Disk/Volume Action".
>
> Patch 1 changes how we store the max num
Am 05.04.22 um 14:30 schrieb Aaron Lauterer:
> Signed-off-by: Aaron Lauterer
> ---
> www/manager6/Utils.js | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> index 3351e53b..fe5be283 100644
> --- a/www/manager6/Utils.js
> +++
On 07.04.22 14:15, Fabian Ebner wrote:
> Commit fa7980c2 ("ui: lxc resources: switch to vector based font
> awesome icons") seems like an innocent change, but it broke the
> (very brittle) logic here by removing the tdCls for rootfs.
holy moly, didn't really expect that the gui is using css classe
21 matches
Mail list logo
