Re: [pve-devel] [PATCH storage 1/4] check volume access: allow if user has VM.Config.Disk

2022-03-24 Thread Fabian Grünbichler
On March 22, 2022 10:31 am, Fabian Ebner wrote: > Am 22.03.22 um 09:31 schrieb Fabian Ebner: >> Am 21.03.22 um 14:06 schrieb Fabian Ebner: >>> Listing guest images should not require Datastore.Allocate in this >>> case. In preparation for adding disk import to the GUI. >>> >>> Signed-off-by: Fabian

Re: [pve-devel] [PATCH v4 manager 6/6] ui: util: refactor mps to mp

2022-03-24 Thread Aaron Lauterer
On 3/22/22 12:18, Fabian Ebner wrote: Am 14.03.22 um 10:35 schrieb Aaron Lauterer: @@ -1805,9 +1805,7 @@ Ext.define('PVE.Utils', { }, nextFreeMP: function(type, config) { - let mptype = type === "mp" ? "mps" : type; - - for (let i = 0; i < PVE.Utils.mp_counts[mptyp

Re: [pve-devel] [PATCH v4 manager 2/6] ui: lxc/qemu: add disk reassign and action submenu

2022-03-24 Thread Aaron Lauterer
Thanks for the nits. Especially regarding the button (de)activation logic. I can send a follow-up patch or a new version of the whole series, or just this patch. Whatever is preferred :) On 3/22/22 12:18, Fabian Ebner wrote: Am 14.03.22 um 10:35 schrieb Aaron Lauterer: @@ -227,14 +246,34 @@

Re: [pve-devel] [PATCH v4 manager 3/6] ui: lxc/qemu: disk/volume action simplify menu items

2022-03-24 Thread Thomas Lamprecht
On 14.03.22 10:35, Aaron Lauterer wrote: > We already know that we are acting upon a disk / volume due to the > submenu we are in. ok with that in general, but some proposal over conveying better what "move" and "reassign" respectively means while not getting a long label. Also, a (separate) sugg

[pve-devel] [PATCH manager] use the width-helper from utils

2022-03-24 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- www/manager6/lxc/Resources.js | 14 +- www/manager6/qemu/HardwareView.js | 14 +- 2 files changed, 2 insertions(+), 26 deletions(-) diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js index 15ee3c67..1b5d51d9

[pve-devel] [PATCH widget-toolkit 1/2] Utils: add calculate max button width hack

2022-03-24 Thread Matthias Heiserer
The same code is used once in widget toolkit and twice in PVE already, so it makes sense to add it as a separate function. Signed-off-by: Matthias Heiserer --- src/Utils.js | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/Utils.js b/src/Utils.js index 6a03057..27fcd1d 100644

[pve-devel] [PATCH widget-toolkit 2/2] use the width-helper from utils

2022-03-24 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- src/node/APTRepositories.js | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index 09ed0be..d63a569 100644 --- a/src/node/APTRepositories.js +++ b/src/node/APTRepositories

[pve-devel] [PATCH docs v3 1/1] update documentation about sync-options

2022-03-24 Thread Dominik Csapak
describe the new 'remove-vanished' option and what the options are doing Signed-off-by: Dominik Csapak --- pveum.adoc | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/pveum.adoc b/pveum.adoc index a5c8906..99e1a45 100644 --- a/pveum.adoc +++ b/pveum.adoc

[pve-devel] [PATCH access-control/manager/docs v3] fix #3668: improving realm sync

2022-03-24 Thread Dominik Csapak
this deprecates the 'full' and 'purge' sync options and replaces them with a 'remove-vanished' option, where we have multiple flags to determine which things we want to remove when they are not in the sync response. changes from v2: * instead of having a mode, define what we actually do: configure

[pve-devel] [PATCH manager v3 1/1] ui: realm sync: replace 'full' and 'purge' with 'remove-vanished'

2022-03-24 Thread Dominik Csapak
in default sync options and the sync window. We do this by exposing the individual flags as checkboxes. We get the mapped value from the backend so we do not have to handle 'old' values here. Signed-off-by: Dominik Csapak --- www/manager6/dc/AuthEditLDAP.js | 63 +++

[pve-devel] [PATCH access-control v3 1/1] fix #3668: realm-sync: replace 'full' and 'purge' options with 'remove-vanished'

2022-03-24 Thread Dominik Csapak
since both configure what is removed when an entry (or property) is not returned from the sync result. 'remove-vanished' is a list of things to remove: 'acl', 'entry', 'properties'. 'full' maps to 'entry;properties' and 'purge' to 'acl' Keep the old properties for backwards-compatibiltiy. On cre

[pve-devel] [PATCH pve-qemu] fix: 3865: backup restore human readable output

2022-03-24 Thread Daniel Tschlatscher
The backup restore dialogue now displays size information and duration in a format more easily understandable for humans. The output was adapted to match the output of the backup restore dialogue where possible. Added 2 helper methods for displaying bytes and time in human readable format. Signe