Re: [pve-devel] [PATCH access-control/manager v2] fix #3668: improving realm sync

2022-03-23 Thread Thomas Lamprecht
On 22.03.22 16:23, Dominik Csapak wrote: > On 3/22/22 14:44, Thomas Lamprecht wrote: >> On 22.03.22 07:11, Thomas Lamprecht wrote: >>> On 04.02.22 15:24, Dominik Csapak wrote: this deprecates the 'full' sync option and replaces it with a 'mode' option, where we add a third one that update

Re: [pve-devel] [pbs-devel] [PATCH proxmox-backup v3 1/6] fix #3067: api: add support for multi-line comments in node.cfg

2022-03-23 Thread Wolfgang Bumiller
On Fri, Mar 04, 2022 at 12:31:57PM +0100, Stefan Sterz wrote: > add support for multi-line comments to node.cfg and the api, similar to > how pve handles multi-line comments > > Signed-off-by: Stefan Sterz Acked-by: Wolfgang Bumiller ___ pve-devel m

Re: [pve-devel] [PATCH access-control/manager v2] fix #3668: improving realm sync

2022-03-23 Thread Thomas Lamprecht
On 23.03.22 08:33, Thomas Lamprecht wrote: >>> remove-vanished: [];[];[acls] >>> >>> I.e., those three flags would replace your new mode + purge like: >>> >>> +++-+ >>> |  Mode  | Purge  | -> removed-vanished | >>> +++-+ >>> |

[pve-devel] applied: [pbs-devel] [PATCH proxmox-backup v3 1/6] fix #3067: api: add support for multi-line comments in node.cfg

2022-03-23 Thread Thomas Lamprecht
On 04.03.22 12:31, Stefan Sterz wrote: > add support for multi-line comments to node.cfg and the api, similar to > how pve handles multi-line comments > > Signed-off-by: Stefan Sterz > --- > pbs-api-types/src/lib.rs | 9 +++ > src/api2/node/config.rs | 4 +++ > src/config/node.rs |

[pve-devel] [PATCH cluster v4 1/1] datacenter.cfg: add option for tag-tree-style and tag-colors

2022-03-23 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- data/PVE/DataCenterConfig.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/DataCenterConfig.pm index 6c0fa5b..e890820 100644 --- a/data/PVE/DataCenterConfig.pm +++ b/data/PVE/DataCenterConfig.pm @@ -222

[pve-devel] [PATCH manager v4 02/10] api: /version: add 'tag-colors' and 'tag-tree-style'

2022-03-23 Thread Dominik Csapak
to be able to get them in the gui directly after login Signed-off-by: Dominik Csapak --- PVE/API2.pm | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/PVE/API2.pm b/PVE/API2.pm index a4256160..0592d4de 100644 --- a/PVE/API2.pm +++ b/PVE/API2.pm @@ -111,6 +111,16 @@

[pve-devel] [PATCH manager v4 01/10] api: /cluster/resources: add tags to returned properties

2022-03-23 Thread Dominik Csapak
by querying 'lock' and 'tags' with 'get_guest_config_properties' Signed-off-by: Dominik Csapak --- PVE/API2/Cluster.pm | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm index 227c6814..69272fc7 100644 --- a/PVE/API2/Cluster.pm

[pve-devel] [PATCH manager v4 09/10] ui: tree/ResourceTree: show Tags in tree

2022-03-23 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/lxc/Config.js| 4 +++- www/manager6/qemu/Config.js | 4 +++- www/manager6/tree/ResourceTree.js | 4 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index 4e2b4

[pve-devel] [PATCH manager v4 08/10] ui: {lxc, qemu}/Config: show Tags and make them editable

2022-03-23 Thread Dominik Csapak
add the tags in the status line, and add a button for adding new ones Signed-off-by: Dominik Csapak --- www/manager6/lxc/Config.js | 68 +++-- www/manager6/qemu/Config.js | 66 +-- 2 files changed, 130 insertions(+), 4 deletions(-)

[pve-devel] [PATCH widget-toolkit v4 1/1] add tag related helpers

2022-03-23 Thread Dominik Csapak
helpers to * generate a color from a string consistently * generate a html tag for a tag * related css classes Signed-off-by: Dominik Csapak --- src/Utils.js | 35 + src/css/ext6-pmx.css | 52 2 files changed, 87 in

[pve-devel] [PATCH manager v4 03/10] ui: parse and save tag color overrides from /version

2022-03-23 Thread Dominik Csapak
and implement a convenience function that also parses the 'color' state from the browser storage for overrides Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 34 ++ www/manager6/Workspace.js | 13 + 2 files changed, 47 insertions(+) dif

[pve-devel] [PATCH manager v4 06/10] ui: dc/OptionView: add editors for tag settings

2022-03-23 Thread Dominik Csapak
namely for 'tag-tree-style' and 'tag-colors'. display the tag overrides directly as they will appear as tags Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 20 www/manager6/dc/OptionView.js | 43 ++- 2 files changed, 62 insertio

[pve-devel] [PATCH manager v4 04/10] ui: tree/ResourceTree: collect tags on update

2022-03-23 Thread Dominik Csapak
into a global list, so that we have it avaiable anywhere add a convenience 'getTagList' function, that also gets tags from the overrides from datacenter.cfg and browser-storage Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 8 www/manager6/data/ResourceStore.js

[pve-devel] [PATCH manager v4 10/10] ui: form/GlobalSearchField: display tags and allow to search for them

2022-03-23 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/form/GlobalSearchField.js | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/www/manager6/form/GlobalSearchField.js b/www/manager6/form/GlobalSearchField.js index 267a480d..7a27cb29 100644 --- a/www/manager6/for

[pve-devel] [PATCH cluster/widget-toolkit/manager v4] add tags to ui

2022-03-23 Thread Dominik Csapak
this series is a continuation of my previous attempt in 2019. note that this requires my previous patch for pve-cluster that introduces the 'get properties' pmxcfs message[0] this is a bit "rough" on various points, but i wanted to send what i have before i code myself into a hole i cannot easily

[pve-devel] [PATCH manager v4 05/10] ui: add form/TagColorGrid

2022-03-23 Thread Dominik Csapak
this provides a basic grid to edit a list of tag color overrides. We'll use this for editing the datacenter.cfg overrides and the browser storage overrides. Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/form/TagColorGrid.js | 218 ++

[pve-devel] [PATCH manager v4 07/10] ui: add form/Tag

2022-03-23 Thread Dominik Csapak
displays a single tag, with the ability to edit inline on click. This brings up a list of globally available tags for simple selection. Also has a mode for adding a new Tag. This has a 'updateCallback' which is called when the value changes so that the parent component can update the config, and

Re: [pve-devel] [PATCH widget-toolkit v3 4/6] toolkit: add markdown based NotesView and NotesEdit

2022-03-23 Thread Thomas Lamprecht
On 04.03.22 12:32, Stefan Sterz wrote: > move these from pve to the widget toolkit to be ablte to use them in > pbs > this is no 1:1 move but the commit messages fails to describe the changes made nor the rationale. > Signed-off-by: Stefan Sterz > --- > src/Makefile| 2 + > src/p

Re: [pve-devel] [PATCH proxmox-backup v3 3/6] fix #3607: ui: add a separate notes view for longer markdown notes

2022-03-23 Thread Thomas Lamprecht
On 04.03.22 12:31, Stefan Sterz wrote: > since markdown notes might be rather long, this commit adds a tab > similar to pve's datacenter or node notes. > > Signed-off-by: Stefan Sterz > --- > www/Makefile | 2 + > www/NavigationTree.js | 6 ++ > www/NodeNotes.js

Re: [pve-devel] [PATCH proxmox-backup v3 5/6] fix #3607: ui: refactor notes by moving the panel/window to widget kit

2022-03-23 Thread Thomas Lamprecht
On 04.03.22 12:32, Stefan Sterz wrote: > for better re-use between pbs and pve move the markdown notes panel > and editor window to the widget kit and unify them there. > ah ok, now I get it, rather please just leave the intermediate addition of a notes view and directly use the wtk version and j