[pve-devel] [PATCH qemu-server] migrate: keep VM paused after migration if it was before

2022-03-18 Thread Fabian Ebner
Also cannot issue a guest agent command in that case. Reported in the community forum: https://forum.proxmox.com/threads/106618 Signed-off-by: Fabian Ebner --- Best viewed with -w. PVE/QemuMigrate.pm | 54 ++ 1 file changed, 31 insertions(+), 23 del

[pve-devel] [PATCH widget-toolkit] Utils: clear cookies with secure flag set

2022-03-18 Thread Dominik Csapak
otherwise firefox complains with a deprecation warning that the secureflag is not set but SameSite to 'None'. Since we cannot know how firefox will behave once that behaviour is no longer supported, add the secure flag now. we have to use the 'set' api of ExtJs to do that reliably Signed-off-by:

[pve-devel] [PATCH container 1/1] Setup: Allow hostname configuration on NixOS

2022-03-18 Thread Harikrishnan R via pve-devel
--- Begin Message --- While NixOS generally overrides any static contents in /etc/hostname with the hostname defined in `networking.hostname`, it can use the contents of `/etc/hostname` provided by PVE if this option is not set. Signed-off-by: Harikrishnan R --- src/PVE/LXC/Setup/NixOS.pm | 4 --

[pve-devel] [PATCH container 0/1] Setup: Allow hostname configuration on NixOS

2022-03-18 Thread Harikrishnan R via pve-devel
--- Begin Message --- Hostname can be set through /etc/hostname on NixOS with minor changes to the default NixOS network options. Harikrishnan R (1): Setup: Allow hostname configuration on NixOS src/PVE/LXC/Setup/NixOS.pm | 4 1 file changed, 4 deletions(-) -- 2.35.1 --- End Message -

Re: [pve-devel] [PATCH V2 pve-firewall] add cluster ebtables_dst_macfilter option.

2022-03-18 Thread Wolfgang Bumiller
Sorry for the late reply. On Fri, Sep 10, 2021 at 05:34:29PM +0200, Alexandre Derumier wrote: > This new option allow filtering of destination macs for ingress traffic. > > This is a protection from bad/hosting networks (like hetzner) flooding > traffic with non-hosted mac. > > To be fast, one r

[pve-devel] [PATCH manager 0/5 v2] BackupView as TreePanel

2022-03-18 Thread Matthias Heiserer
This replaces the backupview for storages and the BackupView for qemu and lxc with a single TreeView. Less code, no need to maintain two different BackupView files, and reduces complexity of ContentView. Changes from v1: - replace grid/BackupView with storage/BackupView - some bug fixes and code c

[pve-devel] [PATCH manager 5/5 v2] Storage ContentView: Remove dead code

2022-03-18 Thread Matthias Heiserer
These lines were only used by grid/BackupView, which gets deleted in this series. Signed-off-by: Matthias Heiserer --- www/manager6/storage/ContentView.js | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/www/manager6/storage/ContentView.js b/www/man

[pve-devel] [PATCH manager 4/5 v2] Remove grid/backupview as it got replaced by storage/backupview

2022-03-18 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- www/manager6/grid/BackupView.js | 388 1 file changed, 388 deletions(-) delete mode 100644 www/manager6/grid/BackupView.js diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js deleted file mode 10064

[pve-devel] [PATCH manager 1/5 v2] Storage GUI: Rewrite backup content view as TreePanel.

2022-03-18 Thread Matthias Heiserer
Should be easier to read/use than the current flat list. Backups are grouped by ID and type, so in case there are backups with ID 100 for both CT and VM, this would create two separate groups in the UI. Date and size of group are taken from the latest backup. Notes, Protection, Encrypted, and Verif

[pve-devel] [PATCH manager 2/5 v2] GUI: Utils: Helpers for backup type and icon

2022-03-18 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- changes from v1: add "backup" to name return empty string instead of throwing www/manager6/Utils.js | 20 1 file changed, 20 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index aafe359a..337ccfae 100644 --- a/ww

[pve-devel] [PATCH manager 3/5 v2] Backup GUI: Use the new storage/BackupView instead of grid/BackupView.

2022-03-18 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- www/manager6/lxc/Config.js | 2 +- www/manager6/qemu/Config.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index 89b59c9b..242780c8 100644 --- a/www/manager6/lxc/Config.js +++

Re: [pve-devel] [PATCH manager 2/5 v2] GUI: Utils: Helpers for backup type and icon

2022-03-18 Thread Thomas Lamprecht
On 18/03/2022 14:52, Matthias Heiserer wrote: > Signed-off-by: Matthias Heiserer > --- > changes from v1: > add "backup" to name > return empty string instead of throwing patch order is wrong though, you cannot use a helper in patch 1/x and only introduce it in a later patch. This break bisect

[pve-devel] applied: [PATCH widget-toolkit] Utils: clear cookies with secure flag set

2022-03-18 Thread Thomas Lamprecht
On 18/03/2022 11:00, Dominik Csapak wrote: > otherwise firefox complains with a deprecation warning that the secureflag > is not set but SameSite to 'None'. Since we cannot know how firefox will > behave once that behaviour is no longer supported, add the secure flag > now. > > we have to use the

Re: [pve-devel] [PATCH V2 pve-firewall] add cluster ebtables_dst_macfilter option.

2022-03-18 Thread DERUMIER, Alexandre
Hi Wolfgang, I think we don't need this patch, now that bridge disabling learning patch has been applied https://git.proxmox.com/?p=pve-common.git;a=commit;h=354ec8dee37d481ebae49b488349a8e932dce736 (The problem with hetzner was unicast flood to all ports, and iptables reject replied with fwbr