higher level comment: We cannot do it this way as it adds a cyclic dependency
between pve-container <-> pve-manager and qemu-server <-> pve-manager, which
is not allowed (such things, besides being ugly, make bootstrapping *a lot*
harder, and as I'm most often doing the bootstrap effort I NAK this)
On 15.03.2022 11:06, Dominik Csapak wrote:
On 3/9/22 15:18, Matthias Heiserer wrote:
When clicking on a column to sort it, the filter doesn't reset.
Previously, it forgot the filter until the value was changed.
Signed-off-by: Matthias Heiserer
---
src/form/ComboGrid.js | 7 +++
1 file c
Am 14.03.22 um 16:54 schrieb Fabian Grünbichler:
> On March 9, 2022 11:09 am, Fabian Ebner wrote:
---snip---
>> my $check_drive_param = sub {
>> my ($param, $storecfg, $extra_checks) = @_;
>>
>> for my $opt (sort keys $param->%*) {
>> next if !PVE::QemuServer::is_valid_drivename
On March 14, 2022 10:03 am, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak
> ---
> data/PVE/Cluster.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
> index c65ba17..49022c3 100644
> --- a/data/PVE/Cluster.pm
> +++ b/dat
On March 14, 2022 10:03 am, Dominik Csapak wrote:
> for getting multiple properties from the in memory config of the
> guests. I added a new CSF_IPC_ call to maintain backwards compatibility.
>
> It basically behaves the same as
> CFS_IPC_GET_GUEST_CONFIG_PROPERTY, but takes a list of properties
>
Am 14.03.22 um 16:57 schrieb Fabian Grünbichler:
> applied qemu-server patches except 11 and 14-16, see comments on
> indivudal patches.
>
Thanks a lot for the review/feedback!
> some unrelated but possibly fix-able as followup things I noticed:
> - cloning a running VM with an EFI disk fails,
this and the other one existing one might also warrant a comment
indicating that you possibly still want to parse/validate/filter the
result before passing it along further up the stack (or that it should
only be used for very simple keys?)
- if no vmid is passed, the result needs to be filtere
On March 16, 2022 11:00 am, Fabian Ebner wrote:
> Am 14.03.22 um 16:57 schrieb Fabian Grünbichler:
>> applied qemu-server patches except 11 and 14-16, see comments on
>> indivudal patches.
>>
>
> Thanks a lot for the review/feedback!
>
>> some unrelated but possibly fix-able as followup things
Am 16.12.21 um 13:12 schrieb Fabian Ebner:
> In command_line(), notes are printed, quoted, but otherwise as is,
> which is a bit ugly for multi-line notes. But it is part of the
> commandline.
>
> Signed-off-by: Fabian Ebner
> ---
> src/PVE/VZDump/Common.pm | 14 +-
> 1 file changed,
Am 16.03.22 um 11:29 schrieb Fabian Grünbichler:
> On March 16, 2022 11:00 am, Fabian Ebner wrote:
>> Am 14.03.22 um 16:57 schrieb Fabian Grünbichler:
>>> applied qemu-server patches except 11 and 14-16, see comments on
>>> indivudal patches.
>>>
>>
>> Thanks a lot for the review/feedback!
>>
>>>
When clicking on a column to sort it, the filter doesn't reset.
Previously, it forgot the filter until the value was changed.
Signed-off-by: Matthias Heiserer
---
Changes from v1:
Introduce a config property to (en|dis)disable clearing the filter
src/form/ComboGrid.js | 11 +++
1 file ch
On March 16, 2022 12:25 pm, Fabian Ebner wrote:
> Am 16.03.22 um 11:29 schrieb Fabian Grünbichler:
>> On March 16, 2022 11:00 am, Fabian Ebner wrote:
>>> Am 14.03.22 um 16:57 schrieb Fabian Grünbichler:
applied qemu-server patches except 11 and 14-16, see comments on
indivudal patches.
>
a similar patch for adding/editing roles is missing (else, this is
trivially worked around by giving myself 'CustomRole' that doesn't have
SU, then editing that role to add SU to it).
On March 11, 2022 12:25 pm, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas
> ---
> v1->v2:
> * added new afte
On 29.05.20 14:22, Mira Limbeck wrote:
> The combogrid contains all valid icmp types that iptables accepts. In
> addition to the names, the Type[/Code] value is shown as well. But
> specifying Type[/Code] is not supported.
>
> As the simple solution with setStore() does not work to change the stor
On 29.05.20 14:22, Mira Limbeck wrote:
> Signed-off-by: Mira Limbeck
> ---
> v2:
> - rebased on master
>
> pve-firewall-rules-opts.adoc | 4
> 1 file changed, 4 insertions(+)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.pro
On 25.01.21 15:54, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer
> ---
>
> v1->v3: nothing
>
> www/manager6/qemu/Options.js | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
On 24.06.21 14:30, Stefan Reiter wrote:
> zfs_mirror_size_check is already called in get_zfs_raid_setup when
> necessary, so don't call it unconditionally, as this will cause a
> false-positive error on RAID0 devices (where size mismatches are fine).
>
> Signed-off-by: Stefan Reiter
> ---
> prox
On 05.07.21 12:15, Oguz Bektas wrote:
> sometimes the qdevice setup can fail when copying CA certificates if the
> node SSH keys are not matching for some reason.
>
> reported here:
> https://forum.proxmox.com/threads/pvecm-qdevice-setup-fails.88681
>
> Signed-off-by: Oguz Bektas
> ---
> pvecm.
On 13.08.21 11:10, Fabian Ebner wrote:
> The backend won't allow any edits in this case, so better just disable
> the edit button altogether.
>
> Co-developed-by: Fabian Grünbichler
> Signed-off-by: Fabian Ebner
> ---
>
> Changes from v1:
> * split cases based on 'key'
> * keep logic fo
On 05.09.21 09:37, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier
> ---
> www/manager6/sdn/zones/Base.js | 2 ++
> www/manager6/sdn/zones/EvpnEdit.js | 22 ++
> 2 files changed, 24 insertions(+)
>
>
applied, thanks!
_
On 24.09.21 10:50, Alexandre Derumier wrote:
> following pve-common
> https://lists.proxmox.com/pipermail/pve-devel/2021-September/050090.html
>
> Alexandre Derumier (4):
> vnets: fix get_vnet
> zones : tap_plug: add support for disable bridge learning
> zones: add add_bridge_fdb
> zones:
On 04.10.21 08:08, Alexandre Derumier wrote:
> - display zones list in global permissions management pathselector
> - remove vmbrX bridges from bridgeselector if user have permissions on vnets
>
>
> changelog v2:
>
> - check permission on /sdn/vnet/ too if user need access on both
> vnets && v
On 11.03.22 12:59, Markus Frank wrote:
> With "noerr => 1" the function does not abort, when one of the
> mountpoints is not fstrim compatible like zfs (has its own trim).
> I do not think it is necessary to warn or error, because fstrim
> tells when something is not trimmable and aborts.
>
> Sig
On 04.11.21 15:40, Dominik Csapak wrote:
> Series LGTM, looked closely at the regexes,
> and they match (semantically), tested around a bit
> and all seemed to work.
>
> one super small nit (not a blocker IMHO)
>
> the format/extension/compression handling in 2/2
> could maybe use a comment what
On 24.09.21 10:48, Alexandre Derumier wrote:
> Currently, if bridge receive an unknown dest mac (network bug/attack/..),
> we are flooding packets to all bridge ports.
>
> This can waste cpu time, even more with firewall enabled.
> Also, if firewall is used with reject action, the src mac of RST
>
On 12.11.21 12:28, Fabian Ebner wrote:
> Suggested-by: Thomas Lamprecht
> Signed-off-by: Fabian Ebner
> ---
> www/manager6/grid/BackupView.js| 22 +-
> www/manager6/storage/BackupView.js | 24 +++-
> 2 files changed, 44 insertions(+), 2 deletions(-)
>
On 15.11.21 13:37, Fabian Ebner wrote:
> by making sure the storage ID is part of the error. This can happen
> for (at least) CIFS, and GlusterFS with local server.
>
> Signed-off-by: Fabian Ebner
> ---
> PVE/Storage.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, tha
On 15.11.21 13:37, Fabian Ebner wrote:
> in the same manner as NT_STATUS_ACCESS_DENIED. It can be assumed to be
> a configuration error, so avoid showing the generic "storage
> is not online". Reported in the community forum:
> https://forum.proxmox.com/threads/storage-is-not-online-cifs.99201/pos
On 16.12.21 13:12, Fabian Ebner wrote:
> The ability to mark backups as protected broke the implicit assumption
> in vzdump that remove=1 and current number of backups being the limit
> (i.e. sum of all keep options) will result in a backup being removed.
>
> Introduce a new storage property 'max-
On 16.12.21 13:12, Fabian Ebner wrote:
> Otherwise, there is no storage-agnostic way to filter by backup group.
>
> Call it subtype, to not confuse it with content type, and to be able
> to re-use it for other content types than backup, if the need ever
> arises.
>
> Signed-off-by: Fabian Ebner
Hi Thomas,
I'm currently on a proxmox training session this week, so I'll not have
time to work on it until next week.
BTW, I have also an pending bugfix for mtu && ovs here, but I think I
need to rebase it now that others patches are applied, so I'll rework
it for next week.
https://lists.proxm
On 25.02.22 13:00, Markus Frank wrote:
> added a Parameter for vIOMMU so nobody has to use a github-script
> or change the kvm command on every vm boot.
> The args parameter doesn't work because the -device parameter(kvm)
> with intel-iommu has to be placed before the other arguments.
>
some shor
On 28.02.22 14:48, Dominik Csapak wrote:
> some systems[0] have pci domains longer than the default ('') of 4
> characters, so change the regex to allow at least 4.
>
> 0:
> https://forum.proxmox.com/threads/problem-with-gpu-passthrough-in-a-virtual-machine.105720/
>
> Signed-off-by: Dominik
On 06.03.22 13:46, Alexandre Derumier wrote:
> Allow balloon device driver to report hints of guest free pages to the host,
> for auto memory reclaim
>
> https://lwn.net/Articles/759413/
> https://events19.linuxfoundation.org/wp-content/uploads/2017/12/KVMForum2018.pdf
> Signed-off-by: Alexandre
On 28.02.22 14:48, Dominik Csapak wrote:
> by default, there is only one pci domain (''), but there are systems
> where there are more, and they don't need to be exactly 4 characters
> long (see [0]), so extend that regex to allow domains 4 characters or
> longer
>
> 0:
> https://forum.proxmo
On 16.03.22 12:04, Fabian Ebner wrote:
> Am 16.12.21 um 13:12 schrieb Fabian Ebner:
>> In command_line(), notes are printed, quoted, but otherwise as is,
>> which is a bit ugly for multi-line notes. But it is part of the
>> commandline.
>>
>> Signed-off-by: Fabian Ebner
>> ---
>> src/PVE/VZDump/C
Le mercredi 16 mars 2022 à 18:48 +0100, Thomas Lamprecht a écrit :
> On 06.03.22 13:46, Alexandre Derumier wrote:
> > Allow balloon device driver to report hints of guest free pages to
> > the host,
> > for auto memory reclaim
> >
> > https://antiphishing.cetsi.fr/proxy/v3?i=WjB4M1dJWGJJMnNGTHV5M
--- Begin Message ---
Resending this to the list, I accidentally sent it to Dominique directly.
On Tue, Mar 15, 2022 at 10:21 AM Dominique Martinet
wrote:
...
> I wasn't able to find any follow-up after the "leaving it to you"
> message here, was there something I missed?
>
I got scared off by
38 matches
Mail list logo
