Re: [pve-devel] [PATCH v3 manager 1/4] ui: lxc/qemu: add disk reassign and action submenu

2022-03-10 Thread Fabian Ebner
Am 07.03.22 um 11:07 schrieb Aaron Lauterer: > For the new HDReassign component, we follow the approach of HDMove to > have one componend for qemu and lxc. > > To avoid button clutter, a new "Disk/Volume action" button is > introduced. It holds the Move, Reassign and Resize buttons in a submenu. >

Re: [pve-devel] [PATCH v3 manager 4/4] ui: hdmove: modernize/refactor

2022-03-10 Thread Fabian Ebner
Am 07.03.22 um 11:07 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > changes since > > v2: > * switch from generic window to proxmox edit > > v1: much of the feedback to the HDReassign.js from the > first patch has been incorporated here as well. > > * reducing predefined cbind

Re: [pve-devel] [PATCH v3 manager 3/4] ui: BusTypeSelector: change noVirtIO to withVirtIO

2022-03-10 Thread Fabian Ebner
Am 07.03.22 um 11:07 schrieb Aaron Lauterer: > Double negated properties make it harder than necessary to parse > conditions. > > Signed-off-by: Aaron Lauterer > --- > www/manager6/form/BusTypeSelector.js| 4 ++-- > www/manager6/form/ControllerSelector.js | 4 ++-- > www/manager6/qemu/CDEdit

Re: [pve-devel] [PATCH common 2/2] REST environment: default to 'root@pam' for forked workers in case no user was specified

2022-03-10 Thread Fabian Ebner
Am 07.03.22 um 10:20 schrieb Oguz Bektas: > previously we had a default of 'root@pve', which doesn't exist. > since the username is only relevant for the task logs, we can change it > to 'root@pam' without ill effects. > > also add a warning in case there are other call sites that we missed > wher

[pve-devel] [PATCH widget-toolkit] StatusView: fix usage calculation for fields without valid values

2022-03-10 Thread Dominik Csapak
Sometimes, total can be zero (e.g. for swap when it's not used), which leads to the usage being NaN. This led to the progressbar not being updated for InfoWidgets, leaving a spurious '0%' as text. Signed-off-by: Dominik Csapak --- src/panel/StatusView.js | 2 +- 1 file changed, 1 insertion(+), 1

[pve-devel] [PATCH manager] ui: fix adding hostpci > 5

2022-03-10 Thread Dominik Csapak
by using the limits from PVE.Utils Signed-off-by: Dominik Csapak --- www/manager6/qemu/PCIEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js index a38b28ca..2f67aece 100644 --- a/www/manager6/qemu/PCIEdit.js +++