Re: [pve-devel] [PATCH manager 4/6] api: mon: mds: osd: add safety check endpoints

2022-02-22 Thread Thomas Lamprecht
On 18.02.22 12:38, Aaron Lauterer wrote: > for mon, mds and osd: ok-to-stop > mon: ok-to-rm > osd: safe-to-destroy > > Signed-off-by: Aaron Lauterer > --- > > I added the OSD safe-to-destroy endpoint even though I have no immediate > use for it as of now. But plan to include it in the OSD panel

[pve-devel] [PATCH v2 pve-zsync] parse cron: properly split commandline

2022-02-22 Thread Fabian Ebner
Reported in the community forum: https://forum.proxmox.com/threads/105254/ Signed-off-by: Fabian Ebner --- Changes from v1: * Use shellwords(). pve-zsync | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pve-zsync b/pve-zsync index 7246336..46b0ba7 100755 --- a/pve-zs

Re: [pve-devel] [PATCH v3 guest-common 1/1] guest helpers: add run_with_replication_guard

2022-02-22 Thread Fabian Ebner
Am 21.02.22 um 12:58 schrieb Fabian Ebner: > Signed-off-by: Fabian Ebner > --- > > New in v3. > > src/PVE/GuestHelpers.pm | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/GuestHelpers.pm b/src/PVE/GuestHelpers.pm > index 970c460..1183819 100644 >

Re: [pve-devel] [PATCH v2 manager] ui: hdmove: modernize/refactor

2022-02-22 Thread Dominik Csapak
some comments inline On 11/15/21 16:02, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- changes since v1: much of the feedback to the HDReassign.js from the first patch has been incorporated here as well. * reducing predefined cbind values for more arrow functions * using more arrow f

Re: [pve-devel] [PATCH v3 guest-common 1/1] guest helpers: add run_with_replication_guard

2022-02-22 Thread Fabian Grünbichler
On February 22, 2022 10:41 am, Fabian Ebner wrote: > Am 21.02.22 um 12:58 schrieb Fabian Ebner: >> Signed-off-by: Fabian Ebner >> --- >> >> New in v3. >> >> src/PVE/GuestHelpers.pm | 15 ++- >> 1 file changed, 14 insertions(+), 1 deletion(-) >> >> diff --git a/src/PVE/GuestHelpers.

Re: [pve-devel] [RFC v10 qemu-server 6/7] api: support VM disk import

2022-02-22 Thread Fabian Ebner
Am 13.01.22 um 11:08 schrieb Fabian Ebner: > @@ -89,6 +90,10 @@ my $check_storage_access = sub { > } else { > PVE::Storage::check_volume_access($rpcenv, $authuser, $storecfg, > $vmid, $volid); > } > + > + if (my $source_image = $drive->{'import-from'}) { > + PVE::

[pve-devel] applied: [PATCH v2 pve-zsync] parse cron: properly split commandline

2022-02-22 Thread Thomas Lamprecht
On 22.02.22 10:12, Fabian Ebner wrote: > Reported in the community forum: > https://forum.proxmox.com/threads/105254/ > > Signed-off-by: Fabian Ebner > --- > > Changes from v1: > * Use shellwords(). > > pve-zsync | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, th

Re: [pve-devel] [PATCH librados2-perl 2/6] mon_command: optionally ignore errors and return hashmap

2022-02-22 Thread Aaron Lauterer
On 2/21/22 16:44, Thomas Lamprecht wrote: On 18.02.22 12:38, Aaron Lauterer wrote: This patch requires patch 3 of the series to not break OSD removal! Therefore releasing a new version of librados2-perl and pve-manager needs to be coordinated. I don't like that and think it can be avoided.

Re: [pve-devel] [PATCH v3 guest-common 1/1] guest helpers: add run_with_replication_guard

2022-02-22 Thread Fabian Ebner
Am 22.02.22 um 11:27 schrieb Fabian Grünbichler: > On February 22, 2022 10:41 am, Fabian Ebner wrote: >> Am 21.02.22 um 12:58 schrieb Fabian Ebner: >>> @@ -82,6 +83,18 @@ sub guest_migration_lock { >>> return $res; >>> } >>> >>> +sub run_with_replication_guard { >>> +my ($vmid, $timeout

Re: [pve-devel] [RFC v10 qemu-server 6/7] api: support VM disk import

2022-02-22 Thread Fabian Grünbichler
On February 22, 2022 1:11 pm, Fabian Ebner wrote: > Am 13.01.22 um 11:08 schrieb Fabian Ebner: >> @@ -89,6 +90,10 @@ my $check_storage_access = sub { >> } else { >> PVE::Storage::check_volume_access($rpcenv, $authuser, $storecfg, >> $vmid, $volid); >> } >> + >> +if (my $sour

[pve-devel] [PATCH novnc] parse error 'already started' on guest start

2022-02-22 Thread Dominik Csapak
when we start an already started container, we get an error instead of a task that fails so to have similar behaviour between vm and ct, we parse that error for the start command and behave like it was successful put it in the first patch and rebase the rest of them Signed-off-by: Dominik Csapak

Re: [pve-devel] [PATCH novnc] parse error 'already started' on guest start

2022-02-22 Thread Dominik Csapak
argh... the commit subject should ofc be 'already running' not 'started' ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-network] controllers: evpn : use frr restart if reload fail

2022-02-22 Thread Alexandre Derumier
frr reload is not 100% perfect, and sometime is not able to apply correctly changes. Use restart in this case to be sure to have the correct config. Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/EvpnPlugin.pm | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff