On Wed, Feb 09, 2022 at 06:35:33PM +0100, Thomas Lamprecht wrote:
> On 27.01.22 11:55, Dominik Csapak wrote:
> > we will need some extra parameters here, and instead of hardcoding them,
> > have the option to set a list of arbitrary parameters
> >
> > Signed-off-by: Dominik Csapak
> > ---
> > sr
this patch adds a check for the guests status, and show a start button
instead of connecting to a non-started guest
this should reduce confusion when a guest is not running, and also
reduce the number of false-positive failed console tasks
Signed-off-by: Dominik Csapak
---
...ow-start-button-on
hi,
thx for the review :)
On Wed, Feb 09, 2022 at 07:03:34PM +0100, Thomas Lamprecht wrote:
> commit subject should rather be
>
> "ui: vm network: allow to override mtu for virtio devices"
okay
>
> On 07.02.22 13:18, Oguz Bektas wrote:
> > we already have the 'mtu' option inside the API, so w
On February 4, 2022 7:45 pm, Stoiko Ivanov wrote:
> changes v1->v2:
> * incorporated the feedback on the v1 (by Aaron and Fabian - huge thx!):
> ** a next-boot pin is now handled independently from a pin - i.e. if you
>both pin a kernel and set one for the next-boot - the system afterwards
>
On February 4, 2022 7:45 pm, Stoiko Ivanov wrote:
> by setting the desired version in a dedicated file, which is used
> by the systemd service as condition for removing it and refreshing
> upon reboot
>
> Signed-off-by: Stoiko Ivanov
> ---
> bin/proxmox-boot-tool | 34 ++
On February 4, 2022 7:45 pm, Stoiko Ivanov wrote:
> The 2 commands follow the mechanics of p-b-t kernel add/remove in
> writing the desired abi-version to a config-file in /etc/kernel and
> actually modifying the boot-loader configuration upon p-b-t refresh.
>
> A dedicated new file is used instea
we already have the 'mtu' option inside the API, so we can just expose
that option inside the 'Advanced' menu for virtio network interfaces.
Signed-off-by: Oguz Bektas
---
v1->v2:
* add viewmodel formula 'isVirtio', we use it to set the MTU field
enabled only for virtio interfaces
www/manager6/
Am 09.02.22 um 14:07 schrieb Fabian Grünbichler:
> re-using helpers that already exist for qemu-server. this is a
> pre-requisite for extending remote migration support to containers.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> new in v5, no GUI yet until possible wrinkles are i
Looks good AFAICT and does what we want.
We could improve it further by adding a small validator. Otherwise the user
will only notice their error once they get the error msg from the API.
A quick way that I came up with that could potentially be done better:
diff --git a/www/manager6/qemu/Netw
On 2/10/22 14:53, Aaron Lauterer wrote:
Looks good AFAICT and does what we want.
We could improve it further by adding a small validator. Otherwise the user
will only notice their error once they get the error msg from the API.
A quick way that I came up with that could potentially be done b
On Thu, Feb 10, 2022 at 02:53:19PM +0100, Aaron Lauterer wrote:
> Looks good AFAICT and does what we want.
>
> We could improve it further by adding a small validator. Otherwise the user
> will only notice their error once they get the error msg from the API.
>
> A quick way that I came up with
On 2/10/22 15:08, Oguz Bektas wrote:
thanks for the test and review!
instead of a validator function i guess we could just set minValue and
maxValue as well? (since allowBlank is set to true)
seemed to work fine in my short testing just now :)
diff --git a/www/manager6/qemu/NetworkEdit.js
we already have the 'mtu' option in the API, so we can just expose
that option inside the 'Advanced' menu for virtio network interfaces.
Reviewed-By: Aaron Lauterer
Tested-By: Aaron Lauterer
Tested-By: Dylan Whyte
Signed-off-by: Oguz Bektas
---
v2->v3:
* use minValue and maxValue for validatin
by adding an optional parameter 'encode' (enabled by default). When it
is disabled, the content must be base64 encoded already. This
way, users can send a binary file to the vm by base64 encoding it
themselves
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu/Agent.pm | 20 ++--
1
On 10.02.22 10:33, Dominik Csapak wrote:
> this patch adds a check for the guests status, and show a start button
> instead of connecting to a non-started guest
>
> this should reduce confusion when a guest is not running, and also
> reduce the number of false-positive failed console tasks
>
> Si
see individual patches for in-depth review of changes, some broader
remarks:
- I am missing info about parts you looked at but left as-is (and
rationale for why those parts stay root only)
- especially relevant would be a list of currently
unqualified/root-only-by-default API endpoints and a
this needs a rebase anyhow, I reviewed it on HEAD~3 where it still
applies ;)
there's one check for 'root@pam' that looks okay
same for the one in the move disk API endpoint
it might be worth it to mention that you checked those and not switched
them to superuser since they are only a shortcut
On February 8, 2022 2:10 pm, Oguz Bektas wrote:
> 'root@pam' has the privilege by default (since it's an SA), so we can
> drop the string comparisons all around and check that privilege instead
> when deciding to enable/disable buttons or views
>
> Signed-off-by: Oguz Bektas
> ---
> www/manager6
On February 8, 2022 2:10 pm, Oguz Bektas wrote:
> this way we can allow non-root users to act as a SU on specific
> root-only API paths by giving them the built-in SA role or a custom role
> with the SU privilege included.
>
> Signed-off-by: Oguz Bektas
> ---
> src/PVE/API2/LXC.pm| 13 ++
On February 8, 2022 2:10 pm, Oguz Bektas wrote:
> users with the SU privilege are able to override the existing check for
> 'root@pam' when calling tfa-related endpoints of the API.
>
> Signed-off-by: Oguz Bektas
> ---
> src/PVE/API2/TFA.pm | 7 +--
> 1 file changed, 5 insertions(+), 2 delet
On 10.02.22 15:52, Dominik Csapak wrote:
> by adding an optional parameter 'encode' (enabled by default). When it
> is disabled, the content must be base64 encoded already. This
> way, users can send a binary file to the vm by base64 encoding it
> themselves
>
> Signed-off-by: Dominik Csapak
> --
On 2/10/22 16:31, Thomas Lamprecht wrote:
On 10.02.22 15:52, Dominik Csapak wrote:
by adding an optional parameter 'encode' (enabled by default). When it
is disabled, the content must be base64 encoded already. This
way, users can send a binary file to the vm by base64 encoding it
themselves
Si
Note that mtu=1 is a special value, it's inherit from the current
bridge mtu value.
(I don't known if it's possible to add some kind of message in the gui
when this value is choose ?)
Thanks for this patch, It's really usefull for vxlan network.
Le jeudi 10 février 2022 à 15:33 +0100, Oguz Bekta
On 22.10.21 08:44, Dominik Csapak wrote:
> we do not need Permissions.Modify on the pool, so remove it like
> we did in
>
> qemu-server 4fc5242 ("fix pool permission checks on create")
>
> Signed-off-by: Dominik Csapak
> ---
> src/PVE/API2/LXC.pm | 1 -
> 1 file changed, 1 deletion(-)
>
>
app
24 matches
Mail list logo
