Re: [pve-devel] [PATCH v3 guest-common 2/3] add tunnel helper module

2022-01-20 Thread Fabian Ebner
Am 19.01.22 um 15:30 schrieb Fabian Grünbichler: On January 3, 2022 1:30 pm, Fabian Ebner wrote: A few nits inline. Am 12/22/21 um 14:52 schrieb Fabian Grünbichler: lifted from PVE::QemuMigrate, abstracting away use-case specific data. Signed-off-by: Fabian Grünbichler --- src/Makefile

Re: [pve-devel] [PATCH v2 qemu-server 0/1] pci: allow override of PCI vendor/device ids

2022-01-20 Thread Dominik Csapak
On 1/18/22 22:38, Nicholas Sherlock wrote: In this version, changed proposed x-pci-device-id names to remove x-pci- prefix to shorten configs, and improved Perl code style, thanks to Dominik Csapak [PATCH v2 qemu-server] pci: allow override of PCI vendor/device ids [PATCH v2 pve-manager] ui: pc

Re: [pve-devel] [PATCH v2 qemu-server 0/1] pci: allow override of PCI vendor/device ids

2022-01-20 Thread Nicholas Sherlock
On Fri, 21 Jan 2022, 4:48 am Dominik Csapak, wrote: > 2 nits left (you could send a v3, or we can fix it up, please > write what you prefer) > > * the commit message should not have lines longer than 70 characters[0] > * and the gettext is not optimal, i'd omit the 'Set ' prefix (sorry i did > n