[pve-devel] [PATCH v10 qemu-server 4/7] image convert: allow block device as source

2022-01-13 Thread Fabian Ebner
Necessary to import from an existing storage using block-device volumes like ZFS. Signed-off-by: Dominic Jäger [split into its own patch] Signed-off-by: Fabian Ebner --- No changes from v9 (except splitting the patch). PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[pve-devel] [RFC v10 qemu-server 7/7] api: create disks: factor out common part from if/else

2022-01-13 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- New in v10. PVE/API2/Qemu.pm | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 8c74ecc..fa6aa9c 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -204,7 +204,7 @@ my $create_disks

[pve-devel] [RFC v10 qemu-server 6/7] api: support VM disk import

2022-01-13 Thread Fabian Ebner
From: Dominic Jäger Extend qm importdisk functionality to the API. Co-authored-by: Fabian Grünbichler Co-authored-by: Dominic Jäger Signed-off-by: Fabian Ebner --- Changes from v9: * Instead of adding an import-sources parameter to the API, use a new import-from property for the disk, tha

[pve-devel] [PATCH v10 qemu-server 2/7] parse ovf: untaint path when calling file_size_info

2022-01-13 Thread Fabian Ebner
Prepare for calling parse_ovf via API, where the -T switch is used. Signed-off-by: Fabian Ebner --- New in v10. PVE/QemuServer/OVF.pm | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer/OVF.pm b/PVE/QemuServer/OVF.pm index 0376cbf..4a0d373 100644 --- a/P

[pve-devel] [PATCH v10 qemu-server 1/7] schema: add pve-volume-id-or-absolute-path

2022-01-13 Thread Fabian Ebner
Signed-off-by: Dominic Jäger [split into its own patch + style fixes] Signed-off-by: Fabian Ebner --- Changes from v9: * Style fixes. PVE/QemuServer.pm | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 0071a06..8

[pve-devel] [PATCH v10 manager 1/1] api: nodes: add readovf endpoint

2022-01-13 Thread Fabian Ebner
Signed-off-by: Dominic Jäger [split into its own patch + add to index] Signed-off-by: Fabian Ebner --- Needs dependency bump for qemu-server. Changes from v9: * Add entry to /node/'s index. PVE/API2/Nodes.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PV

[pve-devel] [PATCH v10 qemu-server 3/7] api: add endpoint for parsing .ovf files

2022-01-13 Thread Fabian Ebner
Co-developed-by: Fabian Grünbichler Signed-off-by: Dominic Jäger [split into its own patch + minor improvements/style fixes] Signed-off-by: Fabian Ebner --- Changes from v9: * Include $! in the error for the file check. * Have json_ovf_properties return all of them rather than just

[pve-devel] [RFC v10 qemu-server 5/7] schema: drive: use separate schema when disk allocation is possible

2022-01-13 Thread Fabian Ebner
via the special syntax :. Not worth it by itself, but this is anticipating a new 'import-from' parameter which is only used upon import/allocation, but shouldn't be part of the schema for the config or other API enpoints. Signed-off-by: Fabian Ebner --- New in v10. PVE/API2/Qemu.pm| 1

[pve-devel] [RFC v10 qemu-server/manager] API for disk import and OVF

2022-01-13 Thread Fabian Ebner
Extend qm importdisk/importovf functionality to the API. Used Dominic's latest version[0] as a starting point. GUI part still needs to be rebased/updated, so it's not included here. Changes from v9: * Split patch into smaller parts * Some minor (style) fixes/improvements (see individual patch

[pve-devel] [PATCH v2 guest-common 1/2] config: remove unused variable

2022-01-13 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- src/PVE/AbstractConfig.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm index 4ea6c80..0c40062 100644 --- a/src/PVE/AbstractConfig.pm +++ b/src/PVE/AbstractConfig.pm @@ -877,8 +877,6 @@ my $snapshot_delet

[pve-devel] [PATCH v2 container 2/3] config: parse_volume: don't die when noerr is set

2022-01-13 Thread Fabian Ebner
AFAICT, the only existing callers using noerr=1 are in __snapshot_delete_remove_drive, and in AbstractConfig's foreach_volume_full. The former should not be affected, as unknown keys should never make their way in there. For the latter, it makes iterating with $opts = { extra_keys => ['vmstate'

[pve-devel] [PATCH v2 guest-common 2/2] config: activate affected storages for snapshot operations

2022-01-13 Thread Fabian Ebner
For snapshot creation, the storage for the vmstate file is activated via vdisk_alloc when the state file is created. Do not activate the volumes themselves, as that has unnecessary side effects (e.g. waiting for zvol device link for ZFS, mapping the volume for RBD). If a storage can only do snapsh

[pve-devel] [PATCH v2 qemu-server 1/1] snapshot: implement __snapshot_activate_storages

2022-01-13 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Build-depends on guest-common. PVE/QemuConfig.pm | 19 +++ .../create/qemu-server/303.conf | 13 +++ .../delete/qemu-server/204.conf | 33 ++ .../rollback/qemu-server/303.conf

[pve-devel] [PATCH v2 container 1/3] config: snapshot_delete_remove_drive: check for parsed value

2022-01-13 Thread Fabian Ebner
parse_volume is called with noerr=1, so this might be undef instead of the hash we expect. Signed-off-by: Fabian Ebner --- src/PVE/LXC/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 6c2acd6..32d990c 100644 --- a/s

[pve-devel] [PATCH-SERIES v2 guest-common/qemu-server/container] activate storages for snapshot operations

2022-01-13 Thread Fabian Ebner
to make it work when the storage is just not active yet, and have early errors when the storage cannot be activated. Also prohibits snapshot operations when an involved storage is disabled, but otherwise available. Both qemu-server and pve-container build-depend upon pve-guest-common for the adde

[pve-devel] [PATCH v2 container 3/3] snapshot: implement __snapshot_activate_storages

2022-01-13 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Build depends on guest-common. src/PVE/LXC/Config.pm | 19 +++ .../snapshot-expected/create/lxc/204.conf | 10 ++ .../snapshot-expected/delete/lxc/204.conf | 25 +++ .../snapshot-expected/rollback/lxc/209.co

Re: [pve-devel] [PATCH-SERIES v2 storage/widget-toolkit/manager] fix #3610: properly build ZFS detail tree

2022-01-13 Thread Fabian Ebner
Ping for the widget-toolkit and manager patches. Am 10.09.21 um 13:45 schrieb Fabian Ebner: Correctly add top-level vdevs like log or special as children of the root, instead of the previous outer vdev. Since the API returns only one element, it has to be the pool itself, but there also is a vd

[pve-devel] applied-series: [PATCH-SERIES v2 storage/widget-toolkit/manager] fix #3610: properly build ZFS detail tree

2022-01-13 Thread Thomas Lamprecht
On 13.01.22 12:21, Fabian Ebner wrote: > Ping for the widget-toolkit and manager patches. > applied remaining parts of this series, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-d

[pve-devel] applied: [PATCH manager] add 'auto' mode for noVNC scaling

2022-01-13 Thread Thomas Lamprecht
On 13.01.22 08:56, Dominik Csapak wrote: > in commit > 69c6561f820b4fdb5625ead767889155db9f1539 ("ui: fix novnc scaling radio > button") > > we always set to 'scale' when no value was set, but a non-set value > actually had a different behaviour: > > in the embedded console it was set to 'scale'

[pve-devel] applied-series: [PATCH zfsonlinux/stable-6 0/2] update zfs to 2.0.7

2022-01-13 Thread Thomas Lamprecht
On 11.01.22 16:02, Stoiko Ivanov wrote: > 2.0.7 contains a few commits which might affect our users e.g.: > `ZFS send/recv with ashift 9->12 leads to data corruption` > > the second commit is a cherry-pick from our current master > (abigail failures should not cause the build to abort) > > built

[pve-devel] applied: [PATCH http-server] fix #3807: don't attempt response on closed handle

2022-01-13 Thread Thomas Lamprecht
On 29.12.21 12:15, Fabian Grünbichler wrote: > if a client closes the connection while the API server is > waiting/stalling here, the handle will disappear, and sending a response > is no longer possible. > > (this issue is only cosmetic, but if such clients are a regular > occurrence it might get

[pve-devel] partially-applied-series: [PATCH http-server/manager/pmg-api/docs 0/10] expose more TLS knobs

2022-01-13 Thread Thomas Lamprecht
On 17.12.21 13:57, Fabian Grünbichler wrote: > this series adds the following options to /etc/default/$proxy, and > corresponding handling in pveproxy/pmgproxy/api-server: > > - TLS 1.3 ciphersuites (these are different to < 1.3 cipher lists) > - disable TLS 1.2 / disable TLS 1.3 option (rest are

[pve-devel] applied: [PATCH widget-toolkit 1/1] window: safe destroy: make note more visible

2022-01-13 Thread Thomas Lamprecht
On 13.12.21 09:25, Fabian Ebner wrote: > by not using a smaller font size and using the pmx-hint class. Also > don't align to the middle, as everything else is left-aligned. > > Signed-off-by: Fabian Ebner > --- > > AFAICT, the only current user is datastore deletion in PBS and IMHO > it doesn't

[pve-devel] applied-series: [PATCH proxmox-perl-rs/common] use calendar-events from rust

2022-01-13 Thread Thomas Lamprecht
On 01.12.21 09:55, Dominik Csapak wrote: > this series replaces the perl calendar event implementation with the > one in rust, using proxmox-perl-rs > > the perl interface to 'PVE::CalendarEvent' is the same, but we could > use PVE::RS::CalendarEvent directly downstream (guest-common/manager) > bu

[pve-devel] applied-series: [PATCH pve-common 0/4] improve host read_proc_stat

2022-01-13 Thread Thomas Lamprecht
On 10.01.22 05:52, Alexandre Derumier wrote: > This patch series improve current host cpu stats > > > Alexandre Derumier (4): > read_proc_stat : initialize newer fields to 0 > read_proc_stat: substract guest && guest_nice from user && nice time > read_proc_stat: add irq/softirq/steal to tot

[pve-devel] applied: [PATCH manager 1/1] window: safe destroy guest: add note that referenced disks are destroyed

2022-01-13 Thread Thomas Lamprecht
On 13.12.21 09:25, Fabian Ebner wrote: > It's not clear to all users otherwise[0]. > > [0]: https://forum.proxmox.com/threads/100996/post-436919 > > Signed-off-by: Fabian Ebner > --- > www/manager6/window/SafeDestroyGuest.js | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks! ___

Re: [pve-devel] [PATCH common 1/1] CalendarEvent: use rust implementation

2022-01-13 Thread Thomas Lamprecht
On 01.12.21 09:55, Dominik Csapak wrote: > by replacing the parsing code and 'compute_next_event' by their > PVE::RS::CalendarEvent equivalent > > adapt the tests, since we do not have access to the internal structure > (and even if we had, it would be different) and the error messages > are diffe

[pve-devel] applied: [PATCH docs] pveproxy: document newly added options

2022-01-13 Thread Thomas Lamprecht
On 17.12.21 13:57, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > pveproxy.adoc | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) > > applied this and the manager part, thanks! I did not address any of the nits mentioned by stoiko (th

[pve-devel] [PATCH v3 qemu-server 1/3] vmstatus: add hostcpu value

2022-01-13 Thread Alexandre Derumier
--- PVE/QemuServer.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 0071a06..65115ba 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2877,8 +2877,11 @@ sub vmstatus { my $pstat = PVE::ProcFSTools::read_proc_pid_sta

[pve-devel] [PATCH v3 qemu-server 2/3] vmstatus: add hostmem value

2022-01-13 Thread Alexandre Derumier
--- PVE/QemuServer.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 65115ba..6d4027b 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2888,6 +2888,11 @@ sub vmstatus { if ($pstat->{vsize}) { $d->{mem} = int(($psta

[pve-devel] [PATCH v3 qemu-server 3/3] vmstatus: add pressure stats

2022-01-13 Thread Alexandre Derumier
--- PVE/QemuServer.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 6d4027b..e4b6765 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2926,6 +2926,8 @@ sub vmstatus { $d->{cpu} = $old->{cpu}; $d->{hostcpu} = $old

[pve-devel] [PATCH v3 qemu-server 0/3] vmstatus: add pressure + hostcpu/hostmem

2022-01-13 Thread Alexandre Derumier
Hi,this is a resend of patches from last year. vm pressure stats && true host cpu/mem usage is really needed to implement correct balancing. This add new cgroups value stats. hostcpu/hostmem give the real cpu/mem usage of a vm, including vhost-net. Changelog v3: - rebase on last master C