Re: [pve-devel] [PATCH pve_flutter_frontend] workaround for novnc fullscreen behaviour

2021-12-21 Thread Aaron Lauterer
On 12/20/21 20:55, Thomas Lamprecht wrote: On 20/12/2021 14:57, Aaron Lauterer wrote: Tested-By: Aaron Lauterer how did you test this if the noVNC patch from Dominik is broken? Tested the "open in full screen" part of it all, which works with or without the noVNC patches. Meaning, whil

Re: [pve-devel] [PATCH novnc] add patches to workaround fullscreen issue in android app

2021-12-21 Thread Thomas Lamprecht
On 21/12/2021 08:05, Dominik Csapak wrote: > On 12/20/21 20:53, Thomas Lamprecht wrote: >> On 20/12/2021 12:33, Dominik Csapak wrote: >>> patch 15 hides the fullscreen button, >>> patch 16 make the error message dismissable >>> >> >> this seems broken? >> >> The d/patches/series file gets 16 and 17

Re: [pve-devel] [PATCH futter_frontend 1/2] fix android splash screen logo

2021-12-21 Thread Aaron Lauterer
On 12/20/21 20:21, Thomas Lamprecht wrote: On 20/12/2021 16:38, Aaron Lauterer wrote: The new splash screen that came with Android 12 has stricter rules regarding the size and form of the logo in the splash screen [0]. We do need to have a drawable that is a square with the logo / icon in th

Re: [pve-devel] [PATCH futter_frontend 1/2] fix android splash screen logo

2021-12-21 Thread Aaron Lauterer
On 12/20/21 20:37, Thomas Lamprecht wrote: On 20/12/2021 16:38, Aaron Lauterer wrote: The new splash screen that came with Android 12 has stricter rules regarding the size and form of the logo in the splash screen [0]. oh, do you have an actual reference to the strict rules you found, as [0

Re: [pve-devel] [PATCH futter_frontend 1/2] fix android splash screen logo

2021-12-21 Thread Thomas Lamprecht
On 21/12/2021 10:27, Aaron Lauterer wrote: > On 12/20/21 20:37, Thomas Lamprecht wrote: >> On 20/12/2021 16:38, Aaron Lauterer wrote: >>> The new splash screen that came with Android 12 has stricter rules >>> regarding the size and form of the logo in the splash screen [0]. >> >> oh, do you have an

[pve-devel] applied-series: [PATCH novnc 0/4] upgrade novnc to 1.3.0

2021-12-21 Thread Thomas Lamprecht
On 17/12/2021 11:19, Dominik Csapak wrote: > we just have to bump again if we want to > > Dominik Csapak (4): > upgrade novnc to 1.3.0 > rebase patches for 1.3.0 > add patch for proper hiding of buttons > use esbuild instead of node-es6-module-transpiler > > debian/control

[pve-devel] applied: Re: [PATCH novnc] add patches to workaround fullscreen issue in android app

2021-12-21 Thread Thomas Lamprecht
On 20/12/2021 12:33, Dominik Csapak wrote: > patch 15 hides the fullscreen button, > patch 16 make the error message dismissable > > Signed-off-by: Dominik Csapak > --- > ...-button-on-isFullscreen-get-variable.patch | 39 +++ > debian/patches/0017-make-error-hideable.patch | 47

[pve-devel] applied: Re: [PATCH manager] status: influxdb: suppress warning when no token exists

2021-12-21 Thread Thomas Lamprecht
On 20/12/2021 13:43, Dominik Csapak wrote: > in get_credentials, we try to read the token for the specified server, > and warn if we cannot do that (e.g. because the file does not exist) > > since having no token is a valid configuration, suppress that warning on > connection. > > reported by a f

[pve-devel] applied: Re: [PATCH qemu-server] fix #3792: cloudinit: use of uninitialized value

2021-12-21 Thread Thomas Lamprecht
On 20/12/2021 15:03, Mira Limbeck wrote: > With the patch adding vendor-data support to cloud-init, a use of > uninitialized value was introduced. This can be fixed by setting it to > an empty string if no vendor-data is defined. > > vendor-data can only be set via --cicustom and is optional. > >

Re: [pve-devel] [PATCH-SERIES storage/manager/guest-common/docs] improvements for protected backups

2021-12-21 Thread Thomas Lamprecht
On 20/12/2021 11:31, Dominik Csapak wrote: > what do we gain by having a limit on the number of protected backups? We avoid allowing users to create an infinite number of backups. Remember that unprotected backups do not count towards the keep-X retention parameters as they are considered a speci

[pve-devel] [PATCH V3 pve-ha-manager 0/2] POC/RFC: ressource aware HA manager

2021-12-21 Thread Alexandre Derumier
Hi, this is a proof of concept to implement ressource aware HA. The current implementation is really basic, simply balancing the number of services on each node. I had some real production cases, where a node is failing, and restarted vm impact others nodes because of too much cpu/ram usage. C

[pve-devel] [PATCH V3 pve-ha-manager 1/2] add ressource awareness manager

2021-12-21 Thread Alexandre Derumier
his new implementation use best-fit heuristic vector packing with constraints support. - We compute nodes memory/cpu, and vm memory/cpu average stats on last 20min For each ressource : - First, we ordering pending recovery state services by memory, then cpu usage. Memory is more important her

[pve-devel] [PATCH V3 pve-ha-manager 2/2] add test-basic0

2021-12-21 Thread Alexandre Derumier
--- src/test/test-basic0/README | 1 + src/test/test-basic0/cmdlist | 4 +++ src/test/test-basic0/hardware_status | 5 +++ src/test/test-basic0/log.expect | 52 src/test/test-basic0/manager_status | 1 + src/test/test-basic0/node_stats |

[pve-devel] [PATCH v2 flutter_frontend] fix android splash screen logo

2021-12-21 Thread Aaron Lauterer
The new Android 12 splash screen will mask the logo / icon. See figure 2 in [0]. This resulted in the current logo being cut off by the circular mask, appearing broken. I created a new version, based on the stacked variant accounting for the additional space around the logo needed for the mask. It

Re: [pve-devel] [PATCH-SERIES storage/manager/guest-common/docs] improvements for protected backups

2021-12-21 Thread Dominik Csapak
On 12/21/21 16:11, Thomas Lamprecht wrote: On 20/12/2021 11:31, Dominik Csapak wrote: what do we gain by having a limit on the number of protected backups? We avoid allowing users to create an infinite number of backups. Remember that unprotected backups do not count towards the keep-X retent