[pve-devel] [PATCH proxmox-backup-qemu 1/2] update deps to pbs 2.1.1

2021-11-24 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- on top of the patch by dietmar Cargo.toml | 14 +++--- src/backup.rs | 2 +- src/lib.rs | 2 +- src/restore.rs | 3 ++- 4 files changed, 11 insertions(+), 10 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index d9a7de1..b98e8ae 100644

[pve-devel] [PATCH proxmox-backup-qemu 2/2] fix clippy warnings

2021-11-24 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- src/commands.rs | 10 ++ src/restore.rs | 2 +- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/commands.rs b/src/commands.rs index c2a1abb..16dc63f 100644 --- a/src/commands.rs +++ b/src/commands.rs @@ -133,7 +133,7 @@ pub(crate)

[pve-devel] applied-series: [PATCH widget-toolkit v2 0/2] improve logpanel behaviour for fast tasks

2021-11-24 Thread Thomas Lamprecht
On 23.11.21 13:02, Dominik Csapak wrote: > improves the handling of fast moving tasks > * no glitching > * catching up to the end of the task log > > changes from v1: > * dropped 3/3 (different approach makes it obsolete) > * set the length to total when we really need it > * decouple updating the

[pve-devel] applied: [PATCH widget-toolkit] ui: journalview: fix wrong first load with timespan

2021-11-24 Thread Thomas Lamprecht
On 23.11.21 10:49, Dominik Csapak wrote: > calling updateParams here lead to making an api call with the default > timespan (last 3 days) on pbs/pmg when going to the 'administration' > panel, even though it would never be shown since on tab activate we would > show the 'live mode' which does not u

[pve-devel] [PATCH http-server 1/1] http-server: let the api call decide the content-encoding

2021-11-24 Thread Dominik Csapak
this is useful if we want to pipe the output of a program e.g. through gzip Signed-off-by: Dominik Csapak --- src/PVE/APIServer/AnyEvent.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm index c159b8d..31556ce 100644 --- a/src

[pve-devel] [PATCH mini-journalreader/http-server/manager] optimize journal api cal

2021-11-24 Thread Dominik Csapak
this series changes the 'journal' api call to stream the journal to the client, which reduces the memory footprint of the worker processes for very big logs, the web ui may struggle (depending on browser/cpu/etc.). if that turns out to be a common problem, we can further optimize to pagination if

[pve-devel] [PATCH mini-journalreader 1/1] add '-j' flag to output json

2021-11-24 Thread Dominik Csapak
in the format: {"data":[... log lines ...],"success":1} this is chosen so that we can achieve api compatibility when we stream this output to an api client strings are escaped by replacing '"', '\' and all values <= 0x1F by their \u representation invalid utf8 sequences will be returned as t

[pve-devel] [PATCH manager 1/1] api: journal: stream the journal data to the client

2021-11-24 Thread Dominik Csapak
instead of accumulating the whole output of 'mini-journalreader' in the api call (this can be quite big), use the download mechanic of the http-server to stream the output to the client. we lose some error handling possibilities, but we do not have to allocate anything here, and since perl does no

[pve-devel] applied: [PATCH mini-journalreader 1/1] add '-j' flag to output json

2021-11-24 Thread Thomas Lamprecht
On 24.11.21 15:47, Dominik Csapak wrote: > in the format: > {"data":[... log lines ...],"success":1} > > this is chosen so that we can achieve api compatibility when we stream > this output to an api client > > strings are escaped by replacing '"', '\' and all values <= 0x1F by their > \u rep

[pve-devel] applied: [PATCH http-server 1/1] http-server: let the api call decide the content-encoding

2021-11-24 Thread Thomas Lamprecht
On 24.11.21 15:47, Dominik Csapak wrote: > this is useful if we want to pipe the output of a program e.g. through gzip > > Signed-off-by: Dominik Csapak > --- > src/PVE/APIServer/AnyEvent.pm | 3 +++ > 1 file changed, 3 insertions(+) > > applied, thanks! (and congrats to causing the 4.0-4 rele

Re: [pve-devel] [PATCH manager 1/1] api: journal: stream the journal data to the client

2021-11-24 Thread Stoiko Ivanov
Huge thanks for addressing this so quickly and elegantly! One question/nit: On Wed, 24 Nov 2021 15:47:48 +0100 Dominik Csapak wrote: > instead of accumulating the whole output of 'mini-journalreader' in > the api call (this can be quite big), use the download mechanic of the > http-server to st

[pve-devel] applied: [PATCH manager 1/1] api: journal: stream the journal data to the client

2021-11-24 Thread Thomas Lamprecht
On 24.11.21 15:47, Dominik Csapak wrote: > instead of accumulating the whole output of 'mini-journalreader' in > the api call (this can be quite big), use the download mechanic of the > http-server to stream the output to the client. > > we lose some error handling possibilities, but we do not hav

Re: [pve-devel] [PATCH manager 1/1] api: journal: stream the journal data to the client

2021-11-24 Thread Thomas Lamprecht
On 24.11.21 18:32, Stoiko Ivanov wrote: > Huge thanks for addressing this so quickly and elegantly! > > One question/nit: > > On Wed, 24 Nov 2021 15:47:48 +0100 > Dominik Csapak wrote: > >> instead of accumulating the whole output of 'mini-journalreader' in >> the api call (this can be quite bi

Re: [pve-devel] [PATCH manager 1/1] api: journal: stream the journal data to the client

2021-11-24 Thread Stoiko Ivanov
On Wed, 24 Nov 2021 18:46:04 +0100 Thomas Lamprecht wrote: > On 24.11.21 18:32, Stoiko Ivanov wrote: > > Huge thanks for addressing this so quickly and elegantly! > > > > One question/nit: > > > > On Wed, 24 Nov 2021 15:47:48 +0100 > > Dominik Csapak wrote: > > > >> instead of accumulating