[pve-devel] [PATCH manager] ui: calendar event: fix descriptions for examples

2021-11-11 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- www/manager6/form/CalendarEvent.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/form/CalendarEvent.js b/www/manager6/form/CalendarEvent.js index 087f2fbb..58090ddb 100644 --- a/www/manager6/form/CalendarEvent.js +++ b/www/ma

[pve-devel] applied: [PATCH qemu-server] disk reassign: add unused disks directly to config

2021-11-11 Thread Fabian Grünbichler
On November 10, 2021 6:00 pm, Aaron Lauterer wrote: > Using $update_vm_api for unused disks will cause them to end up as a > pending change if the VM is running. > > Signed-off-by: Aaron Lauterer > --- > That case is already handled for containers but was missed for VMs. > > PVE/API2/Qemu.pm |

[pve-devel] applied: [PATCH manager] ui: calendar event: fix descriptions for examples

2021-11-11 Thread Thomas Lamprecht
On 11.11.21 10:00, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > www/manager6/form/CalendarEvent.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! fwiw, the `Month` spelling was copied over from the pbs docs :)

[pve-devel] applied: [PATCH qemu-server] cfg2cmd: turn smm off when SeaBIOS and serial display are used

2021-11-11 Thread Thomas Lamprecht
On 05.11.21 14:06, Fabian Ebner wrote: > Since commit 277d33454f77ec1d1e0bc04e37621e4dd2424b67 in pve-qemu, > smm=off is no longer the default, but with SeaBIOS and serial display, > this can lead to a boot loop. > > Reported in the community forum [0] and reproduced with a Debian 10 > VM. > > [0

Re: [pve-devel] [PATCH proxmox-websocket-tunnel 2/4] add tunnel implementation

2021-11-11 Thread Fabian Grünbichler
On November 9, 2021 1:54 pm, Dominik Csapak wrote: > looks mostly fine, some comments inline thanks! > On 11/5/21 14:03, Fabian Grünbichler wrote: >> the websocket tunnel helper accepts control commands (encoded as >> single-line JSON) on stdin, and prints responses on stdout. >> >> the followin

[pve-devel] applied: [PATCH kernel-meta] boot-tool: fix whitespace in generated loader configuration

2021-11-11 Thread Thomas Lamprecht
On 10.11.21 14:07, Oguz Bektas wrote: > issue reported in forum [0] > > seems like it came in with 2a8a4b5e37e87a0a994fe3820b015e051e6259fb > > [0]: https://forum.proxmox.com/threads/problem-with-proxmox-boot-tool.99043/ > > before: > > $ cat /mnt/foo/loader/entries/proxmox-5.11.22-7-pv

[pve-devel] applied: [PATCH pve-kernel-meta v2] proxmox-boot: read only first line of /etc/kernel/cmdline

2021-11-11 Thread Thomas Lamprecht
On 10.11.21 16:25, Stoiko Ivanov wrote: > following the commit of removing the wrong indentation of the linux > and initrd lines - this commit strips empty lines (and leading > trailing whitespace) in /etc/kernel/cmdline. > > I managed to reproduce the issue reported in the forum [0] by adding > e

Re: [pve-devel] [PATCH pve-common 0/2] add disable bridge learning feature

2021-11-11 Thread Thomas Lamprecht
On 24.09.21 10:48, Alexandre Derumier wrote: > Currently, if bridge receive an unknown dest mac (network bug/attack/..), > we are flooding packets to all bridge ports. > > This can waste cpu time, even more with firewall enabled. > Also, if firewall is used with reject action, the src mac of RST >

Re: [pve-devel] [PATCH pve-common 0/2] add disable bridge learning feature

2021-11-11 Thread Josef Johansson
On 11/11/21 11:40, Thomas Lamprecht wrote: > On 24.09.21 10:48, Alexandre Derumier wrote: >> Currently, if bridge receive an unknown dest mac (network bug/attack/..), >> we are flooding packets to all bridge ports. >> >> This can waste cpu time, even more with firewall enabled. >> Also, if firewall

Re: [pve-devel] [PATCH qemu-server 07/10] mtunnel: add API endpoints

2021-11-11 Thread Fabian Grünbichler
On November 9, 2021 1:46 pm, Fabian Ebner wrote: > Am 05.11.21 um 14:03 schrieb Fabian Grünbichler: >> the following two endpoints are used for migration on the remote side >> >> POST /nodes/NODE/qemu/VMID/mtunnel >> >> which creates and locks an empty VM config, and spawns the main qmtunnel >> w

[pve-devel] [PATCH manager 2/5] ui: dc/Backup: fix comment sort

2021-11-11 Thread Dominik Csapak
without this, jobs without comments will not be included in the sort properly Signed-off-by: Dominik Csapak --- www/manager6/dc/Backup.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index 3f250a76..c25a127e 100644 --- a/www/manager6/d

[pve-devel] [PATCH docs 3/3] add pvescheduler docs and manpage

2021-11-11 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- pve-admin-guide.adoc | 18 ++ pvescheduler.adoc| 33 + 2 files changed, 51 insertions(+) create mode 100644 pvescheduler.adoc diff --git a/pve-admin-guide.adoc b/pve-admin-guide.adoc index b32b55b..d0a1637 100

[pve-devel] [PATCH manager 5/5] remove pvescheduler manpage generation

2021-11-11 Thread Dominik Csapak
pve-docs-generator does this now Signed-off-by: Dominik Csapak --- bin/Makefile | 4 1 file changed, 4 deletions(-) diff --git a/bin/Makefile b/bin/Makefile index 12cb4671..fb475be3 100644 --- a/bin/Makefile +++ b/bin/Makefile @@ -52,10 +52,6 @@ pve6to7.1: printf ".TH PVE6TO7 1\n.S

[pve-devel] [PATCH manager 4/5] ui: dc/Backup: add schedule simulator button

2021-11-11 Thread Dominik Csapak
so that a user can simply simulate the schedule Signed-off-by: Dominik Csapak --- www/manager6/Makefile| 1 + www/manager6/dc/Backup.js| 15 +++ www/manager6/window/ScheduleSimulator.js | 118 +++ 3 files changed, 134 insertions(+) crea

[pve-devel] [PATCH docs 1/3] refactor calendar events into appendix

2021-11-11 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- calendar-events.adoc | 73 pvesr.adoc | 72 ++- 2 files changed, 75 insertions(+), 70 deletions(-) create mode 100644 calendar-events.adoc diff --git a/calendar-event

[pve-devel] [PATCH docs 2/3] vzdump: change vzdump.cron to pvescheduler

2021-11-11 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- vzdump.adoc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vzdump.adoc b/vzdump.adoc index a2b908d..96ae70d 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -49,7 +49,10 @@ archiving. Backup jobs can be scheduled so that they are executed a

[pve-devel] [PATCH manager 1/5] ui: dc/Backup: never show id input field, autogenerate id

2021-11-11 Thread Dominik Csapak
similar to pbs sync jobs Signed-off-by: Dominik Csapak --- www/manager6/dc/Backup.js | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index e33f5e27..3f250a76 100644 --- a/www/manager6/dc/Backup.js +

[pve-devel] [PATCH docs/manager] add pvescheduler docs, improve vzdump job gui

2021-11-11 Thread Dominik Csapak
* adds the pvescheduler manpage to pve-docs (not sure about the transition here regarding dependcies, hope it's ok this way) * mentions the schedules in vzdump too * hide the id on create/edit completely (autogenerate it) * add a 'simulate' api and gui for simulating schedules pve-docs: Dominik

[pve-devel] [PATCH manager 3/5] api: cluster: add jobs/schedule-analyze api call

2021-11-11 Thread Dominik Csapak
a simple api call to simulate calendar event triggers takes a schedule, an optional number (default 10), an optional starttime (default 'now') and returns a list with unix timestamps, as well as humanly readable utc timestamps. Signed-off-by: Dominik Csapak --- PVE/API2/Cluster.pm | 5 ++

Re: [pve-devel] [PATCH qemu-server 07/10] mtunnel: add API endpoints

2021-11-11 Thread Fabian Grünbichler
On November 10, 2021 8:40 am, Fabian Ebner wrote: > Am 09.11.21 um 13:46 schrieb Fabian Ebner: >> Am 05.11.21 um 14:03 schrieb Fabian Grünbichler: > > ---snip--- > >>>   use IO::Socket::IP; >>> +use IO::Socket::UNIX; >>> +use IPC::Open3; >>> +use JSON; >>> +use MIME::Base64; > > Forgot to ask: i

Re: [pve-devel] [PATCH cluster/manager v2] add scheduling daemon for pvesr + vzdump (and more)

2021-11-11 Thread Fabian Ebner
Am 08.11.21 um 14:07 schrieb Dominik Csapak: with this series, we implement a new daemon (pvescheduler) that takes over from pvesrs' systemd timer (original patch from thomas[0]) and extends it with a generic job handling mechanism then i convert the vzdump cron jobs to these jobs, the immediate

Re: [pve-devel] [PATCH cluster/manager v2] add scheduling daemon for pvesr + vzdump (and more)

2021-11-11 Thread Dominik Csapak
On 11/11/21 12:35, Fabian Ebner wrote: Am 08.11.21 um 14:07 schrieb Dominik Csapak: with this series, we implement a new daemon (pvescheduler) that takes over from pvesrs' systemd timer (original patch from thomas[0]) and extends it with a generic job handling mechanism then i convert the vzdum

[pve-devel] [PATCH manager] ui: dc/Backup: fix 'run now' button for jobs with comments

2021-11-11 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/dc/Backup.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index 31600817..e56174a5 100644 --- a/www/manager6/dc/Backup.js +++ b/www/manager6/dc/Backup.js @@ -536,6 +536,7 @@ Ext.define('PVE

[pve-devel] [PATCH qemu-server] cfg2cmd: also set smm=off for "none" type display

2021-11-11 Thread Oguz Bektas
issue reported in community forum [0] like "serial[n]" display we also need to set this option for "none", otherwise we get a boot loop like in [1]. [0]: https://forum.proxmox.com/threads/debian-vms-wont-start-anymore.99508 [1]: https://forum.proxmox.com/threads/pve-7-0-all-vms-with-cloud-init-s

[pve-devel] [PATCH manager] ui: form/CalendarEvent: remove 'first saturday each month' example

2021-11-11 Thread Dominik Csapak
this is currently not supported by calendarevents in pve Signed-off-by: Dominik Csapak --- www/manager6/form/CalendarEvent.js | 1 - 1 file changed, 1 deletion(-) diff --git a/www/manager6/form/CalendarEvent.js b/www/manager6/form/CalendarEvent.js index 58090ddb..a15ec24f 100644 --- a/www/mana

Re: [pve-devel] [PATCH qemu-server 09/10] migrate: add remote migration handling

2021-11-11 Thread Fabian Grünbichler
On November 10, 2021 12:17 pm, Fabian Ebner wrote: > Am 05.11.21 um 14:03 schrieb Fabian Grünbichler: >> remote migration uses a websocket connection to a task worker running on >> the target node instead of commands via SSH to control the migration. >> this websocket tunnel is started earlier than

Re: [pve-devel] [PATCH manager] ui: form/CalendarEvent: remove 'first saturday each month' example

2021-11-11 Thread Thomas Lamprecht
On 11.11.21 13:09, Dominik Csapak wrote: > this is currently not supported by calendarevents in pve > the obvious questions arises: why not support it instead? ^^ > Signed-off-by: Dominik Csapak > --- > www/manager6/form/CalendarEvent.js | 1 - > 1 file changed, 1 deletion(-) > > diff --git a

Re: [pve-devel] [PATCH qemu-server 10/10] api: add remote migrate endpoint

2021-11-11 Thread Fabian Grünbichler
On November 10, 2021 1:29 pm, Fabian Ebner wrote: > Am 05.11.21 um 14:03 schrieb Fabian Grünbichler: >> Signed-off-by: Fabian Grünbichler >> --- >> >> Notes: >> the checks currently done before the actual migration worker is >> forked could be either moved to the client calling this (th

Re: [pve-devel] [PATCH qemu-server 09/10] migrate: add remote migration handling

2021-11-11 Thread Fabian Ebner
Am 11.11.21 um 13:25 schrieb Fabian Grünbichler: On November 10, 2021 12:17 pm, Fabian Ebner wrote: Am 05.11.21 um 14:03 schrieb Fabian Grünbichler: # set environment variable useful inside network script -$ENV{PVE_MIGRATED_FROM} = $migratedfrom if $migratedfrom; +if ($migrat

Re: [pve-devel] [PATCH qemu-server] cfg2cmd: also set smm=off for "none" type display

2021-11-11 Thread Fabian Ebner
Am 11.11.21 um 13:05 schrieb Oguz Bektas: issue reported in community forum [0] like "serial[n]" display we also need to set this option for "none", otherwise we get a boot loop like in [1]. [0]: https://forum.proxmox.com/threads/debian-vms-wont-start-anymore.99508 [1]: https://forum.proxmox.c

[pve-devel] applied: [PATCH common 3/3] schema: add proxmox-remote format/option

2021-11-11 Thread Thomas Lamprecht
On 05.11.21 14:03, Fabian Grünbichler wrote: > for usage in remote migration/replication. > > Signed-off-by: Fabian Grünbichler > --- > src/PVE/JSONSchema.pm | 27 +++ > 1 file changed, 27 insertions(+) > > applied, thanks!

[pve-devel] applied: [PATCH common 1/3] schema: rename storagepair to storage-pair

2021-11-11 Thread Thomas Lamprecht
On 05.11.21 14:03, Fabian Grünbichler wrote: > more consistent with the other options/formats like pve-storage-id > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > v2: new > > this breaks older qemu-server without the patch adapting to the new name > > src/PVE/JSONSchema.pm

[pve-devel] applied: [PATCH qemu-server 01/10] d/control: add pve-ha-manager to B-D

2021-11-11 Thread Thomas Lamprecht
On 05.11.21 14:03, Fabian Grünbichler wrote: > it's needed for tests to succeed. > > Signed-off-by: Fabian Grünbichler > --- > debian/control | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.pr

[pve-devel] applied: [PATCH qemu-server 02/10] adapt to renamed storage-pair format

2021-11-11 Thread Thomas Lamprecht
On 05.11.21 14:03, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > > Notes: > v2: new > > requires bumped dependency on pve-common with renaming patch > > PVE/QemuServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! __

[pve-devel] applied: [PATCH common 2/3] schema: add pve-bridge-id option/format/pair

2021-11-11 Thread Thomas Lamprecht
On 05.11.21 14:03, Fabian Grünbichler wrote: > for re-use in qemu-server/pve-container, which already have this option > duplicated. the '-pair' is needed for remote migration, but can also be > a nice addition to regular intra-cluster migration to lift the > restriction of having identically named

[pve-devel] applied: [PATCH qemu-server 03/10] migrate: factor out storage checks

2021-11-11 Thread Thomas Lamprecht
On 05.11.21 14:03, Fabian Grünbichler wrote: > to re-use them for incoming remote migrations. > > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Qemu.pm | 26 ++ > 1 file changed, 14 insertions(+), 12 deletions(-) > > applied, thanks! _

[pve-devel] [PATCH v2 proxmox-websocket-tunnel 1/4] initial commit

2021-11-11 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- .gitignore| 1 + .cargo/config | 5 + Cargo.toml| 11 +++ 3 files changed, 17 insertions(+) create mode 100644 .gitignore create mode 100644 .cargo/config create mode 100644 Cargo.toml diff --git a/.gitignore b/.gitignore new file mo

[pve-devel] [PATCH v2 http-server 1/1] webproxy: handle unflushed write buffer

2021-11-11 Thread Fabian Grünbichler
for proxied requests, we usually tear down the proxy connection immediately when closing the source connection. this is not the correct course of action for bulk one-way data streams that are proxied, where the source connection might be closed, but the proxy connection might still have data in the

[pve-devel] [PATCH v2 qemu-server 1/8] refactor map_storage to map_id

2021-11-11 Thread Fabian Grünbichler
since we are going to reuse the same mechanism/code for network bridge mapping. Signed-off-by: Fabian Grünbichler --- PVE/QemuMigrate.pm | 6 +++--- PVE/QemuServer.pm | 6 -- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index ae3eaf1

[pve-devel] [PATCH v2 qemu-server 3/8] update_vm: allow simultaneous setting of boot-order and dev

2021-11-11 Thread Fabian Grünbichler
else this fails if we check 'boot' before the device was put into the config or pending section. Signed-off-by: Fabian Grünbichler --- Notes: as happens when doing a remote migration and the full config is passed through update_vm_api PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 inserti

[pve-devel] [PATCH v2 qemu-server 4/8] nbd alloc helper: allow passing in explicit format

2021-11-11 Thread Fabian Grünbichler
and make $volname optional, to support remote migration usage without code duplication. Signed-off-by: Fabian Grünbichler --- Notes: v2: new PVE/QemuServer.pm | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.

[pve-devel] [PATCH v2 qemu-server 8/8] api: add remote migrate endpoint

2021-11-11 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- PVE/API2/Qemu.pm | 195 ++- debian/control | 2 + 2 files changed, 195 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 5dab455..4428066 100644 --- a/PVE/API2/Qemu.pm +++ b/P

[pve-devel] [PATCH v2 qemu-server 6/8] migrate: refactor remote VM/tunnel start

2021-11-11 Thread Fabian Grünbichler
no semantic changes intended, except for: - no longer passing the main migration UNIX socket to SSH twice for forwarding - dropping the 'unix:' prefix in start_remote_tunnel's timeout error message Signed-off-by: Fabian Grünbichler --- Notes: v2: fixed nits PVE/QemuMigrate.pm | 158 +++

[pve-devel] [PATCH v2 qemu-server++ 0/15] remote migration

2021-11-11 Thread Fabian Grünbichler
this series adds remote migration for VMs. both live and offline migration including NBD and storage-migrated disks should work. besides lots of rebases, implemented todos and fixed issues the main difference to the previous RFC is that we no longer define remote entries in a config file, but jus

[pve-devel] [PATCH v2 proxmox-websocket-tunnel 3/4] add fingerprint validation

2021-11-11 Thread Fabian Grünbichler
in case we have no explicit fingerprint, we use openssl's regular "PEER" verification. if we have a fingerprint, we ignore openssl altogether and just verify the fingerprint of the presented leaf certificate. Signed-off-by: Fabian Grünbichler --- Notes: v2: new src/main.rs | 47 +++

[pve-devel] [PATCH v2 access-control 2/2] ticket: normalize path for verification

2021-11-11 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- src/PVE/AccessControl.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index dfd3af5..a80ed74 100644 --- a/src/PVE/AccessControl.pm +++ b/src/PVE/AccessControl.pm @@ -457,6 +457,8 @@ my $assemble_sho

[pve-devel] [PATCH v2 access-control 1/2] tickets: add tunnel ticket

2021-11-11 Thread Fabian Grünbichler
just like VNC ticket, but different prefix to prevent confusion. Signed-off-by: Fabian Grünbichler --- src/PVE/AccessControl.pm | 50 ++-- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index

[pve-devel] [PATCH v2 qemu-server 2/8] schema: use pve-bridge-id

2021-11-11 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Notes: requires pve-common with pve-bridge-id PVE/QemuServer.pm | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index e35c1ad..c3e6481 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.p

[pve-devel] [PATCH v2 proxmox-websocket-tunnel 4/4] add packaging

2021-11-11 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Makefile | 44 ++ debian/changelog | 5 debian/control | 57 debian/copyright | 16 + debian/debcargo.toml | 13 ++ 5 files change

[pve-devel] [PATCH v2 proxmox-websocket-tunnel 2/4] add tunnel implementation

2021-11-11 Thread Fabian Grünbichler
the websocket tunnel helper accepts control commands (encoded as single-line JSON) on stdin, and prints responses on stdout. the following commands are available: - "connect" a 'control' tunnel via a websocket - "forward" a local unix socket to a remote socket via a websocket -- if requested, this

[pve-devel] [PATCH v2 qemu-server 5/8] mtunnel: add API endpoints

2021-11-11 Thread Fabian Grünbichler
the following two endpoints are used for migration on the remote side POST /nodes/NODE/qemu/VMID/mtunnel which creates and locks an empty VM config, and spawns the main qmtunnel worker which binds to a VM-specific UNIX socket. this worker handles JSON-encoded migration commands coming in via thi

[pve-devel] [PATCH v2 qemu-server 7/8] migrate: add remote migration handling

2021-11-11 Thread Fabian Grünbichler
remote migration uses a websocket connection to a task worker running on the target node instead of commands via SSH to control the migration. this websocket tunnel is started earlier than the SSH tunnel, and allows adding UNIX-socket forwarding over additional websocket connections on-demand. the

[pve-devel] [PATCH-SERIES manager] small cleanups for scheduler/jobs

2021-11-11 Thread Fabian Ebner
Can also wait until after the release. Just some very minor things that popped up while looking through the patches. Fabian Ebner (3): pvescheduler: simplify code for sleep time calculation jobs: started_job: rename variable to $msg jobs: rename function to better distinguish job state and

[pve-devel] [PATCH manager 3/3] jobs: rename function to better distinguish job state and task status

2021-11-11 Thread Fabian Ebner
Also, default to 'internal error' if the task status within the lock is undef, which shouldn't actually be possible. Signed-off-by: Fabian Ebner --- PVE/Jobs.pm | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/PVE/Jobs.pm b/PVE/Jobs.pm index bfccf7f1..b91d6158 10064

[pve-devel] [PATCH manager 1/3] pvescheduler: simplify code for sleep time calculation

2021-11-11 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/Service/pvescheduler.pm | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/PVE/Service/pvescheduler.pm b/PVE/Service/pvescheduler.pm index a8d548fb..86891827 100755 --- a/PVE/Service/pvescheduler.pm +++ b/PVE/Service/pve

[pve-devel] [PATCH manager 2/3] jobs: started_job: rename variable to $msg

2021-11-11 Thread Fabian Ebner
it's not always an error, but can also be 'OK'. Signed-off-by: Fabian Ebner --- PVE/Jobs.pm | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/PVE/Jobs.pm b/PVE/Jobs.pm index 2fe197d2..bfccf7f1 100644 --- a/PVE/Jobs.pm +++ b/PVE/Jobs.pm @@ -155,17 +155,18 @@ sub starting_

[pve-devel] [PATCH cluster] sysctl snippet: move to /usr/lib and prefix with 10-

2021-11-11 Thread Stoiko Ivanov
following best-practices according to `sysctl.d(5)`: * Packages should install their configuration files in /usr/lib/ ... * It is recommended to prefix all filenames with a two-digit number and a dash ... the conffile removal is inspired by how it was done in `procps` (one of the few packages in

[pve-devel] applied: [PATCH v2 access-control 2/2] ticket: normalize path for verification

2021-11-11 Thread Thomas Lamprecht
On 11.11.21 15:07, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > src/PVE/AccessControl.pm | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.pro

[pve-devel] applied: [PATCH v2 access-control 1/2] tickets: add tunnel ticket

2021-11-11 Thread Thomas Lamprecht
On 11.11.21 15:07, Fabian Grünbichler wrote: > just like VNC ticket, but different prefix to prevent confusion. > > Signed-off-by: Fabian Grünbichler > --- > src/PVE/AccessControl.pm | 50 ++-- > 1 file changed, 38 insertions(+), 12 deletions(-) > > applied,

[pve-devel] applied-series: [PATCH multiple 0/9] PBS-like TFA support in PVE

2021-11-11 Thread Thomas Lamprecht
On 09.11.21 12:26, Wolfgang Bumiller wrote: > This is a bigger TFA upgrade for PVE. > > This also contains the code for a new rust repository which will merge > pve-rs and pmg-rs into 1 git repository. > (git clone currently only available internally as my > `proxmox-perl-rs.git` repository) > >

[pve-devel] applied: [PATCH access-control 1/1] implement version checks for tfa

2021-11-11 Thread Thomas Lamprecht
On 10.11.21 15:11, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > src/PVE/AccessControl.pm | 30 +++--- > 1 file changed, 27 insertions(+), 3 deletions(-) > > applied, with some followups as showed/discussed off-list, thanks! __

[pve-devel] applied: [PATCH v2 http-server 1/1] webproxy: handle unflushed write buffer

2021-11-11 Thread Thomas Lamprecht
On 11.11.21 15:07, Fabian Grünbichler wrote: > for proxied requests, we usually tear down the proxy connection > immediately when closing the source connection. this is not the correct > course of action for bulk one-way data streams that are proxied, where > the source connection might be closed,

[pve-devel] applied-series: [PATCH access-control + manager] tfa followup

2021-11-11 Thread Thomas Lamprecht
On 10.11.21 13:48, Wolfgang Bumiller wrote: > This is a follow up to the previous series doing the following: > Convert the *ancient* user keys (from user.cfg) to new TFA keys > when updating a user's tfa settings. > And support the ancient keys in the authentication code > > Currently this caus

[pve-devel] applied: [PATCH pve-cluster] sysctl: disable net.ipv4.igmp_link_local_mcast_reports

2021-11-11 Thread Thomas Lamprecht
On 06.10.21 10:32, Alexandre Derumier wrote: > currently, when veth or tap interfaces are plugged to bridge, > an igmp v3 report is broadcasted to the network, with the > bridge mac adddress. > > Users have reported problems with hetzner for example, blocking the server > because of the unknown ma

[pve-devel] applied: [PATCH cluster] sysctl snippet: move to /usr/lib and prefix with 10-

2021-11-11 Thread Thomas Lamprecht
On 11.11.21 16:42, Stoiko Ivanov wrote: > following best-practices according to `sysctl.d(5)`: > * Packages should install their configuration files in /usr/lib/ ... > * It is recommended to prefix all filenames with a two-digit number > and a dash ... > > the conffile removal is inspired by how

[pve-devel] applied-series: [PATCH docs 1/3] refactor calendar events into appendix

2021-11-11 Thread Thomas Lamprecht
On 11.11.21 12:07, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > calendar-events.adoc | 73 > pvesr.adoc | 72 ++- > 2 files changed, 75 insertions(+), 70 deletions(-) > create mode 100

[pve-devel] applied-series: [PATCH storage/manager/docs v2] fix #3616: support multiple ceph filesystems

2021-11-11 Thread Thomas Lamprecht
On 25.10.21 16:01, Dominik Csapak wrote: > pve-manager: > > Dominik Csapak (11): > api: ceph-mds: get mds state when multple ceph filesystems exist > ui: ceph: catch missing version for service list > api: cephfs: refactor {ls,create}_fs > api: cephfs: more checks on fs create > api: cep

[pve-devel] [PATCH zfsonlinux] arcstat/arc_summary: workaround for stats only present with cache device

2021-11-11 Thread Stoiko Ivanov
This commit updates Thomas' patch to deal with a 2.0 kernel module with 2.1 arc_summary/arcstat Tested by adding a cache-device to a zpool and running both commands to verify no KeyError exception is thrown. Signed-off-by: Stoiko Ivanov --- I hope the fixup in the patch and commit-log above my S

[pve-devel] applied: [PATCH zfsonlinux] arcstat/arc_summary: workaround for stats only present with cache device

2021-11-11 Thread Thomas Lamprecht
On 11.11.21 18:17, Stoiko Ivanov wrote: > This commit updates Thomas' patch to deal with a 2.0 kernel module > with 2.1 arc_summary/arcstat > > Tested by adding a cache-device to a zpool and running both commands > to verify no KeyError exception is thrown. > > Signed-off-by: Stoiko Ivanov > ---

Re: [pve-devel] [PATCH pve-common 0/2] add disable bridge learning feature

2021-11-11 Thread DERUMIER, Alexandre
Le jeudi 11 novembre 2021 à 11:40 +0100, Thomas Lamprecht a écrit : On 24.09.21 10:48, Alexandre Derumier wrote: Currently, if bridge receive an unknown dest mac (network bug/attack/..), we are flooding packets to all bridge ports. This can waste cpu time, even more with firewall enabled. Also, if

[pve-devel] applied-series: [PATCH docs/manager] add pvescheduler docs, improve vzdump job gui

2021-11-11 Thread Thomas Lamprecht
On 11.11.21 12:07, Dominik Csapak wrote: > pve-manager: > > Dominik Csapak (5): > ui: dc/Backup: never show id input field, autogenerate id > ui: dc/Backup: fix comment sort > api: cluster: add jobs/schedule-analyze api call > ui: dc/Backup: add schedule simulator button > remove pvesche

[pve-devel] applied-series: [PATCH-SERIES manager] small cleanups for scheduler/jobs

2021-11-11 Thread Thomas Lamprecht
On 11.11.21 16:17, Fabian Ebner wrote: > Can also wait until after the release. Just some very minor things > that popped up while looking through the patches. > > > Fabian Ebner (3): > pvescheduler: simplify code for sleep time calculation > jobs: started_job: rename variable to $msg > job

Re: [pve-devel] [PATCH manager] ui: form/CalendarEvent: remove 'first saturday each month' example

2021-11-11 Thread Thomas Lamprecht
On 11.11.21 13:09, Dominik Csapak wrote: > this is currently not supported by calendarevents in pve > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/CalendarEvent.js | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/www/manager6/form/CalendarEvent.js > b/www/manager6/form/Cale

[pve-devel] applied: [PATCH v2 widget-toolkit 1/1] disk list: allow wiping individual partitions

2021-11-11 Thread Thomas Lamprecht
On 06.10.21 11:18, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > No changes from v1. > > src/panel/DiskList.js | 8 > 1 file changed, 8 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com