applied, but this has a weird dependency on 'pmx-users'
which must be defined in the product itself
(because they are not identical)
for now it's ok, but we should resolve that soon
(as soon as we want to reuse this in pbs i'd say)
___
pve-devel maili
applied
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
not applied, we already have the 'libjs-qrcode' package we can use
and the u2f code could remain in pve-manager (since
we won't add it to other prodcuts now that we have webauthn)
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.pro
On 11/9/21 15:17, Dylan Whyte wrote:
Hi,
The patch set works as advertised and is very clean in terms of the
switch from vzdump.cron to jobs.cfg.
thanks for testing!
One very minor inconvenience that i seen was the fact that for
vzdump.cron 'Pool based' backups, you can't simply select 'E
On 09.11.21 12:27, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> data/PVE/DataCenterConfig.pm | 43
> 1 file changed, 43 insertions(+)
>
>
applied, thanks!
___
pve-devel mailing list
pve-dev
On 10.11.21 10:38, Dominik Csapak wrote:
> changing an id is something we generally do not allow, being
> storage/realms/etc. normally we tell the users to delete & recreate,
> though i think the better solution here is to have an additional
> 'comment' field and leave the autogeneration of ids in
Am 05.11.21 um 14:03 schrieb Fabian Grünbichler:
remote migration uses a websocket connection to a task worker running on
the target node instead of commands via SSH to control the migration.
this websocket tunnel is started earlier than the SSH tunnel, and allows
adding UNIX-socket forwarding ov
Am 05.11.21 um 14:03 schrieb Fabian Grünbichler:
we only want to use an explicitly provided migration network, not one
for the local cluster.
Signed-off-by: Fabian Grünbichler
---
src/PVE/AbstractMigrate.pm | 51 +++---
1 file changed, 31 insertions(+), 20 del
applied, but fixed the typo in the last commit message
(s/Uplaod/Upload/)
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
we removed the broadcast of the legacy kv 'ceph-version', but our
gui and api were not completely adapted to the new versions yet
(it seems we forgot)
the ui patch fixes the dashboard and service lists, but the osd panel
is still broken (that needs the api patch)
alternatively to the api patch,
it seems we did not prepare the gui enough for the api changes.
we have to use the node specific versions, not the global 'versions'
object.
also use PVE.Utils.compare_ceph_versions everywhere, since some versions
are strings and others are the parts of the version (e.g. ["16", "2, "6"])
Signed-o
since commit:
fb0cb9b7 ("ceph services: drop broadcasting legacy version pmxcfs KV")
the 'ceph-version' kv is not broadcasted anymore, so we should not query it.
instead use get_ceph_versions
also drop the other legacy keys for the versions
Signed-off-by: Dominik Csapak
---
PVE/API2/Ceph/OSD.p
Am 05.11.21 um 14:03 schrieb Fabian Grünbichler:
Signed-off-by: Fabian Grünbichler
---
Notes:
the checks currently done before the actual migration worker is
forked could be either moved to the client calling this (that then
makes the required API calls) or extracted into a preco
Mostly just nits and suggestions from my side, but there are a handful
of (easily-fixed) issues too.
For the patches for access-control, common, http-server (although I
don't feel qualified there) and patches for qemu-server where I didn't
reply:
Reviewed-by: Fabian Ebner
Am 05.11.21 um 14
Signed-off-by: Wolfgang Bumiller
---
src/PVE/AccessControl.pm | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm
index 0b00847..49cef94 100644
--- a/src/PVE/AccessControl.pm
+++ b/src/PVE/AccessControl.pm
@@ -12,6 +12,7 @@ use D
this happens when the first new tfa entry is added and the
'keys' entry is replaced by "x"
Signed-off-by: Wolfgang Bumiller
---
src/PVE/API2/TFA.pm | 30
src/PVE/AccessControl.pm | 102 ++-
2 files changed, 111 insertions(+), 21 deletions(-)
Signed-off-by: Wolfgang Bumiller
---
debian/control | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/debian/control b/debian/control
index 3ef748b..7b09db3 100644
--- a/debian/control
+++ b/debian/control
@@ -6,11 +6,12 @@ Build-Depends: debhelper (>= 12~),
this way we could also add webauthn as a required tfa type
to the realm configs later on
Signed-off-by: Wolfgang Bumiller
---
src/PVE/AccessControl.pm | 48 +---
1 file changed, 30 insertions(+), 18 deletions(-)
diff --git a/src/PVE/AccessControl.pm b/src/PVE
This is a follow up to the previous series doing the following:
Convert the *ancient* user keys (from user.cfg) to new TFA keys
when updating a user's tfa settings.
And support the ancient keys in the authentication code
Currently this causes a tfa & user config to be locked together
(so the loc
Signed-off-by: Wolfgang Bumiller
---
PVE/Service/pveproxy.pm | 3 +++
debian/control | 1 +
www/Makefile| 1 -
www/index.html.tpl | 2 +-
www/qrcode.min.js | 1 -
5 files changed, 5 insertions(+), 3 deletions(-)
delete mode 100644 www/qrcode.min.js
diff --git a/P
On 10.11.21 13:15, Dominik Csapak wrote:
> we removed the broadcast of the legacy kv 'ceph-version', but our
> gui and api were not completely adapted to the new versions yet
> (it seems we forgot)
>
> the ui patch fixes the dashboard and service lists, but the osd panel
> is still broken (that n
issue reported in forum [0]
seems like it came in with 2a8a4b5e37e87a0a994fe3820b015e051e6259fb
[0]: https://forum.proxmox.com/threads/problem-with-proxmox-boot-tool.99043/
before:
$ cat /mnt/foo/loader/entries/proxmox-5.11.22-7-pve.conf
titleProxmox Virtual Environment
version 5.1
with a reordering of patches (storage #3 before storage #2) and a slight
cosmetic fixup in the last patch.
On October 25, 2021 3:47 pm, Fabian Ebner wrote:
> So that disks can easily be repurposed when a storage is no longer
> needed.
>
>
> Dependency bump pve-manager -> pve-storage is needed.
On November 8, 2021 8:49 am, Fabian Ebner wrote:
> Am 05.11.21 um 11:29 schrieb Fabian Ebner:
>> There are cases where autoactivation can fail, as reported in the
>> community forum [0]. And it could also be that a volume was
>> deactivated by something outside of our control.
>>
>> It doesn't see
On 10.11.21 13:15, Dominik Csapak wrote:
> we removed the broadcast of the legacy kv 'ceph-version', but our
> gui and api were not completely adapted to the new versions yet
> (it seems we forgot)
>
> the ui patch fixes the dashboard and service lists, but the osd panel
> is still broken (that n
and hide the ID column by default
Signed-off-by: Dominik Csapak
---
www/manager6/dc/Backup.js | 17 -
www/manager6/dc/BackupJobDetail.js | 5 +
2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index
we want to write it out to the config as propertyString,
but want it as object in the api (for compatiblity)
Signed-off-by: Dominik Csapak
---
PVE/Jobs/Plugin.pm | 15 +++
PVE/Jobs/VZDump.pm | 27 +++
2 files changed, 42 insertions(+)
diff --git a/PVE/Jobs/Pl
* fixes the saving/loading of the 'prune-backups' field (oops)
* adds correct validation for id
* adds a comment field for jobs
Dominik Csapak (4):
Jobs/VZDump: encode/decode 'prune-backups' where needed
ui: dc/BackupEdit: use correct validation
api: backup/jobs: add comment field to jobs
and encode them with PVE::Tools::encode_text in the config
Signed-off-by: Dominik Csapak
---
PVE/API2/Backup.pm | 14 +-
PVE/Jobs/Plugin.pm | 22 ++
PVE/Jobs/VZDump.pm | 1 +
3 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Backup.pm b/PVE/
we use a 'pve-configid', so use the 'ConfigId' vtype
Signed-off-by: Dominik Csapak
---
www/manager6/dc/Backup.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index dede8e6e..24fa94a6 100644
--- a/www/manager6/dc/Backup.
Signed-off-by: Wolfgang Bumiller
---
src/PVE/AccessControl.pm | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm
index cbf643d..f39ac9c 100644
--- a/src/PVE/AccessControl.pm
+++ b/src/PVE/AccessCo
Signed-off-by: Wolfgang Bumiller
---
PVE/Service/pvestatd.pm | 17 +
1 file changed, 17 insertions(+)
diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
index 474b3ac0..b1e71ec8 100755
--- a/PVE/Service/pvestatd.pm
+++ b/PVE/Service/pvestatd.pm
@@ -28,6 +28,7 @@ use P
Since we're updating the format of the tfa config, this implements the
check to make sure the cluster nodes are all new enough to understand
the new format.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman
following the commit of removing the wrong indentation of the linux
and initrd lines - this commit strips empty lines (and leading
trailing whitespace) in /etc/kernel/cmdline.
I managed to reproduce the issue reported in the forum [0] by adding
empty lines to /etc/kernel/cmdline) - without this -
Huge thanks for addressing this and directly providing a patch (and sorry
for fat-fingering the indentation in the first place)
as discussed off-list - I was not able to reproduce the issue (of a
non-booting system) directly - so the indentation alone was not the
problem.
One thing that rendered
comment inline
On 11/10/21 15:15, Stoiko Ivanov wrote:
following the commit of removing the wrong indentation of the linux
and initrd lines - this commit strips empty lines (and leading
trailing whitespace) in /etc/kernel/cmdline.
I managed to reproduce the issue reported in the forum [0] by ad
On 10.11.21 15:28, Dominik Csapak wrote:
> comment inline
>
> On 11/10/21 15:15, Stoiko Ivanov wrote:
>> following the commit of removing the wrong indentation of the linux
>> and initrd lines - this commit strips empty lines (and leading
>> trailing whitespace) in /etc/kernel/cmdline.
>>
>> I man
following the commit of removing the wrong indentation of the linux
and initrd lines - this commit strips empty lines (and leading
trailing whitespace) in /etc/kernel/cmdline.
I managed to reproduce the issue reported in the forum [0] by adding
empty lines to /etc/kernel/cmdline) - without this -
Using $update_vm_api for unused disks will cause them to end up as a
pending change if the VM is running.
Signed-off-by: Aaron Lauterer
---
That case is already handled for containers but was missed for VMs.
PVE/API2/Qemu.pm | 24 +++-
1 file changed, 15 insertions(+), 9 del
On 10.11.21 15:02, Dominik Csapak wrote:
> * fixes the saving/loading of the 'prune-backups' field (oops)
> * adds correct validation for id
> * adds a comment field for jobs
still missing any documentation update ;)
I'd move out the schedule format section from the replication chapter to an
app
On 10.11.21 15:02, Dominik Csapak wrote:
> * fixes the saving/loading of the 'prune-backups' field (oops)
> * adds correct validation for id
> * adds a comment field for jobs
>
> Dominik Csapak (4):
> Jobs/VZDump: encode/decode 'prune-backups' where needed
> ui: dc/BackupEdit: use correct vali
On 08.11.21 14:07, Dominik Csapak wrote:
> pve-cluster:
>
> Dominik Csapak (1):
> add 'jobs.cfg' to observed files
>
> data/PVE/Cluster.pm | 1 +
> data/src/status.c | 1 +
> 2 files changed, 2 insertions(+)
>
> pve-manager:
>
> Dominik Csapak (5):
> add PVE/Jobs to handle VZDump jobs
>
On 10.11.21 15:11, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> PVE/Service/pvestatd.pm | 17 +
> 1 file changed, 17 insertions(+)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
htt
On 10.11.21 13:49, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> PVE/Service/pveproxy.pm | 3 +++
> debian/control | 1 +
> www/Makefile| 1 -
> www/index.html.tpl | 2 +-
> www/qrcode.min.js | 1 -
> 5 files changed, 5 insertions(+), 3 deleti
48 matches
Mail list logo
