Re: [pve-devel] [PATCH manager 1/7] replace systemd timer with pvescheduler daemon

On 10/29/21 14:05, Fabian Ebner wrote: Am 07.10.21 um 10:27 schrieb Dominik Csapak: From: Thomas Lamprecht The whole thing is already prepared for this, the systemd timer was just a fixed periodic timer with a frequency of one minute. And we just introduced it as the assumption was made that l

Re: [pve-devel] [PATCH manager 4/7] add PVE/Jobs to handle VZDump jobs

General style nit: for new code, for is preferred over foreach Am 07.10.21 um 10:27 schrieb Dominik Csapak: this adds a SectionConfig handling for jobs (only 'vzdump' for now) that represents a job that will be handled by pvescheduler and a basic 'job-state' handling for reading/writing state js

Re: [pve-devel] [PATCH v2 docs] pct: add section for supported distributions

any news for this? On Thu, Oct 14, 2021 at 10:19:16AM +0200, Oguz Bektas wrote: > adds a simple section with a list of officially supported distributions > > Signed-off-by: Oguz Bektas > --- > v1->v2: > * removed list of releases, instead put link to releases page for distro (if > it exists)

Re: [pve-devel] [PATCH manager 4/7] add PVE/Jobs to handle VZDump jobs

On 11/2/21 14:52, Fabian Ebner wrote: [snip] + +sub lock_job_state { +    my ($jobid, $type, $sub) = @_; + +    my $filename = "$lock_dir/$type-$jobid.lck"; Should new locks use .lock? yes, thanks, most of such things are copied... + +    my $res = PVE::Tools::lock_file($filename, 10, $su

Re: [pve-devel] [PATCH v3 storage qemu-server container 0/9] move disk or volume to other guests

On 10/27/21 13:55, Fabian Ebner wrote: Nice work! For all patches except #8 it's only nits from my side, so those are: Reviewed-by: Fabian Ebner Tested-by: Fabian Ebner I did run into one strange issue with RBD upon destroying a VM, but it didn't pop up consistently and maybe it's just m

[pve-devel] [PATCH v4 storage 1/9] storage: add new find_free_volname

This new method exposes the functionality to request a new, not yet used, volname for a storage. The default implementation will return the result from 'find_free_diskname' prefixed with "/" if $scfg->{path} exists. Otherwise it will only return the result from 'find_free_diskname'. If the format

[pve-devel] [PATCH v4 qemu-server 3/9] cli: qm: change move_disk to move-disk

also add alias to keep move_disk working. Signed-off-by: Aaron Lauterer --- PVE/CLI/qm.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 8307dc1..ef99b6d 100755 --- a/PVE/CLI/qm.pm +++ b/PVE/CLI/qm.pm @@ -910,7 +910,8 @@ our $cmddef = {

[pve-devel] [PATCH v4 container 7/9] cli: pct: change move_volume to move-volume

also add alias to keep move_volume working Signed-off-by: Aaron Lauterer --- v1 -> v2: fix alias to actually point to move-volume src/PVE/CLI/pct.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 254b3b3..462917b 100755 --- a/

[pve-devel] [PATCH v4 container 9/9] api: move-volume: cleanup very long lines

Signed-off-by: Aaron Lauterer --- src/PVE/API2/LXC.pm | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index afc16d7..d8afbbc 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -1847,13 +184

[pve-devel] [PATCH v4 container 8/9] api: move-volume: add move to another container

The goal of this is to expand the move-volume API endpoint to make it possible to move a container volume / mountpoint to another container. Currently it works for regular mountpoints though it would be nice to be able to do it for unused mounpoints as well. Signed-off-by: Aaron Lauterer --- Thi

[pve-devel] [PATCH v4 qemu-server 4/9] Drive: add valid_drive_names_with_unused

Signed-off-by: Aaron Lauterer --- v1 -> v2: fixed spacing between - and 1 PVE/QemuServer/Drive.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm index 97b82f9..0f9ceba 100644 --- a/PVE/QemuServer/Drive.pm +++ b/PVE/QemuServer/Drive.pm @@

[pve-devel] [PATCH v4 storage qemu-server container 0/9] move disk or volume to other guests

This is the continuation of 'disk-reassign' but instead of a separate API endpoint we now follow the approach to make it part of the 'move-disk' and 'move-volume' endpoints for VMs and containers. The main idea is to make it easy to move a disk/volume to another guest. Currently this is a manual a

[pve-devel] [PATCH v4 qemu-server 6/9] api: move-disk: cleanup very long lines

Signed-off-by: Aaron Lauterer --- PVE/API2/Qemu.pm | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 9d7722d..c623471 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -3318,13 +3318,15 @@ __PACKAGE__->re

[pve-devel] [PATCH v4 qemu-server 5/9] api: move-disk: add move to other VM

The goal of this is to expand the move-disk API endpoint to make it possible to move a disk to another VM. Previously this was only possible with manual intervertion either by renaming the VM disk or by manually adding the disks volid to the config of the other VM. Signed-off-by: Aaron Lauterer -

[pve-devel] [PATCH v4 storage 2/9] add disk rename feature

Functionality has been added for the following storage types: * directory ones, based on the default implementation: * directory * NFS * CIFS * gluster * ZFS * (thin) LVM * Ceph A new feature `rename` has been introduced to mark which storage plugin supports the feature. Version

Re: [pve-devel] [PATCH v4 container 8/9] api: move-volume: add move to another container

Please wait a bit reviewing this patch. I did send it a bit too early as there are a few things not yet fully done. Especially being able to move unused volume or to move a volume from mpX to an unusedX volume on the target container. Additionally we probably should not allow the rootfs to be m