Re: [pve-devel] [PATCH manager v3 0/7] multi disk/mp in wizard

2021-10-20 Thread Aaron Lauterer
Works quite well :) Tested it on Chromium also in different zoom levels. I encountered a few minor glitches. When I added the max amount of disks / mount points and removed them in rapid succession, the scrolling would get messed up sometimes: - horizontally a bit too wide with the delete butto

Re: [pve-devel] [PATCH v4 firewall 1/2] implement fail2ban backend and API

2021-10-20 Thread Oguz Bektas
On Tue, Oct 19, 2021 at 03:43:49PM +0200, Dominik Csapak wrote: > while the code looks ok IMHO, i have some general questions: > * does it really make sense to hard depend on fail2ban? > could it not also make sense to have it as 'recommends' or 'suggests'? > setting enabled to 1 could then che

Re: [pve-devel] [PATCH v4 firewall 1/2] implement fail2ban backend and API

2021-10-20 Thread Thomas Lamprecht
On 19.10.21 15:43, Dominik Csapak wrote: > while the code looks ok IMHO, i have some general questions: > * does it really make sense to hard depend on fail2ban? >   could it not also make sense to have it as 'recommends' or 'suggests'? >   setting enabled to 1 could then check if its installed and

Re: [pve-devel] [PATCH v4 firewall 1/2] implement fail2ban backend and API

2021-10-20 Thread Thomas Lamprecht
On 20.10.21 14:11, Oguz Bektas wrote: > On Tue, Oct 19, 2021 at 03:43:49PM +0200, Dominik Csapak wrote: >> while the code looks ok IMHO, i have some general questions: >> * does it really make sense to hard depend on fail2ban? >> could it not also make sense to have it as 'recommends' or 'suggest

Re: [pve-devel] partially-applied: [PATCH manager v2 00/12] multi tab disk panel & multi disk wizard

2021-10-20 Thread Thomas Lamprecht
On 19.10.21 15:04, Aaron Lauterer wrote: >> >> applied above, delayed below; mostly because I'd like to have some feedback  >> from >> others here and I'd also like to have the same for CT, to avoid a feature  >> drift in >> the wizards. > > I took the last two patches for a quick spin, and I have

Re: [pve-devel] [PATCH storage/manager] fix #3616: support multiple ceph filesystems

2021-10-20 Thread Aaron Lauterer
On my test cluster I ran into the problem when creating the 2nd or third Ceph FS, that the actual mounting and adding to the PVE storage config failed with the following in the task log: - creating data pool 'foobar_data'... pool foobar_data: applying application = cephfs pool foobar_data:

[pve-devel] applied: [PATCH manager] pvestatd: fix rebalancing cpusets for cgroupv2

2021-10-20 Thread Thomas Lamprecht
On 19.10.21 14:01, Aaron Lauterer wrote: > Tested-By: Aaron Lauterer with above: applied, thanks to both of you! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] SPAM: [PATCH pve-access-control 0/1] Fixed user removing failure

2021-10-20 Thread Jasper Yu
From: Li-Heng Yu <007sea...@gmail.com> Since PVE 7.0, people can't remove user either in Web GUI or CLI, this PR fix the issue by having one more condition check when deleting user. Li-Heng Yu (1): Fixed #3686: User Removing Failure src/PVE/AccessControl.pm | 5 - 1 file changed, 4 insert

[pve-devel] SPAM: [PATCH pve-access-control 0/1] Fixed user removing failure

2021-10-20 Thread Jasper Yu
From: Li-Heng Yu <007sea...@gmail.com> Since PVE 7.0, people can't remove user either in Web GUI or CLI, this PR fix the issue by having one more condition check when deleting user. Li-Heng Yu (1): Fixed #3686: User Removing Failure src/PVE/AccessControl.pm | 5 - 1 file changed, 4 insert

[pve-devel] SPAM: [PATCH pve-access-control 1/1] Fixed #3686: User Removing Failure

2021-10-20 Thread Jasper Yu
From: Li-Heng Yu <007sea...@gmail.com> Signed-off-by: Li-Heng Yu <007sea...@gmail.com> --- src/PVE/AccessControl.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index fcb16bd..0d2c6c0 100644 --- a/src/PVE/AccessControl

[pve-devel] SPAM: [PATCH container 1/1] Fixed #3686: User Removing Failure

2021-10-20 Thread Jasper Yu
Signed-off-by: Li-Heng Yu <007sea...@gmail.com> --- src/PVE/AccessControl.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index fcb16bd..0d2c6c0 100644 --- a/src/PVE/AccessControl.pm +++ b/src/PVE/AccessControl.pm @@ -1