Re: [pve-devel] [PATCH v2 guest-common 2/2] snapshots: abort if new snapshot name is already parent to existing one

2021-10-14 Thread Fabian Ebner
Am 13.10.21 um 14:31 schrieb Oguz Bektas: Signed-off-by: Oguz Bektas --- src/PVE/AbstractConfig.pm | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm index 3348d8a..6849664 100644 --- a/src/PVE/AbstractConfig

[pve-devel] [PATCH v2 docs] pct: add section for supported distributions

2021-10-14 Thread Oguz Bektas
adds a simple section with a list of officially supported distributions Signed-off-by: Oguz Bektas --- v1->v2: * removed list of releases, instead put link to releases page for distro (if it exists) * added simple descriptions from respective websites of distros * put centos and derivatives into

[pve-devel] applied: [PATCH v4 storage 1/1] fix #3580: plugins: make preallocation mode selectable for qcow2 and raw images

2021-10-14 Thread Thomas Lamprecht
On 12.10.21 14:32, Lorenz Stechauner wrote: > the plugins for file based storages > * BTRFS > * CIFS > * Dir > * Glusterfs > * NFS > now allow the option 'preallocation'. > > 'preallocation' can have four values: > * default > * off > * metadata > * falloc > * full > see man pages for `q

[pve-devel] [PATCH qemu-server 1/2] snapshot: fix tpmstate with rbd

2021-10-14 Thread Stefan Reiter
QEMU doesn't know about the tpmstate, so 'do_snapshots_with_qemu' should never return true in that case. Note that inconsistencies related to snapshot timing do not matter much, as the actual TPM data is exported together with other device state by QEMU anyway. Signed-off-by: Stefan Reiter --- A

[pve-devel] [PATCH v3 container 1/2] api: clone_vm: don't include snapshot properties

2021-10-14 Thread Oguz Bektas
apparently this caused a weird[0] bug... when a container with a snapshot was cloned, it would take 'parent: foo' from the original container. if you add a new snapshot 'bar', and then another one 'foo', this causes the snapshots to become parents of each other (thus not parsed correctly in the tre

[pve-devel] [PATCH v3 guest-common 2/2] snapshots: delete parent property if new snapshot name is already a parent to existing one

2021-10-14 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- v2->v3: * automatically delete the 'parent' property for an existing snapshot (instead of aborting) if its the same as the new snapshot name (and the snapshot referenced by 'parent' is not used) src/PVE/AbstractConfig.pm | 11 +-- 1 file changed, 9 insert

[pve-devel] [PATCH qemu-server 2/2] swtpm: wait for pidfile

2021-10-14 Thread Stefan Reiter
swtpm may take a little bit to daemonize, so the pidfile might not be available right after run_command. Causes an ugly warning about using an undefined value in a match, so wait up to 5s for it to appear. Note that in testing this loop only ever got to the first or second iteration, so I believe

[pve-devel] [PATCH v3 container guest-common 0/2] snapshot parent checks for containers

2021-10-14 Thread Oguz Bektas
v2->v3: * automatically delete the 'parent' property for an existing snapshot (instead of aborting) if its the same as the new snapshot name (and the snapshot referenced by 'parent' is not used) pve-container: Oguz Bektas (1): api: clone_vm: don't include snapshot properties src/PVE/API2/LXC.p

[pve-devel] applied: [PATCH v2 container 1/2] api: clone_vm: don't include snapshot properties

2021-10-14 Thread Thomas Lamprecht
On 13.10.21 14:31, Oguz Bektas wrote: > apparently this caused a weird[0] bug... when a container with a snapshot was > cloned, it would take 'parent: foo' from the original container. if you > add a new snapshot 'bar', and then another one 'foo', this causes the > snapshots to become parents of ea

[pve-devel] applied: [PATCH/RFC v3 pve-container 1/1] restore: sanitize config: use new warn() function

2021-10-14 Thread Thomas Lamprecht
On 08.07.21 11:14, Fabian Ebner wrote: > to make it more visible that the task finished with warnings. > > Signed-off-by: Fabian Ebner > --- > > Dependency bump for pve-common needed. > > No changes from v2. > > src/PVE/LXC/Create.pm | 15 +++ > 1 file changed, 11 insertions(+), 4