ssh_host_key_generate did not explicitly return in unmanaged plugin,
causing the post_create_hook to fail because of an invalid hash
reference (cannot use "1" as a HASH ref, "1" was likely being returned
implicitly as the scalar value of 'my ($self) = @_;')
Signed-off-by: Oguz Bektas
---
src/PVE
minor fix for creating unmanaged containers
v1->v2:
* return nothing instead of an empty hash ref
* separate patch for dropping early unmanaged return
Oguz Bektas (2):
setup: fix creating unmanaged containers
setup: drop remaining unmanaged return
src/PVE/LXC/Setup.pm | 2 --
src/
not needed anymore since we have 'unmanaged' plugin, so $self->{plugin}
would be 'unmanaged' and get handled by that instead of an early return.
Signed-off-by: Oguz Bektas
---
src/PVE/LXC/Setup.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm
in
On 05.10.21 10:09, Oguz Bektas wrote:
> minor fix for creating unmanaged containers
>
> v1->v2:
> * return nothing instead of an empty hash ref
> * separate patch for dropping early unmanaged return
>
> Oguz Bektas (2):
> setup: fix creating unmanaged containers
> setup: drop remaining unmana
This option don't have any impact on device itself.
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 19 +++
1 file changed, 19 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 076ce59..907d522 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
+sub vmconfig_update_agent {
+my ($conf, $opt, $value) = @_;
+
+if ($conf->{$opt} && (my $old_agent = parse_guest_agent($conf))) {
+
+ my $agent = parse_guest_agent({$opt => $value});
+
+ # skip non hotpluggable value
+ if (safe_string_ne($agent->{enabled}, $old_agent-
On October 5, 2021 11:46 am, Alexandre Derumier wrote:
> This option don't have any impact on device itself.
>
> Signed-off-by: Alexandre Derumier
> ---
> PVE/QemuServer.pm | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> inde
when the diskid changes
Signed-off-by: Dominik Csapak
---
www/manager6/lxc/MPEdit.js | 5 +
1 file changed, 5 insertions(+)
diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js
index 64e57229..2b4f8ebe 100644
--- a/www/manager6/lxc/MPEdit.js
+++ b/www/manager6/lxc/MPEdit.js
that sets the given vmconfig at the start and selects the first
free mpid
Signed-off-by: Dominik Csapak
---
www/manager6/lxc/MPEdit.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js
index 2b4f8ebe..dba69cb4 100644
--- a/www/manager6
helper for the upcoming MultiMPEdit
Signed-off-by: Dominik Csapak
---
www/manager6/lxc/MPEdit.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js
index 0e772017..64e57229 100644
--- a/www/manager6/lxc/MPEdit.js
+++
uses the MultiDiskPanel as base and implements the necessary
functions/variables
this allows now to create a vm also without any disk
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/qemu/CreateWizard.js | 7 +---
www/manager6/qemu/HDEdit.js | 9 +
this adds a new panel where a user can add multiple disks, intended
for use in the wizard.
Has a simple grid for displaying the already added disks and displays
a warning triangle if the disk is not valid.
this is a base panel for adding multiple disks/mps for vms/ct
respectively.
this combines
for the multi disk panel, we want it to be just a little wider, so
that all form fields are still readable
Signed-off-by: Dominik Csapak
---
www/manager6/window/Wizard.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/window/Wizard.js b/www/manager6/window/Wizar
uses the MultiDiskPanel as a base and implements the necessary
functions/values
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile| 1 +
www/manager6/lxc/CreateWizard.js | 8 +---
www/manager6/lxc/MultiMPEdit.js | 79
3 files changed, 82 inser
this series is a continuation of my previous multi tab / disk series[0]
Introduces multi disk panels for vm and containers in the wizard.
The UX is modeled after Dominics first attempt, but a very different
approach code-wise. instead of having a seperate 'data' panel that
contains the vm config,
Le mardi 05 octobre 2021 à 13:12 +0200, Fabian Grünbichler a écrit :
> shouldn't this be the other way round? check keys which are
> different,
> and have a list of hotpluggable ones, skip if any others are
> different?
>
> that way if we add another property to the agent it's fail-safe
> (defau
by having a vmid <-> pciid mapping in /var/run
i did not check if the vm has the pci device really in the config,
but we should not need that, since we remove the reservation again
in the cleanup step.
if wanted we can of course parse the target vms config and check if
the pci device is still conf
we do not need this group, but want to use the regex where we have
multiple groups, so make it a non-capture group
Signed-off-by: Dominik Csapak
---
PVE/QemuServer/PCI.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm
index 2ee14
on vm start, we reserve all pciids that we use, and
remove the reservation again in vm_stop_cleanup
this way, when a vm starts with a pci device that is already configured
for a different running vm, will not be started and the user gets
the error that the device is already in use
Signed-off-by:
saves a list of pciid <-> vmid mappings in /var/run
that we can check when we start a vm
Signed-off-by: Dominik Csapak
---
PVE/QemuServer/PCI.pm | 89 +++
1 file changed, 89 insertions(+)
diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm
index 56
On 05.10.21 15:11, Dominik Csapak wrote:
> saves a list of pciid <-> vmid mappings in /var/run
> that we can check when we start a vm
a few style nits but also one serious note inline
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/QemuServer/PCI.pm | 89 +
On 05.10.21 15:11, Dominik Csapak wrote:
> we do not need this group, but want to use the regex where we have
> multiple groups, so make it a non-capture group
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/QemuServer/PCI.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, t
Provide support for secure boot by using the new "4m" and "4m-ms"
variants of the OVMF code/vars templates. This is specified on the
efidisk via the 'efitype' and 'ms-keys' parameters.
Signed-off-by: Stefan Reiter
---
Should depend on updated pve-edk2-firmware.
PVE/API2/Qemu.pm| 3 ++-
On 05.10.21 18:02, Stefan Reiter wrote:
> Provide support for secure boot by using the new "4m" and "4m-ms"
> variants of the OVMF code/vars templates. This is specified on the
> efidisk via the 'efitype' and 'ms-keys' parameters.
>
> Signed-off-by: Stefan Reiter
> ---
>
> Should depend on updat
Hi,
I just installed a new box (Intel NUC7i5BNK) with Proxmox 7.0-2, and then
ran an apt update/dist-upgrade, using the PVE test repos:
There seems to be some error whilst upgrading some "trousers" module:
Setting up trousers (0.3.14+fixed1-1.2) ...
> Job for trousers.service failed because the
25 matches
Mail list logo
