[pve-devel] applied: [PATCH qemu-server] migrate: use correct target storage id for checks

2021-09-22 Thread Thomas Lamprecht
On 25.06.21 14:32, Fabian Ebner wrote: > The '--targetstorage' parameter does not apply to shared storages. > > Example for a problem solved with the enabled check: Given a VM with > images only on a shared storage 'storeA', not available on the target > node (i.e. restricted by the nodes property

[pve-devel] [PATCH manager v2 07/12] ui: qemu/OSTypeEdit: drop throwing an error on multiple widgets

2021-09-22 Thread Dominik Csapak
we will have multiple panels with the same widget. Instead of raising an error in that case, simply ignore it, since we normally only want to set the default initially, not when users configured something else Signed-off-by: Dominik Csapak --- www/manager6/qemu/OSTypeEdit.js | 2 +- 1 file chang

[pve-devel] [PATCH manager v2 02/12] ui: form/ControllerSelector: set correct max value for the device-id

2021-09-22 Thread Dominik Csapak
the 'diskControllerMaxIDs' object in Utils does not describe the 'maximum ids', but the maximum *number* of ids, so the max is one less correctly set that instead the api rejected those values (e.g. ide4) already, so its only a ui change Signed-off-by: Dominik Csapak --- www/manager6/form/Cont

[pve-devel] [PATCH manager v2 06/12] ui: qemu/HDEdit: fire an event when the disk id changes

2021-09-22 Thread Dominik Csapak
e.g. from scsi0 to scsi1 or from scsi0 to virtio0 Signed-off-by: Dominik Csapak --- www/manager6/qemu/HDEdit.js | 10 ++ 1 file changed, 10 insertions(+) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index bbd4a2c6..2142c746 100644 --- a/www/manager6/qemu/HDEdit

[pve-devel] [PATCH manager v2 03/12] ui: refactor sortByPreviousUsage and nextFreeDisk

2021-09-22 Thread Dominik Csapak
we'll use them outside of the controllerSelector soon Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 46 + www/manager6/form/ControllerSelector.js | 45 +--- 2 files changed, 54 insertions(+), 37 deletions(-) diff --git a/

[pve-devel] [PATCH manager v2 05/12] ui: qemu/HDEdit: use me instead of this

2021-09-22 Thread Dominik Csapak
more in line with our remaining code style Signed-off-by: Dominik Csapak --- www/manager6/qemu/HDEdit.js | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index ae7e3fde..bbd4a2c6 100644 --- a/www/manager6/qe

[pve-devel] [PATCH manager v2 12/12] ui: window/Wizard: make it a little wider

2021-09-22 Thread Dominik Csapak
for the multi disk panel, we want it to be just a little wider, so that all form fields are still readable Signed-off-by: Dominik Csapak --- www/manager6/window/Wizard.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/window/Wizard.js b/www/manager6/window/Wizar

[pve-devel] [PATCH manager v2 08/12] ui: Utils: add capture group for the id in bus_match

2021-09-22 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 8631a67c..71e5fc9a 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -13,7 +13,7 @@ Ext.define('PVE.Utils

[pve-devel] [PATCH manager v2 04/12] ui: form/ControllerSelector: add updateVMConfig and getConfId

2021-09-22 Thread Dominik Csapak
those are helpers that will be useful when we want to change the vmconfig for the ControllerSelector on the fly Signed-off-by: Dominik Csapak --- www/manager6/form/ControllerSelector.js | 16 1 file changed, 16 insertions(+) diff --git a/www/manager6/form/ControllerSelector.js

[pve-devel] [PATCH manager v2 09/12] ui: form/ControllerSelector: add option for selecting free on inital config

2021-09-22 Thread Dominik Csapak
we will sometimes directly give it a config, so the id can be selected at the start Signed-off-by: Dominik Csapak --- www/manager6/form/ControllerSelector.js | 4 1 file changed, 4 insertions(+) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js

[pve-devel] [PATCH manager v2 10/12] ui: qemu/OSTypeEdit: set ostype in viewmodel

2021-09-22 Thread Dominik Csapak
so that we can retrieve it in the MultiDiskPanel Signed-off-by: Dominik Csapak --- www/manager6/qemu/OSTypeEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js index fad56e8a..d9a0988e 100644 --- a/www/manager6/qemu/OSTypeE

[pve-devel] [PATCH manager v2 00/12] multi tab disk panel & multi disk wizard

2021-09-22 Thread Dominik Csapak
this series is intended to replace dominics and my previous attempts at this [0][1][2] splits the bandwidth options into their on tab on the disk panel and introduces a 'MultiHDEdit' panel which creates/deletes the HDEdit panels on demand. The UX is modeled after Dominics first attempt, but a ver

[pve-devel] [PATCH manager v2 01/12] ui: qemu/HDEdit: move Bandwidth options to a different tab

2021-09-22 Thread Dominik Csapak
for that we have to nest the now two tabs in a tabpanel into an inputpanel. to prevent the options to be collected twice, we override the 'getValues' function of the 'sub-inputpanels' to return an empty object. (we could make that an option for the inputpanel, but not necessary for now) also we ha

[pve-devel] [PATCH manager v2 11/12] ui: add qemu/MultiHDEdit and use it in the wizard

2021-09-22 Thread Dominik Csapak
this adds a new panel where a user can add multiple disks. Has a simple grid for displaying the already added disks and displays a warning triangle if the disk is not valid. This allows also to create a vm without any disk by removing all of them. Signed-off-by: Dominik Csapak --- www/manager6

[pve-devel] [PATCH docs] pct: clarify simple restore mode default fallback storage

2021-09-22 Thread Oguz Bektas
"default local storage" is a bit confusing without the backticks, add that to make it more clear that the 'local' storage will be used by default for restore operations unless `--storage foo` is passed. Signed-off-by: Oguz Bektas --- pct.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[pve-devel] [PATCH manager v2 1/1] ui: close #3504: Add datacenter notes

2021-09-22 Thread Dominik Csapak
From: Dominic Jäger Like notes for nodes. Signed-off-by: Dominic Jäger Signed-off-by: Dominik Csapak --- www/manager6/dc/Config.js | 6 + www/manager6/panel/NotesView.js | 48 + 2 files changed, 31 insertions(+), 23 deletions(-) diff --git a/www/man

[pve-devel] [PATCH cluster v2 1/1] dc.cfg: Add notes to datacenter config

2021-09-22 Thread Dominik Csapak
From: Dominic Jäger Similar to notes for nodes. datacenter.cfg normally uses key-value pairs defined in the schema. We bypass this to allow potentially long comments at the top. Signed-off-by: Dominic Jäger Signed-off-by: Dominik Csapak --- data/PVE/DataCenterConfig.pm | 31 ++

[pve-devel] [PATCH cluster/manager v2] add dc notes

2021-09-22 Thread Dominik Csapak
resend of dominics previous series of this fix changes from v1: * removed the (imho) unecessary parsing of the nonexisting 'description' field in the datacenter.cfg, we never had it before and now it only exists as comment, no need to add it to the description (since it cannot exist using onl

[pve-devel] [PATCH v2 docs] pct: clarify simple restore mode default 'local' storage

2021-09-22 Thread Oguz Bektas
"default local storage" is confusing without the backticks. reword the sentences to make it clearer about `storage` parameter usage. Signed-off-by: Oguz Bektas --- pct.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pct.adoc b/pct.adoc index c5ed243..9a9d4ff 100644 -