[pve-devel] [PATCH container 1/1] feat: set hostname to meta

2021-09-13 Thread Serge Logvinov
Add hostname property in meta-data (nocloud method). Now only user-data has hostname of VM. If you redifine user-data, you lost the hostname. Signed-off-by: Serge Logvinov --- PVE/QemuServer/Cloudinit.pm | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/PVE/Qemu

[pve-devel] [PATCH container 0/1] Set hostname to meta-data (nocloud method)

2021-09-13 Thread Serge Logvinov
*** BLURB HERE *** Serge Logvinov (1): feat: set hostname to meta Add hostname property in meta-data (nocloud method). Now only user-data has hostname of VM. If you redifine user-data, you lost the hostname. Example meta-data here https://cloudinit.readthedocs.io/en/latest/topics/datas

Re: [pve-devel] [PATCH container 1/1] feat: set hostname to meta

2021-09-13 Thread Thomas Lamprecht
On 10.09.21 20:33, Serge Logvinov wrote: > Add hostname property in meta-data (nocloud method). > Now only user-data has hostname of VM. If you redifine user-data, you lost > the hostname. > First, thanks for your contribution! Before incorporating patches from you we'd need a signed CLA sent t

[pve-devel] [PATCH manager] fix #3620: ui: delete empty pbs fingerprint on edit

2021-09-13 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/storage/PBSEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js index 773d41e8..fcbc9548 100644 --- a/www/manager6/storage/PBSEdit.js +++ b/www/manager6/storage/PBSEdit.js @@ -5

[pve-devel] [PATCH storage] btrfs: free image: only remove snapshots for current subvol

2021-09-13 Thread Fabian Ebner
instead of all in the same directory. Reported in the community forum: https://forum.proxmox.com/threads/error-could-not-statfs-no-such-file-or-directory.96057/ Signed-off-by: Fabian Ebner --- PVE/Storage/BTRFSPlugin.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/

[pve-devel] applied: [PATCH manager] fix #3620: ui: delete empty pbs fingerprint on edit

2021-09-13 Thread Thomas Lamprecht
On 13.09.21 10:29, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > www/manager6/storage/PBSEdit.js | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmo

[pve-devel] [RFC manager 1/1] api: nodes: set environment variable for shells started via the API

2021-09-13 Thread Fabian Ebner
so that proxmox-ve's apt hook script can detect this. Signed-off-by: Fabian Ebner --- PVE/API2/Nodes.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index e58d9c10..c57ad995 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Node

[pve-devel] [PATCH proxmox-ve 1/3] apt hook: avoid long line and fix typo

2021-09-13 Thread Fabian Ebner
by making 'upgrade' lowercase. Signed-off-by: Fabian Ebner --- debian/apthook/pve-apt-hook | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index 1f77a1a..d79b6c0 100755 --- a/debian/apthook/pve-apt-hook +++ b/debian/

[pve-devel] [RFC proxmox-ve 3/3] apt hook: disallow major upgrade via virtual console from API/UI

2021-09-13 Thread Fabian Ebner
and adapt the output to avoid too much redundancy. Signed-off-by: Fabian Ebner --- debian/apthook/pve-apt-hook | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index 72a38ca..0eed6eb 100755 --- a/debian/ap

[pve-devel] [PATCH proxmox-ve 2/3] apt hook: mention that console/ssh should be used for major upgrade

2021-09-13 Thread Fabian Ebner
There were a few reports of people trying to upgrade via the virtual console running into problems, because it would be interrupted. The latest one is [0], although I'm speculating that it might not have been the cause of all the reported problems in this case. [0]: https://forum.proxmox.com/thre

[pve-devel] [PATCH-SERIES manager/proxmox-ve] warn against/prevent using virtual console for major upgrade

2021-09-13 Thread Fabian Ebner
Quoting from the upgrade notes: > Perform the actions via console or ssh; preferably via console to avoid > interrupted ssh connections. Do not carry out the upgrade when connected > via the virtual console offered by the GUI; as this will get interrupted > during the upgrade. But some users stil

[pve-devel] [PATCH storage 1/1] fix #3609 add support to SMB3_11

2021-09-13 Thread Moayad Almalat
--- PVE/Storage/CIFSPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm index be06cc7..d4a517d 100644 --- a/PVE/Storage/CIFSPlugin.pm +++ b/PVE/Storage/CIFSPlugin.pm @@ -120,7 +120,7 @@ sub properties { smbvers

[pve-devel] [PATCH storage 0/1] fix #3609 add support to SMB3_11

2021-09-13 Thread Moayad Almalat
Added support for the SMB version SMB3_11 When the `min protocol = SMB3_11` in the smb.conf, the CIFS mount will return with the following error: ``` CIFS VFS: cifs_mount failed w/return code = -95 ``` added an optional option to use the `vers=3.11` PVE/Storage/CIFSPlugin.pm | 2 +- 1 file chang

Re: [pve-devel] [RFC manager 1/1] api: nodes: set environment variable for shells started via the API

2021-09-13 Thread Fabian Ebner
Am 13.09.21 um 14:04 schrieb Fabian Ebner: so that proxmox-ve's apt hook script can detect this. Signed-off-by: Fabian Ebner --- PVE/API2/Nodes.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index e58d9c10..c57ad995 100

[pve-devel] [PATCH proxmox-acme] Add DNS challenge schema for nsupdate.

2021-09-13 Thread Jens Meißner
Signed-off-by: Jens Meißner --- src/dns-challenge-schema.json | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/src/dns-challenge-schema.json b/src/dns-challenge-schema.json index ddfe2b2..a222ed3 100644 --- a/src/dns-challenge-schema.json +++ b/src/dns-chall

[pve-devel] [PATCH pve-docs 1/2] pmxcfs: language and style fixup

2021-09-13 Thread Dylan Whyte
minor language fixup replace usage of 'Proxmox VE' with '{pve}' Signed-off-by: Dylan Whyte --- pmxcfs.adoc | 62 ++--- 1 file changed, 30 insertions(+), 32 deletions(-) diff --git a/pmxcfs.adoc b/pmxcfs.adoc index d4579a7..c0327a2 100644 --- a/pmx

[pve-devel] [PATCH pve-docs 2/2] pmxcfs: add more config files and discuss symlinks

2021-09-13 Thread Dylan Whyte
adds an entry for some config files found in /etc/pve, which were missing. alphabetize the list, for better readability and add some minor fixes also adds an introduction section to the symbolic links section, to clarify that they're specific to each host Signed-off-by: Dylan Whyte --- pmxcfs.ad

Re: [pve-devel] hetzner bug with pve-firewall

2021-09-13 Thread alexandre derumier
Hi, >   > https://git.proxmox.com/?p=pve-firewall.git;a=commit;h=d9e7522b561ceb323e93affb29c9fced89fed967 > > would just require a bump + upload is it possible to backport it to pve 6 ? (I have seen 2 users on the forum requesting it ) Le vendredi 10 septembre 2021 à 12:43 +0200, Fabian Grünb

[pve-devel] [PATCH pve-common] network: disable unicast flooding on tap|veth|fwln ports

2021-09-13 Thread Alexandre Derumier
Currently, if bridge receive an unknown dest mac (network bug/attack/..), we are flooding packets to all bridge ports. This can waste cpu time, even more with firewall enabled. Also, if firewall is used with reject action, the src mac of RST packet is the original unknown dest mac. (This can block

Re: [pve-devel] hetzner bug with pve-firewall

2021-09-13 Thread alexandre derumier
Hi, I just send another patch, without ebtables, but with disabling unicast_flood on vm bridge ports.  maybe can you try it ? Le dimanche 12 septembre 2021 à 12:37 +0200, Josef Per Johansson a écrit : > Hi, > > Yeah sure! It seems a bit better than my hack! > > Yeah I meant the mac-address-ta

Re: [pve-devel] [PATCH pve-common] network: disable unicast flooding on tap|veth|fwln ports

2021-09-13 Thread alexandre derumier
Thinking a little bit more about this, I think we should add an option in vm/ct nic options, to enable it. It could break some network where arp timeout is bigger than default brige ageing-time (5min by default), or with special asymetric networks. Le mardi 14 septembre 2021 à 02:26 +0200, Alexa