[pve-devel] Error when build i18n file

2021-08-25 Thread Claudio Ferreira
Hi I did a lot of translations and I want to try it in my env. I followed this instructions[1] and returned this error: $ ./po2js.pl -t pve pt_BR.po > pve-lang-pt_BR.js Use of uninitialized value in concatenation (.) or string at ./po2js.pl line 91. Unfortunately, google can't help me. Some tip?

Re: [pve-devel] debian11 ifslave bonding bug (with ifupdown1)

2021-08-25 Thread Thomas Lamprecht
Hi, On 25/08/2021 07:55, alexandre derumier wrote: > multiple users have reported problems if ifenslave (ifupdown1), > (maintly upgrade from proxmox6 without switch to ifupdown2) FWIW, I thought about adding a note to the pve6to7 upgrade checker script to recommend switching to ifupdown2, IMO mos

Re: [pve-devel] [RFC firewall] implement fail2ban in firewall

2021-08-25 Thread Oguz Bektas
hi, thank you for the review :) On Tue, Aug 24, 2021 at 08:58:10PM +0200, Thomas Lamprecht wrote: > On 23/08/2021 16:07, Oguz Bektas wrote: > > only as POC/RFC > > > > some thoughts/discussions about the methods/decisions you made would get here. > > E.g., did you think about checking the log

[pve-devel] [PATCH firewall] implement fail2ban backend

2021-08-25 Thread Oguz Bektas
adds a section "[FAIL2BAN]" in the hostfw configuration, which allows the properties 'maxretry' and 'bantime' (in minutes) for the GUI ports. Signed-off-by: Oguz Bektas --- RFC->PATCH: * better parser regex to allow comments in hostfw * use heredoc for multiline file contents * check if filter f

Re: [pve-devel] [RFC firewall] implement fail2ban in firewall

2021-08-25 Thread Thomas Lamprecht
On 25/08/2021 11:34, Oguz Bektas wrote: > On Tue, Aug 24, 2021 at 08:58:10PM +0200, Thomas Lamprecht wrote: >> E.g., did you think about checking the log just directly here, after all we >> run >> every 10s anyway, so one could just directly parse the daemon log and add the >> rules directly here,

[pve-devel] [PATCH pve-docs] fix #844: document first VM/CT start-up delay

2021-08-25 Thread Dylan Whyte
adds paragraphs in the respective qm/pct boot order sections, mentioning the initial VM/CT startup delay feature. Signed-off-by: Dylan Whyte --- pct.adoc | 10 ++ qm.adoc | 8 2 files changed, 18 insertions(+) diff --git a/pct.adoc b/pct.adoc index b88569f..deb57ef 100644 ---

Re: [pve-devel] [PATCH firewall] implement fail2ban backend

2021-08-25 Thread Thomas Lamprecht
Again, I'm not convinced that the approach may be the best we can do, but as I already looked at it I'll quick review that one nonetheless. missing "partially fix #1065" prefix. On 25/08/2021 11:47, Oguz Bektas wrote: > adds a section "[FAIL2BAN]" in the hostfw configuration, which allows > the p

Re: [pve-devel] [PATCH pve-docs] fix #844: document first VM/CT start-up delay

2021-08-25 Thread Thomas Lamprecht
On 25/08/2021 15:15, Dylan Whyte wrote: > adds paragraphs in the respective qm/pct boot order sections, mentioning > the initial VM/CT startup delay feature. > looks OK content wise but what spoke against placing this in a sub-paragraph to the "Proxmox Node Management" section: https://pve.proxmo

Re: [pve-devel] Error when build i18n file

2021-08-25 Thread Thomas Lamprecht
Hi, On 25/08/2021 03:00, Claudio Ferreira wrote: > $ ./po2js.pl -t pve pt_BR.po > pve-lang-pt_BR.js > Use of uninitialized value in concatenation (.) or string at ./po2js.pl > line 91. > > Unfortunately, google can't help me. > Some tip? That's just a warning due to a missing version which we no

[pve-devel] applied: Re: [PATCH v2 container] centos: set /etc/locale.conf to avoid systemd-firstboot hanging

2021-08-25 Thread Thomas Lamprecht
On 24/08/2021 13:35, Oguz Bektas wrote: > we can set the locale to a sane default to avoid the issue described in > forum post [0] > > [0]: > https://forum.proxmox.com/threads/centos-lxc-containers-require-a-reboot.94972/ > > Signed-off-by: Oguz Bektas > --- > v1->v2: > * only write if file doe

Re: [pve-devel] [PATCH firewall] implement fail2ban backend

2021-08-25 Thread Mark Schouten
Hi, Few comments: * I'd say you would enable this on a cluster-level, for all nodes * Please allow a whitelist to be added * Feature request: When fail2ban on a node bans an IP, also add it to a blocklist used by VM's with a Proxmox firewall enabled. --  Mark Schouten CTO, Tuxis B.V. | https

[pve-devel] applied: Re: [PATCH docs] storage: add minimal zfs over iscsi doc

2021-08-25 Thread Thomas Lamprecht
On 06/07/2021 18:45, Stoiko Ivanov wrote: > mostly copied from the wiki-page[0], and adapted to include LIO as > target provider. > > Additionally I added a note to explain that the plugin needs ZFS on > the target side (and does not make your SAN speak ZFS) > > Tested during the PVE 7.0 tests fo

Re: [pve-devel] [PATCH access-control] fix #3513: pass configured proxy to OpenID

2021-08-25 Thread Thomas Lamprecht
On 13/07/2021 10:09, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > seemed like the easiest way to fix this - but we could also change the > proxmox-openid-rs API to take the proxy as parameter.. > seems OK in general, but do we only want to set it in case it actually has

[pve-devel] applied: Re: [PATCH docs] installation: add missing 'you'

2021-08-25 Thread Thomas Lamprecht
On 13/07/2021 12:59, Stoiko Ivanov wrote: > small glitch I noticed while reading through the pmg-docs > > Signed-off-by: Stoiko Ivanov > --- > With reformat to 80 characters/line this looks far larger (it only adds a you > in the first part of the sentence) > > pve-installation.adoc | 10 +-

[pve-devel] applied: Re: [PATCH docs v2] pveceph: update pgcalc url

2021-08-25 Thread Thomas Lamprecht
On 14/07/2021 14:51, Dominik Csapak wrote: > currently the pgcalc tool is only available via waybackmachine of archive.org > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * link changed from old.ceph.com to archive.org since old.ceph.com is > not there anymore... > > pveceph.adoc

Re: [pve-devel] [PATCH v2 1/3] ship proper nodejs module 'pve-eslint'

2021-08-25 Thread Thomas Lamprecht
On 19/07/2021 12:31, Dominik Csapak wrote: > instead of concatenating the eslint module into our app.js, ship > a 'pve-eslint' module that exports the built eslint module > > to do this, we have to leave the module type on 'umd' instead of > changing to 'var' so that nodejs can properly import it.