[pve-devel] [PATCH container 2/3] config: parse_volume: don't die when noerr is set

2021-08-05 Thread Fabian Ebner
AFAICT, the only existing callers using noerr=1 are in __snapshot_delete_remove_drive, and in AbstractConfig's foreach_volume_full, and they both should be fine with the change. Signed-off-by: Fabian Ebner --- Required for the next patch. src/PVE/LXC/Config.pm | 4 +++- 1 file changed, 3 inser

[pve-devel] [PATCH guest-common 2/2] config: activate affected storages for snapshot operations

2021-08-05 Thread Fabian Ebner
For snapshot creation, the storage for the vmstate file is activated via vdisk_alloc when the state file is created. Do not activate the volumes themselves, as that has unnecessary side effects (e.g. waiting for zvol device link for ZFS, mapping the volume for RBD). If a storage can only do snapsh

[pve-devel] [PATCH qemu-server 1/1] snapshot: implement __snapshot_activate_storages

2021-08-05 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/QemuConfig.pm | 19 +++ .../create/qemu-server/303.conf | 13 +++ .../delete/qemu-server/204.conf | 33 ++ .../rollback/qemu-server/303.conf | 34 +++

[pve-devel] [PATCH container 3/3] snapshot: implement __snapshot_activate_storages

2021-08-05 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Requires the previous patch, as otherwise, foreach_volume_full will die when calling parse_volume with 'vmstate'. src/PVE/LXC/Config.pm | 19 +++ .../snapshot-expected/create/lxc/204.conf | 10 ++ .../snapshot-expected/dele

[pve-devel] [PATCH container 1/3] config: snapshot_delete_remove_drive: check for parsed value

2021-08-05 Thread Fabian Ebner
to avoid a potential warning. parse_volume is called with noerr=1, so this might be undef instead of a hash. Signed-off-by: Fabian Ebner --- src/PVE/LXC/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 8557e4c..f832

[pve-devel] [PATCH guest-common 1/2] config: remove unused variable

2021-08-05 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- src/PVE/AbstractConfig.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm index 3348d8a..b3f70f2 100644 --- a/src/PVE/AbstractConfig.pm +++ b/src/PVE/AbstractConfig.pm @@ -829,8 +829,6 @@ sub snapshot_creat

[pve-devel] [PATCH-SERIES guest-common/qemu-server/container] activate storages for snapshot operations

2021-08-05 Thread Fabian Ebner
to make it work when the storage is just not active yet, and have early errors when the storage cannot be activated. Also prohibits snapshot operations when an involved storage is disabled. Both qemu-server and pve-container build-depend upon pve-guest-common for the added tests. pve-guest-comm

[pve-devel] [PATCH-SERIES v2 storage/manager] factoring out RE for backup extension

2021-08-05 Thread Lorenz Stechauner
changes to v1: * also renamed iso/vztmpl REs * new naming schema: $_EXT_RE_<# of capture groups> for example: $BACKUP_EXT_RE_2 pve-storage: Lorenz Stechauner (2): storage: rename REs for iso and vztmpl extensions storage/plugin: factoring out regex for backup extension re PVE/API2/Stora

[pve-devel] [PATCH v2 storage 1/2] storage: rename REs for iso and vztmpl extensions

2021-08-05 Thread Lorenz Stechauner
these changes make it more clear, how many capture groups each RE inclues. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 8 PVE/Storage.pm | 11 +++ PVE/Storage/Plugin.pm | 8 3 files changed, 15 insertions(+), 12 deletions(-) dif

[pve-devel] [PATCH v2 storage 2/2] storage/plugin: factoring out regex for backup extension re

2021-08-05 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/Storage.pm| 12 +++- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index b5c2460..9bc799d 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -108,6 +108,8 @@

[pve-devel] [PATCH v2 manager 1/1] api: aplinfo: rename REs for iso and vztmpl extensions

2021-08-05 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/APLInfo.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/APLInfo.pm b/PVE/APLInfo.pm index 5cee1af8..1eff7107 100644 --- a/PVE/APLInfo.pm +++ b/PVE/APLInfo.pm @@ -84,7 +84,7 @@ sub read_aplinfo_from_fh { my $template;

[pve-devel] [PATCH storage] zfs: fix unmount request

2021-08-05 Thread Fabian Ebner
by not dying when the dataset is already unmounted. Can be triggered for a container by doing two rollbacks in a row. Signed-off-by: Fabian Ebner --- PVE/Storage/ZFSPoolPlugin.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZF

[pve-devel] [PATCH manager] utils: add missing 'tfa' for @pve realm

2021-08-05 Thread Oguz Bektas
was missed in commit 92e7ce43e1d06b4065cd8237cb8b5977224dc3d0 Signed-off-by: Oguz Bektas --- www/manager6/Utils.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index a22eaaa7..4041c010 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Util

Re: [pve-devel] [PATCH v1 qemu-server 5/9] api: move-disk: add move to other VM

2021-08-05 Thread Aaron Lauterer
On 8/3/21 9:34 AM, Fabian Ebner wrote: Am 19.07.21 um 16:52 schrieb Aaron Lauterer: The goal of this is to expand the move-disk API endpoint to make it possible to move a disk to another VM. Previously this was only possible with manual intervertion either by renaming the VM disk or by manuall

[pve-devel] [PATCH widget-toolkit] panel/RRDCharts: enable scrolling for RRDCharts on touchscreens

2021-08-05 Thread Dominik Csapak
quote from extjs docs (AbstractChart.js): If you do have a chart inside a scrollable view, even if it has no interactions, you have to set its touchAction config to the following: touchAction: { panX: true, panY: true } Otherwise, if a touch action started on a chart, a swipe wil

[pve-devel] [PATCH firewall] fix #2721: remove reject tcp 43 from default drop and reject actions

2021-08-05 Thread Lorenz Stechauner
first, '43' is a typo, it should say '113' (if it really is like legacy shorewall [0]). this tcp port corresponds to the ident or authentication service protocol. second, nowdays this reject is not included in shorewall anymore. furthermore it would make no sense to reject specifically this one po

[pve-devel] applied: [PATCH manager] utils: add missing 'tfa' for @pve realm

2021-08-05 Thread Dominik Csapak
applied, thanks :) ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server] api2: only add ide drives for non-legacy bootorders

2021-08-05 Thread Dominik Csapak
@bootorder only contains entries for non-legacy bootorder entries, but the default one contains all cdroms anyway, and if the user explicitely disabled cdroms, it is ok to not add them back for the new cdrom drive. Signed-off-by: Dominik Csapak --- view with -w to see the actual change PVE/API2/

[pve-devel] applied: [PATCH qemu-server] api2: only add ide drives for non-legacy bootorders

2021-08-05 Thread Fabian Grünbichler
thanks! On August 5, 2021 1:53 pm, Dominik Csapak wrote: > @bootorder only contains entries for non-legacy bootorder entries, > but the default one contains all cdroms anyway, and if the user > explicitely disabled cdroms, it is ok to not add them back > for the new cdrom drive. > > Signed-off-by

Re: [pve-devel] [PATCH v1 container 8/9] api: move-volume: add move to another container

2021-08-05 Thread Aaron Lauterer
On 8/3/21 10:14 AM, Fabian Ebner wrote: Am 19.07.21 um 16:52 schrieb Aaron Lauterer: The goal of this is to expand the move-volume API endpoint to make it possible to move a container volume / mountpoint to another container. Currently it works for regular mountpoints though it would be nice

[pve-devel] [PATCH pve-manager 0/2] sdn: permissions improvments

2021-08-05 Thread Alexandre Derumier
- display zones list in global permissions management pathselector - remove vmbrX bridges from bridgeselector if user have permissions on vnets Alexandre Derumier (2): permpathstore: add sdn zones api2 : network: anybridge: don't display bridges if user have access to vnets. PVE/API2/Net

[pve-devel] [PATCH pve-network] get_local_vnets: add permissions on /sdn/vnets/*

2021-08-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Network/SDN.pm b/PVE/Network/SDN.pm index d3399ce..b95dd5b 100644 --- a/PVE/Network/SDN.pm +++ b/PVE/Network/SDN.pm @@ -193,7 +193,7 @@ sub get_local_vnets { my

[pve-devel] [PATCH pve-manager 1/2] permpathstore: add sdn zones

2021-08-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/data/PermPathStore.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/manager6/data/PermPathStore.js b/www/manager6/data/PermPathStore.js index 1dc276b6..cf702c03 100644 --- a/www/manager6/data/PermPathStore.js +++ b/www/manager6/data

[pve-devel] [PATCH pve-manager 2/2] api2 : network: anybridge: don't display bridges if user have access to vnets.

2021-08-05 Thread Alexandre Derumier
This remove vmbr* from bridgeselector if user have access to vnets. (as currently, we don't have have permission management on vmbr$) Signed-off-by: Alexandre Derumier --- PVE/API2/Network.pm | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/PVE/API2/Networ

[pve-devel] [PATCH pve-manager 1/1] api2 : network: anybridge: don't display bridges if user have access to vnets.

2021-08-05 Thread Alexandre Derumier
This remove vmbr* from bridgeselector if user have access to vnets. (as currently, we don't have have permission management on vmbr$) Signed-off-by: Alexandre Derumier --- PVE/API2/Network.pm | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/PVE/API2/Networ

[pve-devel] [PATCH pve-access-control] check_path: add /sdn/vnets/* path

2021-08-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/AccessControl.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index 3d8d01c..a9d97e8 100644 --- a/src/PVE/AccessControl.pm +++ b/src/PVE/AccessControl.pm @@ -944,6 +944,7 @@ sub check_path {