Re: [pve-devel] [PATCH v2 storage] storage/plugin: factoring out regex for backup extension rey

2021-08-03 Thread Wolfgang Bumiller
On Mon, Aug 02, 2021 at 12:52:36PM +0200, Lorenz Stechauner wrote: > Signed-off-by: Lorenz Stechauner > --- > changes to v1: > * factored $compressor_extension_re out of $backup_extension_re > should now be less confusing not sure about less confusing... but I suppose it'll have to do > >

Re: [pve-devel] [PATCH v1 qemu-server 4/9] Drive: add valid_drive_names_with_unused

2021-08-03 Thread Fabian Ebner
Am 19.07.21 um 16:52 schrieb Aaron Lauterer: Signed-off-by: Aaron Lauterer --- PVE/QemuServer/Drive.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm index 5110190..09f37c1 100644 --- a/PVE/QemuServer/Drive.pm +++ b/PVE/QemuServer/Dri

Re: [pve-devel] [PATCH v1 qemu-server 5/9] api: move-disk: add move to other VM

2021-08-03 Thread Fabian Ebner
Am 19.07.21 um 16:52 schrieb Aaron Lauterer: The goal of this is to expand the move-disk API endpoint to make it possible to move a disk to another VM. Previously this was only possible with manual intervertion either by renaming the VM disk or by manually adding the disks volid to the config of

Re: [pve-devel] [PATCH v1 qemu-server 6/9] api: move-disk: cleanup very long lines

2021-08-03 Thread Fabian Ebner
Am 19.07.21 um 16:52 schrieb Aaron Lauterer: Signed-off-by: Aaron Lauterer --- PVE/API2/Qemu.pm | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index ed1179b..0529c1b 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API

Re: [pve-devel] [PATCH v1 container 8/9] api: move-volume: add move to another container

2021-08-03 Thread Fabian Ebner
Am 19.07.21 um 16:52 schrieb Aaron Lauterer: The goal of this is to expand the move-volume API endpoint to make it possible to move a container volume / mountpoint to another container. Currently it works for regular mountpoints though it would be nice to be able to do it for unused mounpoints a

Re: [pve-devel] [PATCH v1 storage qemu-server container 0/9] move disk or volume to other guests

2021-08-03 Thread Fabian Ebner
Looks mostly good to me, mostly nits and suggestions for some improvements. The only real issues I found are the < 9 instead of < 10 for checking the API version, and the check for running containers not being inside lock_config anymore (maybe that is not even a big deal, didn't check in detail

[pve-devel] [PATCH v2 storage 1/2] CephConfig: add optional $secret parameter

2021-08-03 Thread Aaron Lauterer
This allows us to manually pass the used RBD keyring or CephFS secret. Useful mostly when adding external Ceph clusters where we have no other means to fetch them. I renamed the previous $secret to $cephfs_secret to be able to use $secret as parameter. Signed-off-by: Aaron Lauterer --- PVE/Ceph

[pve-devel] [PATCH v2 storage 2/2] Ceph: add keyring parameter for external clusters

2021-08-03 Thread Aaron Lauterer
By adding the keyring for RBD storage or the secret for CephFS ones, it is possible to add an external Ceph cluster with only one API call. Previously the keyring / secret file needed to be placed in /etc/pve/priv/ceph/$storeID.{keyring,secret} manually. Signed-off-by: Aaron Lauterer --- changes

[pve-devel] [PATCH v2 storage 0/2] RBD/Cephfs: new keyring parameter

2021-08-03 Thread Aaron Lauterer
This new parameter allows to set the RBD keyring or CephFS secret for an external Ceph Cluster right when creating the storage. Up until now, they had to be manually placed in /etc/pve/priv/ceph/$file. In order to reuse as much code as possible, I had to adjust the PVE::CephConfig::ceph_create_key

[pve-devel] [PATCH v3 manager 4/5] ui/UploadToStorage: add TaskViewer

2021-08-03 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index 489be9dc..f0c6186f 100644 --- a/www/manager6/wind

[pve-devel] [PATCH v3 storage 2/3] status: remove sleep(1) in file upload

2021-08-03 Thread Lorenz Stechauner
this racey sleep(1) is only there for legacy reasons: because we don't use apache anymore and only emulate its behabiour regarding removing temp files, this is under our own control now and so we can improve this whole situation. this change requires a pve-http-server version, in which the tmpfile

[pve-devel] [PATCH v3 manager 5/5] ui/UplaodToStorage: check file extension

2021-08-03 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 5 + 1 file changed, 5 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index f0c6186f..ec83c581 100644 --- a/www/manager6/window/UploadToStorage.js +++ b/

[pve-devel] [PATCH v3 storage 3/3] fix #3505: status: add checksum and algorithm to file upload

2021-08-03 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 34 ++ 1 file changed, 34 insertions(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index db5a76e..07366cc 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage/Sta

[pve-devel] [PATCH-SERIES v3 http-server/storage/manager] fix #3505: add checksum and algorithm to iso upload

2021-08-03 Thread Lorenz Stechauner
changes to v2: * fixed typo * prefixed suitable patches with 'fix #3505' * removed hidden content input field * moved some part of a patch into the next - did't belong there * replaced all usages of 'id' with 'reference' * using a regex instead of the filenameChange function note: two commits in t

[pve-devel] [PATCH v3 http-server 1/1] anyevent: move unlink from http-server to endpoint

2021-08-03 Thread Lorenz Stechauner
any uploaded file has to be deleted by the corrosponding endpoint. the file upload was only used by the 'upload to storage' feature in pve. this change allows the endpoint to delete the file itself, making the old and racey`sleep 1` (waiting until the worker has opened the file) obsolete. this ch

[pve-devel] [PATCH v3 storage 1/3] status: move unlink from http-server to enpoint

2021-08-03 Thread Lorenz Stechauner
this is the first step in which not the http server removes the temporary file, but the worker itself. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index b838461..a5ac37

[pve-devel] [PATCH v3 manager 3/5] fix #3505: ui/UploadToStorage: add checksum and algorithm

2021-08-03 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 40 ++ 1 file changed, 40 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index e7db41fb..489be9dc 100644 --- a/www/manager6/window/Up

[pve-devel] [PATCH v3 manager 1/5] ui: move upload window into UploadToStorage.js

2021-08-03 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile | 1 + www/manager6/storage/ContentView.js| 195 + www/manager6/window/UploadToStorage.js | 192 3 files changed, 194 insertions(+), 194 deletions(-) create mode 100

[pve-devel] [PATCH v3 manager 2/5] ui: refactor UploadToStorage.js

2021-08-03 Thread Lorenz Stechauner
this also removes the "content" selector from the window. as far as it seems, this selector was never able to select more than one entry, so it was useless. the check for FormData() is also removed, because this is supported by all major browsers for a long time. therefore doStandardSubmit() is al

[pve-devel] [PATCH container/manager] default nesting for unpriv containers in ui

2021-08-03 Thread Dominik Csapak
since many modern containers need the nesting feature to work properly (thanks systemd...), we add a checkbox that is on by default (and disables with unprivileged, since nested privileged containers are not very secure) to do that, we first have to loosen the nesting constraints in the api a bit.

[pve-devel] [PATCH manager 1/2] ui: lxc/Options: allow opening features window for VM.Allocate

2021-08-03 Thread Dominik Csapak
since VM.Allocate can at least change the nesting value Signed-off-by: Dominik Csapak --- www/manager6/lxc/Options.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js index b64d03a9..f2661dfc 100644 --- a/www/manager6/l

[pve-devel] [PATCH container 2/2] allow nesting to be changed for VM.Allocate on unprivileged containers

2021-08-03 Thread Dominik Csapak
instead of it being root only Signed-off-by: Dominik Csapak --- src/PVE/LXC.pm | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 32a2127..abe8ac3 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm

[pve-devel] [PATCH container 1/2] add old config and unprivileged to check_ct_modify_config_perm

2021-08-03 Thread Dominik Csapak
we'll need that for checking the features more granularly Signed-off-by: Dominik Csapak --- src/PVE/API2/LXC.pm| 6 -- src/PVE/API2/LXC/Config.pm | 9 ++--- src/PVE/LXC.pm | 2 +- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/sr

[pve-devel] [PATCH manager 2/2] ui: lxc/CreateWizard: add a 'nesting' checkbox and enable it by default

2021-08-03 Thread Dominik Csapak
but only enable the field for unprivileged containers. We do this, since newer containers need this feature for basic functions. Signed-off-by: Dominik Csapak --- www/manager6/lxc/CreateWizard.js | 10 ++ 1 file changed, 10 insertions(+) diff --git a/www/manager6/lxc/CreateWizard.js b/w

Re: [pve-devel] [PATCH v1 storage 1/9] storage: expose find_free_diskname

2021-08-03 Thread Aaron Lauterer
On 8/2/21 2:56 PM, Fabian Ebner wrote: Am 19.07.21 um 16:52 schrieb Aaron Lauterer: We do not expose the parameter 'add_fmt_suffix' used by the internal implemantion of 'find_free_diskname'. This is something only the plugins themselves know but cannot be determined easily and reliably from an

Re: [pve-devel] [PATCH v1 storage 2/9] add disk rename feature

2021-08-03 Thread Aaron Lauterer
On 8/2/21 2:57 PM, Fabian Ebner wrote: Am 19.07.21 um 16:52 schrieb Aaron Lauterer: Functionality has been added for the following storage types: * directory ones, based on the default implementation: * directory * NFS * CIFS * gluster * ZFS * (thin) LVM * Ceph A new feat

[pve-devel] Proxmox + VDO

2021-08-03 Thread Gilberto Ferreira
Hi there... Does anyone here already try to implement some sort of VDO mapper to use in conjunction with Proxmox VE?? Thanks --- Gilberto Nunes Ferreira (47) 99676-7530 - Whatsapp / Telegram ___ pve-devel mailing list pve-devel@lists.proxmox.com https:/