[pve-devel] applied: Re: [PATCH manager v2] Status/InfluxDB: add 'verify-certificate' option to disable ssl verification

2021-07-29 Thread Thomas Lamprecht
On 28/07/2021 14:11, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > changes from v1: > * rename to 'verify-certificate' > * factor out the options setting > > i left the 'verify_hostname' => 0 in there, because it would not work > with it enabled for self-signed certificates, even

[pve-devel] applied: Re: [PATCH common v2] ProcFSTools: read_proc_stat: add more cpu stats from /proc/stat

2021-07-29 Thread Thomas Lamprecht
On 28/07/2021 14:12, Dominik Csapak wrote: > those fields might be interesting to users. At the moment, this is > only used in the external metrics export. > > These fields exist in the kernel since: > * irq - 2.6.0 > * softirq - 2.6.0 > * steal - 2.6.11 > * guest - 2.6.24 > * guest_nice - 2.6.33

Re: [pve-devel] [PATCH qemu] block/io_uring: resubmit when result is -EAGAIN

2021-07-29 Thread Thomas Lamprecht
On 28/07/2021 12:55, Fabian Ebner wrote: > Quoting from [0]: > > Some setups, like SCSI, can throw spurious -EAGAIN off the softirq > completion path. Normally we expect this to happen inline as part > of submission, but apparently SCSI has a weird corner case where it > can happen as part of

[pve-devel] applied: Re: [PATCH manager] ui: remove local cloud-init live migration limitation

2021-07-29 Thread Thomas Lamprecht
On 27/07/2021 18:42, Mira Limbeck wrote: > With live migration with local cloud-init disk now possible via the CLI > also remove the limitation in the GUI. > > Signed-off-by: Mira Limbeck > --- > www/manager6/window/Migrate.js | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) >

[pve-devel] [PATCH v2 qemu] io_uring: resubmit when result is -EAGAIN

2021-07-29 Thread Fabian Ebner
Linux SCSI can throw spurious -EAGAIN in some corner cases in its completion path, which will end up being the result in the completed io_uring request. Resubmitting such requests should allow block jobs to complete, even if such spurious errors are encountered. Signed-off-by: Fabian Ebner ---

[pve-devel] [PATCH proxmox-apt 4/5] repo: remove has_suite_variant helper

2021-07-29 Thread Fabian Ebner
by exchanging loops in the check_suites function, which was the only user. Exchanging loops also helps for introducing a type for Debian condenames. Signed-off-by: Fabian Ebner --- Breaking change, as the helper was publicly accessable via the type, but it was not actually used outside the libra

[pve-devel] [PATCH proxmox-apt 2/5] repo: make suite_variant helper more general

2021-07-29 Thread Fabian Ebner
use the first appearance of '-' or '/' to detect the variant instead of keeping a list of possible variants, which would need to include things like "-proposed-updates-debug". Signed-off-by: Fabian Ebner --- src/repositories/repository.rs | 12 1 file changed, 4 insertions(+), 8 del

[pve-devel] [PATCH proxmox-apt 3/5] check repos: have caller specify the current suite

2021-07-29 Thread Fabian Ebner
Like that, a potential error is further up the stack, and it's more consistent with what the standard_repository functions do. Signed-off-by: Fabian Ebner --- src/repositories/file.rs | 6 ++ src/repositories/mod.rs | 7 +-- tests/repositories.rs| 6 +++--- 3 files changed, 10 inser

[pve-devel] [PATCH-SERIES proxmox-apt/pve-rs] better detection of standard repositories

2021-07-29 Thread Fabian Ebner
by also requiring the suite to match. Let the caller pass along the current suite instead of auto-detecting, and have the backend only handle static stuff (avoids the need for Result<>). Also refactor check_suites in a similar fashion, so it's more uniform and so that get_current_release_codename

[pve-devel] [PATCH pve-rs 2/2] apt: repos: adapt to further back-end changes

2021-07-29 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Dependency bump for proxmox-apt patches #3 and #5 needed. Can be squashed into the previous patch if all proxmox-apt patches are applied. src/apt/repositories.rs | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/apt/repositories.

[pve-devel] [PATCH pve-rs 1/2] apt: repos: adapt to back-end changes

2021-07-29 Thread Fabian Ebner
It's up to the caller to provide the current release for standard repository detection/addition. Signed-off-by: Fabian Ebner --- Dependency bump for proxmox-apt patch #1 needed. src/apt/repositories.rs | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/apt/repo

[pve-devel] [PATCH proxmox-apt 1/5] standard repos: add suite parameter for stricter detection

2021-07-29 Thread Fabian Ebner
Require that the suite matches too when detecting standard repositories, since no or invalid updates will be obtained when the suite is wrong. Thus, it should not be considered to be the same repository. Add the parameter for get_standard_repository too, so that the two related calls have more sim

[pve-devel] [PATCH proxmox-apt 5/5] add type DebianCodename

2021-07-29 Thread Fabian Ebner
which allows to get rid of an possible error with check_suites, and easily detect unexpected values with get_current_release_codename. The check_repos function needs to be adapted, since the type does not include suite names like oldstable,experimental,etc. Signed-off-by: Fabian Ebner --- src/r

[pve-devel] [PATCH v2 container] vmstatus: include detected IP address of running containers

2021-07-29 Thread Oguz Bektas
add a helper 'find_lxc_ip_address' to fetch IP address of container from its network namespace using lxc-info. for the moment it can be queried with the pct tool: $ pct status 1000 --verbose cpu: 0 cpus: 1 disk: 6422528 diskread: 368640 diskwrite: 0 ipaddress: 192.168.31.83< maxdisk: 4

[pve-devel] NAK: [PATCH v2 container] vmstatus: include detected IP address of running containers

2021-07-29 Thread Thomas Lamprecht
On 29/07/2021 14:26, Oguz Bektas wrote: > add a helper 'find_lxc_ip_address' to fetch IP address of container from > its network namespace using lxc-info. > > for the moment it can be queried with the pct tool: > $ pct status 1000 --verbose > cpu: 0 > cpus: 1 > disk: 6422528 > diskread: 368640 > d

[pve-devel] applied: Re: [PATCH v2 storage] api: status: fix unlink on file upload

2021-07-29 Thread Thomas Lamprecht
On 25/06/2021 09:22, Lorenz Stechauner wrote: > after an error while copying the file to its destination the local > path of the destination was unlinked in every case, even when on the > destination was copied to via scp. > > Signed-off-by: Lorenz Stechauner > --- > PVE/API2/Storage/Status.pm |

[pve-devel] applied: Re: [PATCH qemu-server] Fix #3371: parse ovf: Allow dots in VM name

2021-07-29 Thread Thomas Lamprecht
On 21/07/2021 12:06, Dominic Jäger wrote: > Dots are allow in PVE VM names, so they should not be dropped during import. > > Signed-off-by: Dominic Jäger > --- > PVE/QemuServer/OVF.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks! _

[pve-devel] applied-series: Re: [PATCH kernel 1/2] build: conditionalize -dbgsym package

2021-07-29 Thread Thomas Lamprecht
On 21/07/2021 14:10, Fabian Grünbichler wrote: > via a new, namespaced build profile. > > Signed-off-by: Fabian Grünbichler > --- > test-built with and without build-profile enabled, no content difference > in the other debs. > > debian/control.in | 1 + > debian/rules | 6 +- > 2 file

Re: [pve-devel] [PATCH storage] storage/plugin: factoring out regex for backup extension re

2021-07-29 Thread Thomas Lamprecht
On 22/07/2021 09:05, Lorenz Stechauner wrote: > ping > seems Ok in general, it's all a bit messy here with those different capture groups usage, but that was already the case before, just wishing a bit for redoing this the Nice Way™ with, from top of my head, no real idea about what that would

[pve-devel] applied: Re: [PATCH pve-docs] fix 3523: routed net: make example conform to image

2021-07-29 Thread Thomas Lamprecht
On 21/07/2021 17:43, Dylan Whyte wrote: > Changes the example given in section "3.3.5. Routed Configuration" so > that it's more in line with the accompanying network diagram. > > Signed-off-by: Dylan Whyte > --- > images/default-network-setup-routed.svg | 126 +--- > images/

[pve-devel] applied: Re: [PATCH v2 container] fix #3478: abort container creation on arch detection timeout

2021-07-29 Thread Thomas Lamprecht
On 22/07/2021 09:54, Lorenz Stechauner wrote: > increased the timeout for detect_arch from 5 to 10 seconds. > > until now, on any error detect_architecture would fall back to amd64. > to avoid falling back due to an timeout error this function now dies > on timeout errors. > > additionally minor

[pve-devel] applied: Re: [PATCH v2 qemu] io_uring: resubmit when result is -EAGAIN

2021-07-29 Thread Thomas Lamprecht
On 29/07/2021 11:50, Fabian Ebner wrote: > Linux SCSI can throw spurious -EAGAIN in some corner cases in its > completion path, which will end up being the result in the completed > io_uring request. > > Resubmitting such requests should allow block jobs to complete, even > if such spurious errors

[pve-devel] [PATCH docs] fix #3557: qm/pci-passthrouh: add note about the 'All Functions' checkbox

2021-07-29 Thread Dominik Csapak
So that a user coming from the web-interface can see what the checkbox does. Signed-off-by: Dominik Csapak --- qm-pci-passthrough.adoc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc index 1f2fd88..43b905d 100644 --- a/qm-p

[pve-devel] [PATCH manager] ui: qemu/PCIEdit: change onlineHelp link to vm config section

2021-07-29 Thread Dominik Csapak
link the user directly to the vm config section of the pci passthrough docs, since that is whats happening on that panel. It still is on the same page as the whole passthrough docs, so the remaining info is still there. Signed-off-by: Dominik Csapak --- www/manager6/qemu/PCIEdit.js | 2 +- 1 fi