Re: [pve-devel] [PATCH v2 storage] api: status: fix unlink on file upload

2021-07-22 Thread Lorenz Stechauner
ping On 25.06.21 09:22, Lorenz Stechauner wrote: after an error while copying the file to its destination the local path of the destination was unlinked in every case, even when on the destination was copied to via scp. Signed-off-by: Lorenz Stechauner --- changes to v1: * using 'unlink' inst

Re: [pve-devel] [PATCH storage] storage/plugin: factoring out regex for backup extension re

2021-07-22 Thread Lorenz Stechauner
ping On 28.06.21 10:37, Lorenz Stechauner wrote: Signed-off-by: Lorenz Stechauner --- PVE/Storage.pm| 12 +++- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index b8e6311..ec29b45 100755 --- a/

Re: [pve-devel] [PATCH manager] fix #3426: ui: parser: adapt parseSSHKey to accept "@..." suffix

2021-07-22 Thread Lorenz Stechauner
ping On 07.06.21 12:44, Lorenz Stechauner wrote: also rearranged the regex groups to allow sk-ecdsa-sha2-... note: FIDO keys are now parsable, the backend only supports it with OpenSSH >= 8.2. This may be achieved with upgrading to PVE 7 or using a back port. --- www/manager6/Parser.js | 2 +-

Re: [pve-devel] [PATCH container] fix #3478: abort container creation on arch detection timeout

2021-07-22 Thread Lorenz Stechauner
ping On 29.06.21 15:53, Lorenz Stechauner wrote: increased the timeout for detect_arch from 5 to 10 seconds. until now, on any error detect_architecture would fall back to amd64. to avoid falling back due to an timeout error this function now dies on timeout errors. additionally minor changes

[pve-devel] [PATCH v2 container] fix #3478: abort container creation on arch detection timeout

2021-07-22 Thread Lorenz Stechauner
increased the timeout for detect_arch from 5 to 10 seconds. until now, on any error detect_architecture would fall back to amd64. to avoid falling back due to an timeout error this function now dies on timeout errors. additionally minor changes to the error messages have been made. Signed-off-by

[pve-devel] [PATCH v2 manager 4/5] ui/UploadToStorage: add TaskViewer

2021-07-22 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index 0b4d991a..c63de16a 100644 --- a/www/manager6/wind

[pve-devel] [PATCH v2 storage 1/3] status: move unlink from http-server to enpoint

2021-07-22 Thread Lorenz Stechauner
this is the first step in which not the http server removes the temporary file, but the worker itself. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index 16581aa..fcf972

[pve-devel] [PATCH v2 storage 2/3] status: remove sleep(1) in file upload

2021-07-22 Thread Lorenz Stechauner
this racey sleep(1) is only there for legacy reasons: because we don't use apache anymore and only emulate its behabiour regarding removing temp files, this is under our own control now and so we can improve this whole situation. this change requires a pve-http-server version, in which the tmpfile

[pve-devel] [PATCH v2 manager 1/5] ui: move upload window into UploadToStorage.js

2021-07-22 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile | 1 + www/manager6/storage/ContentView.js| 195 + www/manager6/window/UploadToStorage.js | 192 3 files changed, 194 insertions(+), 194 deletions(-) create mode 100

[pve-devel] [PATCH-SERIES v2 http-server/storage/manager] add checksum and algorithm to iso upload

2021-07-22 Thread Lorenz Stechauner
changes to v1: * dropped commits, that were already applied in the mean time * better commit messages * dropped the 'new-filename' - using 'filename' instead * error handling for unlink * dropped check for `new FormData()` in pve-manager * fixed commit for pve-http-server (deleting temp file on err

[pve-devel] [PATCH v2 http-server 1/1] anyevent: move unlink from http-server to endpoint

2021-07-22 Thread Lorenz Stechauner
any uploaded file has to be deleted by the corrosponding endpoint. the file upload was only used by the 'upload to storage' feature in pve. this change allows the endpoint to delete the file itself, making the old and racey`sleep 1` (waiting until the worker has opened the file) obsolete. this ch

[pve-devel] [PATCH v2 storage 1/1] status: add checksum and algorithm to file upload

2021-07-22 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 34 ++ 1 file changed, 34 insertions(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index 9cf6e40..4b9fda5 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage/Sta

[pve-devel] [PATCH v2 manager 5/5] ui/UplaodToStorage: check file extension

2021-07-22 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 17 + 1 file changed, 17 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index c63de16a..3f4596ce 100644 --- a/www/manager6/window/UploadToSto

[pve-devel] [PATCH v2 manager 3/5] ui/UploadToStorage: add checksum and algorithm

2021-07-22 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 32 ++ 1 file changed, 32 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index fb9850b3..0b4d991a 100644 --- a/www/manager6/window/Up

[pve-devel] [PATCH v2 manager 2/5] ui: refactor UploadToStorage.js

2021-07-22 Thread Lorenz Stechauner
this also removes the "content" selector from the window. as far as it seems, this selector was never able to select more than one entry, so it was useless. the check for FormData() is also removed, because this is supported by all major browsers for a long time. therefore doStandardSubmit() is al

[pve-devel] [PATCH manager] ui: node status: use repo status widget from widget-toolkit

2021-07-22 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Depends on https://lists.proxmox.com/pipermail/pbs-devel/2021-July/003764.html and needs a dependency bump for it. www/manager6/node/StatusView.js | 95 ++--- www/manager6/node/Summary.js| 6 +-- 2 files changed, 18 insertions(+),

Re: [pve-devel] Glusterfs multiple secondary servers

2021-07-22 Thread Alex K
Gentle reminder. I tried also to locate the part at the source code which handles the glusterfs mounts without success. Appreciate any feedback. Alex On Sat, Jul 17, 2021 at 6:24 PM Alex K wrote: > Hi, > > I have a replica 3 gluster storage hosted from the same proxmox nodes. > When adding the g