Re: [pve-devel] [PATCH v11 manager 0/3] fix#1710: add download from url button

2021-07-02 Thread Dominik Csapak
works, patches look good Reviewed-By: Dominik Csapak On 7/1/21 10:50, Lorenz Stechauner wrote: changes to v10: * dropped already applied patches * added "check" button - the gui now does not automatically send the metadata request anymore * removed (visible) content type selector, because the

[pve-devel] [PATCH v2 manager] vzdump: make parse error for storage critical

2021-07-02 Thread Fabian Ebner
The actual error is already printed while parsing the configuration, so there's no real need to make the error message here more than "parse error". It also can end up in the mail subject, which is another reason to keep it simple. Signed-off-by: Fabian Ebner --- Was not applied last time, becau

[pve-devel] [PATCH proxmox-apt] tests: parse and write the result again

2021-07-02 Thread Fabian Ebner
A cheap way to "double" the number of test cases. Signed-off-by: Fabian Ebner --- tests/repositories.rs | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/repositories.rs b/tests/repositories.rs index 289bbe4..67b0255 100644 --- a/tests/repositories.rs +++ b/tests/

[pve-devel] [PATCH manager] api: backup info: prefer kebab-case

2021-07-02 Thread Fabian Ebner
And also add the 'backup-info' endpoint to the index. Suggested-by: Thomas Lamprecht Signed-off-by: Fabian Ebner --- PVE/API2/BackupInfo.pm| 2 +- PVE/API2/Cluster.pm | 3 ++- www/manager6/dc/Backup.js | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Bac

[pve-devel] applied-series: [PATCH manager 1/2] pve6to7: reduce number of cluster PASS statements

2021-07-02 Thread Thomas Lamprecht
On 01.07.21 09:58, Fabian Grünbichler wrote: > these were mostly releveant for upgrading from Corosync 2.x to 3.x - so > keep the warnings/errors, but reduce the noise a bit by skipping lots of > PASS output. > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > on a 3-node cluster this r

[pve-devel] [PATCH i18n] de: fixed fuzzy and empty translations for pve7

2021-07-02 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- de.po | 614 +++--- 1 file changed, 284 insertions(+), 330 deletions(-) diff --git a/de.po b/de.po index 5ad937c..e7fd557 100644 --- a/de.po +++ b/de.po @@ -42,23 +42,22 @@ msgstr "" "starten Sie neu." #

Re: [pve-devel] [PATCH installer] zfs: allow RAID0 with different-sized disks

2021-07-02 Thread Stoiko Ivanov
Thanks for the patch! checked the git-log when and how this got introduced in the first place and it's been like that since zfs raid configuration was introduced... I think the change makes sense - in addition to the case of RAID0 with different sizes, it would also prevent RAID10 with the mirror

[pve-devel] [PATCH v2 manager] cli: tasks: don't treat warning status as an error status

2021-07-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Changes from v1: * Drop already applied patches. * Drop change to exclude warnings in 'tasks' API call when errors=1. One could argue that warnings are not real errors, but in PBS, warnings are also included if errors=1, so keep it consist

[pve-devel] [PATCH widget-toolkit 1/2] Utils: add get_health_icon from PVE

2021-07-02 Thread Dominik Csapak
we'll need it here too Signed-off-by: Dominik Csapak --- src/Utils.js | 36 1 file changed, 36 insertions(+) diff --git a/src/Utils.js b/src/Utils.js index bc602de..866cd83 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -1106,6 +1106,42 @@ utilities: {

[pve-devel] [PATCH widget-toolkit 2/2] node/APTRepositories: rework top status and error grid

2021-07-02 Thread Dominik Csapak
instead of having a title bar and a seperate error grid, add an always visible panel that displays the status (ok, warning, errors) which also contains the error grid (if necessary, ala ceph summary) this makes the panel more consistent to use and it is immediatly visible if something is wrong th

[pve-devel] applied: [PATCH v2 manager] cli: tasks: don't treat warning status as an error status

2021-07-02 Thread Thomas Lamprecht
On 02.07.21 12:35, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > Changes from v1: > * Drop already applied patches. > * Drop change to exclude warnings in 'tasks' API call when > errors=1. One could argue that warnings are not real errors, but > in PBS, warnings

[pve-devel] applied-series: [PATCH-SERIES proxmox-widget-toolkit/pve-rs] Two more APT repo fixes

2021-07-02 Thread Thomas Lamprecht
On 01.07.21 09:53, Fabian Ebner wrote: > proxmox-widget-toolkit: > > Fabian Ebner (1): > apt repos: use correct URL > > src/node/APTRepositories.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > pve-rs: > > Fabian Ebner (1): > apt: avoid overwriting files that could not be

[pve-devel] applied: [PATCH proxmox-apt] tests: parse and write the result again

2021-07-02 Thread Thomas Lamprecht
On 02.07.21 11:31, Fabian Ebner wrote: > A cheap way to "double" the number of test cases. "doubling" is a bit of a stretch but I get where you're coming from ;-) Parser self-tests are still always good to do additionally, ensuring a stable serialization and de-serialization. > > Signed-off-by:

[pve-devel] applied: [PATCH access-control 1/1] api: user: add realmtype to user list

2021-07-02 Thread Thomas Lamprecht
On 01.07.21 14:25, Dominik Csapak wrote: > this makes it much easier to determine if a user can e.g. > change a password or tfa, based on realm > > Signed-off-by: Dominik Csapak > --- > src/PVE/API2/User.pm | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > applied, th

[pve-devel] applied: [PATCH pve-manager] ui: implement OpenId login

2021-07-02 Thread Thomas Lamprecht
On 24.06.21 10:17, Dietmar Maurer wrote: > --- > PVE/HTTPServer.pm | 4 +- > www/manager6/Utils.js | 8 +++ > www/manager6/window/LoginWindow.js | 105 - > 3 files changed, 114 insertions(+), 3 deletions(-) > > applied, thanks! just

[pve-devel] applied-series: [PATCH access-control/manager] add openid gui handling

2021-07-02 Thread Thomas Lamprecht
On 01.07.21 14:24, Dominik Csapak wrote: > for realm add/edit, as well as disabling/hiding irrelevant buttons > > pve-access-control: > > Dominik Csapak (1): > api: user: add realmtype to user list > > src/PVE/API2/User.pm | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-

[pve-devel] applied: [PATCH manager 6/6] ui: Workspace: use domains info to hide password/tfa items

2021-07-02 Thread Thomas Lamprecht
On 01.07.21 14:25, Dominik Csapak wrote: > in the user menu > > we have to make an additional api call here, since it is the only > place (currently) where we can get the realm type > > Signed-off-by: Dominik Csapak > --- > alternatively, we could give that info in the index or the ticket > api

Re: [pve-devel] [RFC storage 1/7] storage: expose find_free_diskname

2021-07-02 Thread Aaron Lauterer
On 6/2/21 10:29 AM, Fabian Ebner wrote: Am 01.06.21 um 18:10 schrieb Aaron Lauterer: Signed-off-by: Aaron Lauterer ---   PVE/Storage.pm | 8   1 file changed, 8 insertions(+) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index aa36bad..93d09ce 100755 --- a/PVE/Storage.pm +++ b/PVE/Sto

[pve-devel] applied: [PATCH widget-toolkit 1/2] Utils: add get_health_icon from PVE

2021-07-02 Thread Thomas Lamprecht
On 02.07.21 12:48, Dominik Csapak wrote: > we'll need it here too > > Signed-off-by: Dominik Csapak > --- > src/Utils.js | 36 > 1 file changed, 36 insertions(+) > > applied, thanks! ___ pve-devel mailing list p

[pve-devel] applied: [PATCH widget-toolkit 2/2] node/APTRepositories: rework top status and error grid

2021-07-02 Thread Thomas Lamprecht
On 02.07.21 12:48, Dominik Csapak wrote: > instead of having a title bar and a seperate error grid, > add an always visible panel that displays the status (ok, warning, errors) > which also contains the error grid (if necessary, ala ceph summary) > > this makes the panel more consistent to use and

Re: [pve-devel] [PATCH i18n] de: fixed fuzzy and empty translations for pve7

2021-07-02 Thread Thomas Lamprecht
Empty translations are by design to save space and to explcitily mark that the original (English) one should be used in that case, please do not "fix" those anymore... On 02.07.21 12:14, Lorenz Stechauner wrote: > Signed-off-by: Lorenz Stechauner > --- > de.po | 614 +++--

[pve-devel] applied: [PATCH i18n] de: fixed fuzzy and empty translations for pve7

2021-07-02 Thread Thomas Lamprecht
On 02.07.21 12:14, Lorenz Stechauner wrote: > Signed-off-by: Lorenz Stechauner > --- > de.po | 614 +++--- > 1 file changed, 284 insertions(+), 330 deletions(-) > > applied, with a few 1:1 translations marked more explicit again, fixing the Pr

[pve-devel] [PATCH widget-toolkit] node/APTRepositories: improve error/warning display

2021-07-02 Thread Dominik Csapak
always show grid besides status, with the accumulated stati/warnings/errors Signed-off-by: Dominik Csapak --- we should take a deep look if the order of the messages are ok, as well as which we should show as the 'overall' status maybe only the overall status ? (ok/warning/error ?) src/node/APT

[pve-devel] applied: [PATCH pve-docs] add OpenId Connect docu

2021-07-02 Thread Thomas Lamprecht
On 01.07.21 10:55, Dietmar Maurer wrote: > --- > pveum.adoc | 88 +- > 1 file changed, 87 insertions(+), 1 deletion(-) > applied, much thanks! FYI fixed three typos > diff --git a/pveum.adoc b/pveum.adoc > index a1adbaa..9329583 100644 > ---

[pve-devel] [PATCH manager 1/1] pve6to7: check for containers not supporting pure cgroupv2

2021-07-02 Thread Stoiko Ivanov
Ordered as much as possible to exit early, still might take quite some time on systems with many containers (which do support cgroupv2). needs a versioned bump on pve-container Signed-off-by: Stoiko Ivanov --- PVE/CLI/pve6to7.pm | 68 ++ 1 file change

[pve-devel] [PATCH manger/container] detect containers not supporting pure cgroupv2

2021-07-02 Thread Stoiko Ivanov
This series addresses the issue of running containers, which boot with a systemd version which is too old (<232) to support the unified cgroup hierarchy - This includes CentOS 7 and Ubuntu 16.04 containers. The patch for pve-container simply logs to syslog with level err to notify the user. Since

[pve-devel] [PATCH container 1/1] prestart-hook: detect cgroupv2 incompatible systemd version

2021-07-02 Thread Stoiko Ivanov
Some container OS (e.g. CentOS 7, Ubuntu 16.04) are booted with systemd, in a version which is not able to run with a pure cgroupv2 (a.k.a unified hierarchy) environment. Detect those in the lxc-pve-prestart-hook, because there we already have all mount-points set up. This approach only leaves sy

[pve-devel] applied: [PATCH docs] pct: clarify needed systemd-versions for cgroupv2 support

2021-07-02 Thread Thomas Lamprecht
On 01.07.21 11:28, Stoiko Ivanov wrote: > versions determined through systemd's changelog, and a few empiric > tests. > > Signed-off-by: Stoiko Ivanov > --- > pct.adoc | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > applied, thanks!

Re: [pve-devel] [PATCH manager 1/1] pve6to7: check for containers not supporting pure cgroupv2

2021-07-02 Thread Thomas Lamprecht
On 02.07.21 20:21, Stoiko Ivanov wrote: > Ordered as much as possible to exit early, still might take quite some > time on systems with many containers (which do support cgroupv2). The early abort once one is found seems like a good idea in general, but I still do not really like that happening un