Re: [pve-devel] Proxmox 7.0 Beta - Ceph "a password is required" error messages?

2021-06-28 Thread Fabian Ebner
Am 25.06.21 um 03:31 schrieb Victor Hooi: Hi, I've setup a new Ceph cluster with the Proxmox 7.0 beta I'm getting notification emails like this: ceph : a password is required ; PWD=/ ; USER=root ; COMMAND=nvme intel smart-log-add --json /dev/nvme0n1 Do you know if this is expected behaviou

[pve-devel] [PATCH storage] storage/plugin: factoring out regex for backup extension re

2021-06-28 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/Storage.pm| 12 +++- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index b8e6311..ec29b45 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -105,6 +105,8 @@

Re: [pve-devel] [PATCH widget-toolkit/manager] unify gui for task listing

2021-06-28 Thread Lorenz Stechauner
Tested VM & node task log. Works as expected But found some minor inconveniences: * When a task is selected and the filter changes, therefore this task is not visible anymore, it is possible to click on the "view" button and see the previously selected task. Better behavior would be to clear th

[pve-devel] [PATCH docs] pct: add short cgroup section

2021-06-28 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- pct.adoc | 49 - 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/pct.adoc b/pct.adoc index 0c90106..28bde7f 100644 --- a/pct.adoc +++ b/pct.adoc @@ -484,7 +484,52 @@ lxc.apparmor.profile = unconfine

Re: [pve-devel] [PATCH docs] pct: add short cgroup section

2021-06-28 Thread Stoiko Ivanov
Thanks for the patch! some minor nits inline (feel free to take or leave them): On Mon, 28 Jun 2021 12:09:59 +0200 Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > pct.adoc | 49 - > 1 file changed, 48 insertions(+), 1 deletio

[pve-devel] [PATCH pve-manager] api2: add name to return type spec of resources

2021-06-28 Thread Hannes Laimer
VM names are returned by the endpoint anyway, therefore it makes sense to add it to the endpoint specification so it also appears in the API docs and is visible when using pvesh with text output. Signed-off-by: Hannes Laimer --- PVE/API2/Cluster.pm | 5 + 1 file changed, 5 insertions(+) dif

[pve-devel] [PATCH v2 docs] pct: add short cgroup section

2021-06-28 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller Reviewed-By: Stoiko Ivanov --- Changes to v1. * Some paragraphs are rephrazed, same overall structure otherwise. * Typo fixes Rb tag included after a short off-list read-through pct.adoc | 51 ++- 1 file changed, 5

[pve-devel] applied: [pmg-devel] [PATCH common 1/2] PVE/JSONSchema: add pve-task-status-type

2021-06-28 Thread Thomas Lamprecht
On 24.06.21 09:10, Dominik Csapak wrote: > to have a format that contains the possible worker task states > > Signed-off-by: Dominik Csapak > --- > src/PVE/JSONSchema.pm | 12 > 1 file changed, 12 insertions(+) > > applied, thanks! Maybe we should name those things a bit more prod

[pve-devel] applied: [PATCH v2 common] fix #3153: INotify: adding comment of interface to inet6 section when this is the only section

2021-06-28 Thread Thomas Lamprecht
On 25.06.21 14:29, Lorenz Stechauner wrote: > Signed-off-by: Lorenz Stechauner > --- > changes to v1: > * using delete instead of undef > * added length check for families > You were right regarding the "inet6" only logic, but it should not hurt to make it more specific either and having more l

[pve-devel] applied: [pmg-devel] [PATCH common 2/2] PVE/Tools: add 'upid_get_status_type'

2021-06-28 Thread Thomas Lamprecht
On 24.06.21 09:10, Dominik Csapak wrote: > as a single point where we get the type of upid status > > Signed-off-by: Dominik Csapak > --- > src/PVE/Tools.pm | 20 > 1 file changed, 20 insertions(+) > > applied, thanks! Renamed it to `upid_normalize_status_type` though, as

[pve-devel] [PATCH installer] grub: only set special config for ZFS

2021-06-28 Thread Fabian Grünbichler
and handle that one via a snippet instead of touching the main '/etc/default/grub' config file. distributor (and disabling os-prober for PVE) are already handled by the product-specific meta packages via snippets - proxmox-ve was the last to join this club in 7.0-2. Signed-off-by: Fabian Grünbich

[pve-devel] partially-applied: [pmg-devel] [PATCH common/pve-manager/pmg-api] unify task filter api

2021-06-28 Thread Thomas Lamprecht
On 24.06.21 09:10, Dominik Csapak wrote: > pmg-api: > > Dominik Csapak (3): > PMG/API2/Tasks: add typefilter > PMG/API2/Tasks: add since and until filter > PMG/API2/Tasks: add statusfilter > applied above, but adapted commit subject as it made not much sense to me, as: * PMG is rather obvi

[pve-devel] [PATCH pve-manager] api2: add name to return type spec of resources

2021-06-28 Thread Hannes Laimer
VM names are returned by the endpoint anyway, therefore it makes sense to add it to the endpoint specification so it also appears in the API docs and is visible when using pvesh with text output. Signed-off-by: Hannes Laimer --- PVE/API2/Cluster.pm | 5 + 1 file changed, 5 insertions(+) dif

[pve-devel] applied: [PATCH widget-toolkit 1/1] node/Tasks: merge improvements from PBS and make it more generic

2021-06-28 Thread Thomas Lamprecht
On 24.06.21 09:16, Dominik Csapak wrote: > this copies most of the task grid from pbs, but adds handling so that > users can add aribtrary filter fields > > the filter fields always present are: > * since > * until > * task type > * task status > > other filters fields can be added by giving an '

[pve-devel] applied: [pmg-devel] [PATCH manager 1/2] PVE/API2/Tasks: add since/until filter for the task list

2021-06-28 Thread Thomas Lamprecht
On 24.06.21 09:10, Dominik Csapak wrote: > similar to pbs > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Tasks.pm | 15 +++ > 1 file changed, 15 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.c

[pve-devel] applied: [pmg-devel] [PATCH manager 2/2] PVE/API2/Tasks: add statusfilter to task list

2021-06-28 Thread Thomas Lamprecht
On 24.06.21 09:10, Dominik Csapak wrote: > similar to pbs. the 'errors' filter parameter still overrides this > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Tasks.pm | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) > > applied, with adapting it to the

[pve-devel] applied: [PATCH manager 1/2] {qemu, lxc}/Config: adapt to new proxmoxNodeTasks

2021-06-28 Thread Thomas Lamprecht
On 24.06.21 09:16, Dominik Csapak wrote: > by adding a preFilter and extraFilter > > Signed-off-by: Dominik Csapak > --- > www/manager6/lxc/Config.js | 4 +++- > www/manager6/qemu/Config.js | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > applied, thanks! ___

[pve-devel] applied: [PATCH manager 2/2] ui: node/Config: add vmid filter to task lists

2021-06-28 Thread Thomas Lamprecht
On 24.06.21 09:16, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > www/manager6/node/Config.js | 8 > 1 file changed, 8 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.pr

Re: [pve-devel] [PATCH widget-toolkit/manager] unify gui for task listing

2021-06-28 Thread Thomas Lamprecht
On 28.06.21 11:45, Lorenz Stechauner wrote: > Tested VM & node task log. Works as expected > > But found some minor inconveniences: > * When a task is selected and the filter changes, therefore this task is not > visible anymore, it is possible to click on the "view" button and see the > previou

[pve-devel] applied: [PATCH pve-manager] api2: add name to return type spec of resources

2021-06-28 Thread Thomas Lamprecht
On 28.06.21 12:40, Hannes Laimer wrote: > VM names are returned by the endpoint anyway, therefore it makes sense > to add it to the endpoint specification so it also appears in the API > docs and is visible when using pvesh with text output. > > Signed-off-by: Hannes Laimer > --- > PVE/API2/Clus

[pve-devel] applied: [PATCH v2 docs] pct: add short cgroup section

2021-06-28 Thread Thomas Lamprecht
On 28.06.21 13:44, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > Reviewed-By: Stoiko Ivanov > --- > Changes to v1. > * Some paragraphs are rephrazed, same overall structure otherwise. > * Typo fixes > Rb tag included after a short off-list read-through > > pct.adoc | 51

[pve-devel] applied: [PATCH installer] grub: only set special config for ZFS

2021-06-28 Thread Thomas Lamprecht
On 28.06.21 15:10, Fabian Grünbichler wrote: > and handle that one via a snippet instead of touching the main > '/etc/default/grub' config file. > > distributor (and disabling os-prober for PVE) are already handled by the > product-specific meta packages via snippets - proxmox-ve was the last to >

[pve-devel] applied: [PATCH v10 manager 1/4] aplinfo: factoring out regex for vztmpl

2021-06-28 Thread Thomas Lamprecht
On 22.06.21 11:19, Lorenz Stechauner wrote: > Signed-off-by: Lorenz Stechauner > --- > PVE/APLInfo.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists

Re: [pve-devel] Proxmox 7.0 Beta - Ceph "a password is required" error messages?

2021-06-28 Thread Victor Hooi
Hi, Yes, I can confirm that file exists on my system: root@angusmtv-vm01:/etc/sudoers.d# cat ceph-osd-smartctl > ## allow ceph-osd (which runs as user ceph) to collect device health > metrics ceph ALL=NOPASSWD: /usr/sbin/smartctl -x --json=o /dev/* > ceph ALL=NOPASSWD: /usr/sbin/nvme * smart-lo