Re: [pve-devel] [PATCH manager] ui: panel/GuestStatusView: readd necessary xtypes

2021-06-25 Thread Thomas Lamprecht
On 24.06.21 17:11, Dominik Csapak wrote: > currently, cbind only applies properties on objects which have > an 'xtype' property. > > commit 38e6634a8fe8c11ec23e555ce55bc1972ccb5ea1 > removed those, thinking the xtype in the 'defaults' is enough > > add them back, noting that cbind does need it, t

[pve-devel] [PATCH v2 storage] api: status: fix unlink on file upload

2021-06-25 Thread Lorenz Stechauner
after an error while copying the file to its destination the local path of the destination was unlinked in every case, even when on the destination was copied to via scp. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) di

[pve-devel] [PATCH manager 1/2] pve6to7: content check: fix detecting pass

2021-06-25 Thread Fabian Ebner
If there is a log_fail, because of misconfigured 'none' content type, the final log_pass should not be printed. Signed-off-by: Fabian Ebner --- PVE/CLI/pve6to7.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.pm index f56dd42c..3d5

[pve-devel] [PATCH manager 2/2] pve6to7: more fine-grained detection of misconfigured guest volumes

2021-06-25 Thread Fabian Ebner
If neither 'rootdir' nor 'images' are configured on a storage, but there are guest images, just log the number of volumes found, instead of listing all and warning. They might well be false positive (e.g. same backing storage configured with different content types). Also detect content type misma

[pve-devel] [PATCH common] fix #3153: INotify: adding interface comment to inet6 section when this is the only section

2021-06-25 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- src/PVE/INotify.pm | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 562a243..ce1efd1 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -1156,6 +1156,12 @@ sub __read_etc_

Re: [pve-devel] [PATCH common] fix #3153: INotify: adding interface comment to inet6 section when this is the only section

2021-06-25 Thread Thomas Lamprecht
On 25.06.21 12:48, Lorenz Stechauner wrote: > Signed-off-by: Lorenz Stechauner > --- > src/PVE/INotify.pm | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm > index 562a243..ce1efd1 100644 > --- a/src/PVE/INotify.pm > +

Re: [pve-devel] Proxmox 7.0 Beta - Ceph "a password is required" error messages?

2021-06-25 Thread Dominik Csapak
On 6/25/21 03:31, Victor Hooi wrote: Hi, I've setup a new Ceph cluster with the Proxmox 7.0 beta I'm getting notification emails like this: ceph : a password is required ; PWD=/ ; USER=root ; COMMAND=nvme intel smart-log-add --json /dev/nvme0n1 Do you know if this is expected behaviour, or

Re: [pve-devel] Proxmox 7.0 Beta - Ceph "a password is required" error messages?

2021-06-25 Thread Dominik Csapak
does the file '/etc/sudoers.d/ceph-osd-smartcl' exist in your installation? sorry, typo, should be '/etc/sudoers.d/ceph-osd-smartctl' ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-

Re: [pve-devel] [PATCH common] fix #3153: INotify: adding interface comment to inet6 section when this is the only section

2021-06-25 Thread Lorenz Stechauner
On 25.06.21 13:18, Thomas Lamprecht wrote: On 25.06.21 12:48, Lorenz Stechauner wrote: Signed-off-by: Lorenz Stechauner --- src/PVE/INotify.pm | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 562a243..ce1efd1 1

[pve-devel] [PATCH v2 common] fix #3153: INotify: adding comment of interface to inet6 section when this is the only section

2021-06-25 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- changes to v1: * using delete instead of undef * added length check for families src/PVE/INotify.pm | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 562a243..8cf4b44 100644 --- a/src

[pve-devel] [PATCH qemu-server] migrate: use correct target storage id for checks

2021-06-25 Thread Fabian Ebner
The '--targetstorage' parameter does not apply to shared storages. Example for a problem solved with the enabled check: Given a VM with images only on a shared storage 'storeA', not available on the target node (i.e. restricted by the nodes property). Then using '--targetstorage storeB' would make