[pve-devel] [PATCH-SERIES v7 manager/common/storage] fix #1710: add downlaod from url button

2021-06-14 Thread Lorenz Stechauner
changes to v6: * Fixed regex for parsing Content-Disposition for filenames (query_url_metadata) * Removed mime type check in frontend completely pve-manager: Lorenz Stechauner (5): api: nodes: add query_url_metadata method api: nodes: refactor aplinfo to use common download function ui: add

[pve-devel] [PATCH v7 manager 3/5] ui: add HashAlgorithmSelector

2021-06-14 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile | 1 + www/manager6/form/HashAlgorithmSelector.js | 16 2 files changed, 17 insertions(+) create mode 100644 www/manager6/form/HashAlgorithmSelector.js diff --git a/www/manager6/Makefile b/www/mana

[pve-devel] [PATCH v7 storage 1/1] status: add download_url method

2021-06-14 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 118 +++-- PVE/Storage.pm | 10 2 files changed, 123 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index 897b4a7..4c1d1fc 10064

[pve-devel] [PATCH v7 common 1/1] tools: add download_file_from_url

2021-06-14 Thread Lorenz Stechauner
code is based on manager:PVE/API2/Nodes.pm:aplinfo Signed-off-by: Lorenz Stechauner --- src/PVE/Tools.pm | 124 +++ 1 file changed, 124 insertions(+) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 16ae3d2..7b82e00 100644 --- a/src/PVE/Tools.pm

[pve-devel] [PATCH v7 manager 4/5] ui: Utils: change download task format

2021-06-14 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index d9567979..9fef29bf 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1776,7 +1776,7 @@ Ext.define('PV

[pve-devel] [PATCH v7 manager 1/5] api: nodes: add query_url_metadata method

2021-06-14 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Nodes.pm | 96 +++ 1 file changed, 96 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index e58d9c10..77fa710a 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -11,6 +11,7 @@ use J

[pve-devel] [PATCH v7 manager 2/5] api: nodes: refactor aplinfo to use common download function

2021-06-14 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Nodes.pm | 89 ++- 1 file changed, 10 insertions(+), 79 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 77fa710a..49abe93a 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -15

[pve-devel] [PATCH v7 manager 5/5] fix #1710: ui: storage: add download from url button

2021-06-14 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/storage/Browser.js | 8 + www/manager6/storage/ContentView.js | 247 +--- 2 files changed, 231 insertions(+), 24 deletions(-) diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js index 5fee9

Re: [pve-devel] [RFC qemu-server] avoid setting lun number for drives when pvscsi controller is used

2021-06-14 Thread Stefan Reiter
On 6/14/21 8:29 AM, Fabian Ebner wrote: Any feedback for this? Looks good to me and works as advertised: Reviewed-by: Stefan Reiter Tested-by: Stefan Reiter The `$unit = $drive->{index} % maxdev` logic doesn't seem useful here though, I think it's a copy/paste from the IDE/SATA code below

[pve-devel] [PATCH storage] diskmanage: fix determining array length

2021-06-14 Thread Fabian Ebner
$#* is the last index, not the length. Signed-off-by: Fabian Ebner --- PVE/Diskmanage.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index 55da2e5..ca6f0b7 100644 --- a/PVE/Diskmanage.pm +++ b/PVE/Diskmanage.pm @@ -915,7 +915,7 @@ sub

[pve-devel] [PATCH container] pct exec: add friendly warning in case container not running

2021-06-14 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- src/PVE/CLI/pct.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 6b63915..ae5254c 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct.pm @@ -189,6 +189,8 @@ __PACKAGE__->register_method ({ if (!@{$param