Am 25.05.21 um 15:27 schrieb Lorenz Stechauner:
remove vmid from data part, it is already contained in object part.
Signed-off-by: Lorenz Stechauner
---
Tested with local udp listener. works as expected.
PVE/Status/InfluxDB.pm | 4
1 file changed, 4 insertions(+)
diff --git a/PVE/Stat
On Tue, May 25, 2021 at 03:26:12PM +0200, Thomas Lamprecht wrote:
> On 25.05.21 15:15, Oguz Bektas wrote:
> > for consistency in post_create_hook. still works as expected
> >
>
> what's the reason/benefit again?
it looked a bit ugly otherwise with all the other ones being state subs,
so it's jus
this series contains preparations/fixes/changes for extjs 7.0
1/11 ("data/ProxmoxProxy: set responseType to undefined for XMLHTTPRequest")
- 5/11 ("panel/RRDChart: fix legend/undoZoom")
are backwards compatible and should also work for extjs 6.0.1
patches from 6/11 will only work with extjs 7.0.0
add a new class 'x-treelist-pve-nav' so that we can use
ui: 'pve-nav'
instead of
ui: 'nav'
which has some default styling we do not want
also overwrite the font to FontAwesome
(extjs 7.0 uses 'FontAwesome 5 Free' which we do not ship)
Signed-off-by: Dominik Csapak
---
src/css/ext6-pmx.css | 10
Am 15.03.21 um 14:00 schrieb Thomas Lamprecht:
On 11.03.21 11:26, Fabian Ebner wrote:
to avoid printing 'template: ' with 'qm status --verbose' if it's false.
Signed-off-by: Fabian Ebner
---
Breaks pve-manager without the previous patch! (e.g. guest's Start/Shutdown
buttons won't be updated
Signed-off-by: Dominik Csapak
---
src/Toolkit.js | 40
1 file changed, 40 deletions(-)
diff --git a/src/Toolkit.js b/src/Toolkit.js
index ba06a33..b38e504 100644
--- a/src/Toolkit.js
+++ b/src/Toolkit.js
@@ -184,46 +184,6 @@ Ext.apply(Ext.form.field.VType
so that there can be no privacy leak, since the default points
to senchas server
Signed-off-by: Dominik Csapak
---
src/Toolkit.js | 3 +++
src/panel/GaugeWidget.js | 2 ++
src/panel/RRDChart.js| 3 +++
3 files changed, 8 insertions(+)
diff --git a/src/Toolkit.js b/src/Toolkit.js
i
extjs 7.0 gives the responseType to the XMLHTTPRequest (which
is 'json' for a json reader), but that means that the response is
automatically decoded by the browser, with no means to get the original
return back
in our case, for successful api calls it would work, but some of our
errors are plain
Signed-off-by: Dominik Csapak
---
src/Toolkit.js | 14 --
1 file changed, 14 deletions(-)
diff --git a/src/Toolkit.js b/src/Toolkit.js
index b38e504..30dffc2 100644
--- a/src/Toolkit.js
+++ b/src/Toolkit.js
@@ -223,20 +223,6 @@ Ext.define('Proxmox.UnderlayPool', {
},
});
-//
Signed-off-by: Dominik Csapak
---
src/Toolkit.js | 7 ---
1 file changed, 7 deletions(-)
diff --git a/src/Toolkit.js b/src/Toolkit.js
index 30dffc2..6f1aee9 100644
--- a/src/Toolkit.js
+++ b/src/Toolkit.js
@@ -393,13 +393,6 @@ Ext.define(null, {
},
});
-// should be fixed with ExtJS
instead of the upstream default of 'async'
we do this since it creates some problems with our callbacks which can
happen during component destruction. The upstream reasoning does not
really makes sense for us normally, since we do not keep any references
around for most things, and thus the garbag
while some scrolling issues where fixed since 6.0.1, some where introduced,
namely:
* for firefox, the correct event to listen to is 'wheel' not 'mousewheel'
* the spinner scroll direction was incorrect
* the boxOverflow scroll direction was incorrect
* the boxOverflow scroll amount was too high
f
upstream code changed a bit, update to current version
Signed-off-by: Dominik Csapak
---
src/Toolkit.js | 121 ++---
1 file changed, 84 insertions(+), 37 deletions(-)
diff --git a/src/Toolkit.js b/src/Toolkit.js
index 517f1a1..b85cd32 100644
--- a/src
the legend is by default of type 'sprite', rever to 'dom'
but we now have to unset the '.legend', else on destruction
extjs tries to destroy it twice
also change the onAfterAnimation listener to 'redraw', since
the original event does not exist anymore, add a buffer to it
so that it is not that he
seems to be fixed, at least i could not reproduce here.
If users report this again, we can still revert it if necessary.
Signed-off-by: Dominik Csapak
---
src/Toolkit.js | 43 ---
1 file changed, 43 deletions(-)
diff --git a/src/Toolkit.js b/src/Toolkit.j
treelist technically allows deselection and this happens on destruction
in extjs 7.0 so simply return early to avoid errors accessing
components that do not exist anymore
Signed-off-by: Dominik Csapak
---
www/manager6/panel/ConfigPanel.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ww
this series contains pve fixes/changes fror extjs7.0
all of these patches should be backwards compatible with 6.0.1
i tried to test every panel/button with extjs 7.0,
but i am sure i forgot one or the other ;)
Dominik Csapak (6):
ui: form/VMCPUFlagSelector: mark radio-buttons as 'not form fiel
on extjs 7.0, this triggers when the handler is not available anymore,
so use the beforedestroy event instead
Signed-off-by: Dominik Csapak
---
www/manager6/tree/SnapshotTree.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/tree/SnapshotTree.js
b/www/manager6/
else they might get picked up individually
Signed-off-by: Dominik Csapak
---
www/manager6/form/VMCPUFlagSelector.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/www/manager6/form/VMCPUFlagSelector.js
b/www/manager6/form/VMCPUFlagSelector.js
index 81874a42..ace3c531 100644
--- a/www/ma
Signed-off-by: Dominik Csapak
---
www/css/ext6-pve.css | 2 +-
www/manager6/panel/ConfigPanel.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css
index acf39c8c..0bad29ad 100644
--- a/www/css/ext6-pve.css
+++ b/www/css
else with extjs 7.0, the first render does not happen yet, because
the grid is not visible at that time
Signed-off-by: Dominik Csapak
---
www/manager6/grid/ResourceGrid.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/www/manager6/grid/ResourceGrid.js
b/www/manager6/gri
in extjs 7.0, setting the displayField overwrites the displayTpl, which
we use here
Signed-off-by: Dominik Csapak
---
www/manager6/form/CalendarEvent.js | 1 -
1 file changed, 1 deletion(-)
diff --git a/www/manager6/form/CalendarEvent.js
b/www/manager6/form/CalendarEvent.js
index 8072eaaa..009
On 26.05.21 10:48, Oguz Bektas wrote:
> On Tue, May 25, 2021 at 03:26:12PM +0200, Thomas Lamprecht wrote:
>> On 25.05.21 15:15, Oguz Bektas wrote:
>>> for consistency in post_create_hook. still works as expected
>>>
>>
>> what's the reason/benefit again?
>
> it looked a bit ugly otherwise with all
remove vmid from data part, it is already contained in object part.
this is accomplished by adding the parameter $excluded to
build_influxdb_payload().
Signed-off-by: Lorenz Stechauner
---
changes to v1:
- not using `delete` anymore
- added parameter `excluded` to build_influxdb_payload()
PVE/S
hi,
thanks for checking
On Tue, May 25, 2021 at 03:45:53PM +0200, Thomas Lamprecht wrote:
> On 25.05.21 15:17, Oguz Bektas wrote:
> > this way when new containers are created the will have a unique
> > /etc/machine-id
> >
>
> why the dbus then? systemd talks explicitly only about /etc/machine-i
On Wed, May 26, 2021 at 11:40:23AM +0200, Oguz Bektas wrote:
> hi,
>
> thanks for checking
>
> On Tue, May 25, 2021 at 03:45:53PM +0200, Thomas Lamprecht wrote:
> > On 25.05.21 15:17, Oguz Bektas wrote:
> > > this way when new containers are created the will have a unique
> > > /etc/machine-id
>
On 26.05.21 11:40, Oguz Bektas wrote:
> so without removing the dbus file we don't get a unique machine-id on
> container
> creation, since the templates seem to have a hardcoded id in the dbus path by
> default. we can also remove that but then we will have to make sure to do that
> for all the r
On Wed, May 26, 2021 at 12:00:13PM +0200, Thomas Lamprecht wrote:
> On 26.05.21 11:40, Oguz Bektas wrote:
> > so without removing the dbus file we don't get a unique machine-id on
> > container
> > creation, since the templates seem to have a hardcoded id in the dbus path
> > by
> > default. we c
On 26.05.21 12:03, Oguz Bektas wrote:
> On Wed, May 26, 2021 at 12:00:13PM +0200, Thomas Lamprecht wrote:
>> On 26.05.21 11:40, Oguz Bektas wrote:
>>> so without removing the dbus file we don't get a unique machine-id on
>>> container
>>> creation, since the templates seem to have a hardcoded id i
pass $clone=1 to avoid removing the file. instead we truncate it to an
empty file
Signed-off-by: Oguz Bektas
---
src/PVE/API2/LXC.pm | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index a9ea3a6..413f466 100644
--
v1 -> v2:
* remove crontab change
* detect if container is using systemd
* handle clones (truncate)
Oguz Bektas (2):
setup: clear /etc/machine-id for newly created containers
clear machine-id also after container clone
src/PVE/API2/LXC.pm | 19 ++-
src/PVE/LXC/Setup.pm
this way when new containers are created they will have a unique
/etc/machine-id
Signed-off-by: Oguz Bektas
---
v1->v2:
* incorporated thomas' suggestions
src/PVE/LXC/Setup.pm | 10 ++
src/PVE/LXC/Setup/Base.pm | 25 +
2 files changed, 35 insertions(+)
dif
reported by user in forum:
https://forum.proxmox.com/threads/problem-when-copying-template-with-2-discs.89851/
Signed-off-by: Lorenz Stechauner
---
PVE/API2/Qemu.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index c56b609..24dba86 1006
setting the sysctls needed on every run should not be too costly
(the original implementation used a `system` invocation, which was
far more expensive), and reduce the chances for side-effects.
Signed-off-by: Stoiko Ivanov
---
tested quickly on a test-installation of mine
src/PVE/Firewall.pm |
On 26.05.21 16:51, Stoiko Ivanov wrote:
> setting the sysctls needed on every run should not be too costly
> (the original implementation used a `system` invocation, which was
> far more expensive), and reduce the chances for side-effects.
>
> Signed-off-by: Stoiko Ivanov
> ---
> tested quickly o
On 26.05.21 16:19, Lorenz Stechauner wrote:
> reported by user in forum:
> https://forum.proxmox.com/threads/problem-when-copying-template-with-2-discs.89851/
>
> Signed-off-by: Lorenz Stechauner
> ---
> PVE/API2/Qemu.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, than
---
fr.po | 925 +-
1 file changed, 333 insertions(+), 592 deletions(-)
diff --git a/fr.po b/fr.po
index 157522e..1e45503 100644
--- a/fr.po
+++ b/fr.po
@@ -25,13 +25,12 @@ msgstr ""
"X-Poedit-SearchPath-1: ../www/manager\n"
#: pve-manag
This add ipam support for nic using sdn vnets.
- if ips are specified manally, we verify that subnet exist on vnet, and we
register ip in ipam
- if nic is on a vnet, but no ip is specified, we auto find the next available
ips in this vnet subnet
- if a gateway is defined on the subnet, we overri
On 26.05.21 11:25, Lorenz Stechauner wrote:
> remove vmid from data part, it is already contained in object part.
> this is accomplished by adding the parameter $excluded to
> build_influxdb_payload().
>
> Signed-off-by: Lorenz Stechauner
> ---
> changes to v1:
> - not using `delete` anymore
> -
On 11.03.21 11:26, Fabian Ebner wrote:
> to avoid printing 'template: ' with 'qm status --verbose' if it's false.
>
> Signed-off-by: Fabian Ebner
> ---
>
> Breaks pve-manager without the previous patch! (e.g. guest's Start/Shutdown
> buttons won't be updated anymore)
>
> Changes from v1:
>
On 11.03.21 11:26, Fabian Ebner wrote:
> to avoid printing 'template: ' with 'pct status --verbose' if it's false.
>
> Signed-off-by: Fabian Ebner
> ---
>
> Breaks pve-manager without the first patch! (e.g. guest's Start/Shutdown
> buttons won't be updated anymore)
>
> Changes from v1:
> *
Hello Thomas,
Thanks for all these clarifications, I was able to move forward and put a V0.
https://github.com/jbsky/proxmox-saml2-auth/commit/75c9f089170aacf02370ab86bfa8c75fe0c76a6a.diff
Instead of creating a POST /access/saml endpoint, I finally reused the POST
/access/ticket (thanks for you
On May 26, 2021 4:18 pm, Oguz Bektas wrote:
> pass $clone=1 to avoid removing the file. instead we truncate it to an
> empty file
>
> Signed-off-by: Oguz Bektas
> ---
>
> src/PVE/API2/LXC.pm | 19 ++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/AP
43 matches
Mail list logo
