Signed-off-by: Fabian Ebner
---
de.po | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/de.po b/de.po
index 3bf4387..7ce861c 100644
--- a/de.po
+++ b/de.po
@@ -3815,7 +3815,7 @@ msgstr "Stunden behalten"
#: pmg-gui/js/PBSRemoteEdit.js:138
#: proxmox-backup/www/datastore/
changes to v3:
split up into more patches
CT template download (aplinfo) and download from url refactored
to use same (now new) function in PVE::Tools
patches:
1 - manager: add query_url_metadata method
2 - common: add download_file_from_url
3 - manager: refactor aplinfo to use common download
code is based on
manager:PVE/API2/Nodes.pm:aplinfo
Signed-off-by: Lorenz Stechauner
---
src/PVE/Tools.pm | 123 +++
1 file changed, 123 insertions(+)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 16ae3d2..c751426 100644
--- a/src/PVE/Tools.pm
Signed-off-by: Lorenz Stechauner
---
PVE/API2/Nodes.pm | 89 ++-
1 file changed, 10 insertions(+), 79 deletions(-)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index a6681ab3..34cd2f7c 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -15
Signed-off-by: Lorenz Stechauner
---
www/manager6/Makefile | 1 +
www/manager6/form/HashAlgorithmSelector.js | 16
2 files changed, 17 insertions(+)
create mode 100644 www/manager6/form/HashAlgorithmSelector.js
diff --git a/www/manager6/Makefile b/www/mana
Signed-off-by: Lorenz Stechauner
---
www/manager6/Utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 581d2040..38306c11 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1819,7 +1819,7 @@ Ext.define('PV
Signed-off-by: Lorenz Stechauner
---
www/manager6/storage/Browser.js | 8 +
www/manager6/storage/ContentView.js | 282 +---
2 files changed, 265 insertions(+), 25 deletions(-)
diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js
index 5fee9
Signed-off-by: Lorenz Stechauner
---
PVE/API2/Nodes.pm | 95 +++
1 file changed, 95 insertions(+)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index e58d9c10..a6681ab3 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -11,6 +11,7 @@ use J
Signed-off-by: Lorenz Stechauner
---
PVE/API2/Storage/Status.pm | 117 +++--
PVE/Storage.pm | 10
2 files changed, 122 insertions(+), 5 deletions(-)
diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm
index 897b4a7..e1d656e 10064
Signed-off-by: Lorenz Stechauner
---
Somehow I forgot to git add Status.pm after a fix...
PVE/API2/Storage/Status.pm | 117 +++--
PVE/Storage.pm | 10
2 files changed, 122 insertions(+), 5 deletions(-)
diff --git a/PVE/API2/Storage/Status.pm b/
hi,
see inline for some small suggestions :)
On Thu, May 06, 2021 at 11:11:00AM +0200, Lorenz Stechauner wrote:
> code is based on
> manager:PVE/API2/Nodes.pm:aplinfo
>
> Signed-off-by: Lorenz Stechauner
> ---
> src/PVE/Tools.pm | 123 +++
> 1 file c
thanks for the review, something on top inline.
On 06.05.21 12:04, Oguz Bektas wrote:
> On Thu, May 06, 2021 at 11:11:00AM +0200, Lorenz Stechauner wrote:
>> +
>> +my @cmd = ('/usr/bin/wget', '--progress=dot:mega', '-O', $tmpdest,
>> $url);
>> +
>> +local %ENV;
>> +if ($o
could be triggered when there are no backup storages at all configured or if
the 'Backup now' button is clicked before the storage selector from the guests
'Backup' tab could load its store.
Signed-off-by: Fabian Ebner
---
www/manager6/window/Backup.js | 4
1 file changed, 4 insertions(+)
Changes from v4:
* dropped already applied patches
* added a few small follow-ups and preparation:
* set loading mask early enough
* switch to two-column layout
* changes for the main patch:
* fix labels and gettext usage
* only show retention settings wh
in preparation to add more items in the future, e.g. removal settings, note
container.
Signed-off-by: Fabian Ebner
---
www/manager6/window/Backup.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 2625a718
It's not an Ext.form.Panel, so there is no fieldDefaults.
Signed-off-by: Fabian Ebner
---
www/manager6/window/Backup.js | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 8d9824f3..2625a718 100644
--
so that mailto and mode are not overwritten if the first /vzdump/defaults call
failed, but a later one succeeds.
Signed-off-by: Fabian Ebner
---
www/manager6/window/Backup.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 7
and also show the retention options that will be used for a given storage. A
user with Datastore.AllocateSpace and VM.Backup can already remove backups from
the GUI manually, so it shouldn't be a problem if they can set the remove flag
when starting a manual backup in the GUI.
Signed-off-by: Fabia
but not too early. Because of an ExtJS bug/limitation, it can only happen after
the window is rendered, so use an afterrender listener. Without setting the
mask there, the window will be active already before the storage selectors
change listener triggers, which can only happen after the storage se
On 06.05.21 14:15, Thomas Lamprecht wrote:
> sub check_file_hash
>my ($algorithm, $expected, $file) = @_;
>
>my $algorithm_map = {
> 'sha256' => sub { Digest::SHA->new(512) },
argh, naturally above should use 256, but you get the idea ;-)
> 'sha512' => sub { Digest::SHA->new(
one comment inline
On 5/6/21 11:10, Lorenz Stechauner wrote:
Signed-off-by: Lorenz Stechauner
---
PVE/API2/Nodes.pm | 95 +++
1 file changed, 95 insertions(+)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index e58d9c10..a6681ab3 100644
--- a
On the API/CLI side we already have a max of 16.
Signed-off-by: Aaron Lauterer
---
I guess this was just something that never bothered anyone before as the
API had the limit of 16 sincei at least 2016 (commit cd9c34d1).
www/manager6/qemu/NetworkEdit.js | 2 +-
1 file changed, 1 insertion(+), 1
to avoid showing settings for the wrong storage.
Signed-off-by: Fabian Ebner
---
Sorry for the delayed fix-up/follow-up to the series.
Could also be squashed into patch #6.
www/manager6/window/Backup.js | 5 +
1 file changed, 5 insertions(+)
diff --git a/www/manager6/window/Backup.js b/w
23 matches
Mail list logo
